You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@knox.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2019/11/12 03:32:00 UTC

[jira] [Work logged] (KNOX-2122) Code cleanup from static code analysis

     [ https://issues.apache.org/jira/browse/KNOX-2122?focusedWorklogId=341649&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-341649 ]

ASF GitHub Bot logged work on KNOX-2122:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 12/Nov/19 03:31
            Start Date: 12/Nov/19 03:31
    Worklog Time Spent: 10m 
      Work Description: risdenk commented on pull request #191: KNOX-2122 - Code cleanup from static code analysis
URL: https://github.com/apache/knox/pull/191
 
 
   ## What changes were proposed in this pull request?
   
   * Diamond operator
   * Static method calls instead of on instances
   * Remove null check before instanceof
   * Use computeIfAbsent where possible
   * Remove simple nested if statements
   * Remove redundant cast
   
   ## How was this patch tested?
   
   `mvn -T.75C verify -U -Ppackage,release -Dshellcheck`
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 341649)
    Remaining Estimate: 0h
            Time Spent: 10m

> Code cleanup from static code analysis
> --------------------------------------
>
>                 Key: KNOX-2122
>                 URL: https://issues.apache.org/jira/browse/KNOX-2122
>             Project: Apache Knox
>          Issue Type: Improvement
>            Reporter: Kevin Risden
>            Assignee: Kevin Risden
>            Priority: Minor
>             Fix For: 1.4.0
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> * Diamond operator
> * Static method calls instead of on instances
> * Remove null check before instanceof
> * Use computeIfAbsent where possible
> * Remove simple nested if statements
> * Remove redundant cast



--
This message was sent by Atlassian Jira
(v8.3.4#803005)