You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by Venki Korukanti <ve...@gmail.com> on 2015/04/15 17:00:47 UTC
Review Request 33220: DRILL-2422: Before creating view make sure if a
table with given name already exists.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33220/
-----------------------------------------------------------
Review request for drill and Jinfeng Ni.
Repository: drill-git
Description
-------
See DRILL-2422 for details.
Diffs
-----
pom.xml 8c9f09e
Diff: https://reviews.apache.org/r/33220/diff/
Testing
-------
Added unittests for both CreateTable and CreateView
Thanks,
Venki Korukanti
Re: Review Request 33220: DRILL-2422: Before creating view make sure
if a table with given name already exists.
Posted by Jinfeng Ni <jn...@maprtech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33220/#review80223
-----------------------------------------------------------
Ship it!
Ship It!
- Jinfeng Ni
On April 15, 2015, 8:01 a.m., Venki Korukanti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33220/
> -----------------------------------------------------------
>
> (Updated April 15, 2015, 8:01 a.m.)
>
>
> Review request for drill and Jinfeng Ni.
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> See DRILL-2422 for details.
>
>
> Diffs
> -----
>
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/CreateTableHandler.java 300d65d
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/SqlHandlerUtil.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/ViewHandler.java 4347249
> exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/writer/TestParquetWriter.java 325f770
> exec/java-exec/src/test/java/org/apache/drill/exec/sql/TestViewSupport.java 578eace
>
> Diff: https://reviews.apache.org/r/33220/diff/
>
>
> Testing
> -------
>
> Added unittests for both CreateTable and CreateView
>
>
> Thanks,
>
> Venki Korukanti
>
>
Re: Review Request 33220: DRILL-2422: Before creating view make sure
if a table with given name already exists.
Posted by Venki Korukanti <ve...@gmail.com>.
> On April 15, 2015, 5:44 p.m., Jinfeng Ni wrote:
> > exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/CreateTableHandler.java, line 74
> > <https://reviews.apache.org/r/33220/diff/2/?file=930391#file930391line74>
> >
> > What is ValidationException? For "table not exists" type error, Calcite/Optiq will throw SqlValidatorException? Does it make sense to raise SqlValidatorException for "table with same name already exists" error?
Optiq/Calcite ultimately throws the ValidationException. I thought about using SqlValidationException, but it takes another exception cause. It doesn't have a constructor which just takes a error message.
- Venki
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33220/#review80220
-----------------------------------------------------------
On April 15, 2015, 3:01 p.m., Venki Korukanti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33220/
> -----------------------------------------------------------
>
> (Updated April 15, 2015, 3:01 p.m.)
>
>
> Review request for drill and Jinfeng Ni.
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> See DRILL-2422 for details.
>
>
> Diffs
> -----
>
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/CreateTableHandler.java 300d65d
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/SqlHandlerUtil.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/ViewHandler.java 4347249
> exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/writer/TestParquetWriter.java 325f770
> exec/java-exec/src/test/java/org/apache/drill/exec/sql/TestViewSupport.java 578eace
>
> Diff: https://reviews.apache.org/r/33220/diff/
>
>
> Testing
> -------
>
> Added unittests for both CreateTable and CreateView
>
>
> Thanks,
>
> Venki Korukanti
>
>
Re: Review Request 33220: DRILL-2422: Before creating view make sure
if a table with given name already exists.
Posted by Jinfeng Ni <jn...@maprtech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33220/#review80220
-----------------------------------------------------------
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/CreateTableHandler.java
<https://reviews.apache.org/r/33220/#comment130012>
What is ValidationException? For "table not exists" type error, Calcite/Optiq will throw SqlValidatorException? Does it make sense to raise SqlValidatorException for "table with same name already exists" error?
- Jinfeng Ni
On April 15, 2015, 8:01 a.m., Venki Korukanti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33220/
> -----------------------------------------------------------
>
> (Updated April 15, 2015, 8:01 a.m.)
>
>
> Review request for drill and Jinfeng Ni.
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> See DRILL-2422 for details.
>
>
> Diffs
> -----
>
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/CreateTableHandler.java 300d65d
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/SqlHandlerUtil.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/ViewHandler.java 4347249
> exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/writer/TestParquetWriter.java 325f770
> exec/java-exec/src/test/java/org/apache/drill/exec/sql/TestViewSupport.java 578eace
>
> Diff: https://reviews.apache.org/r/33220/diff/
>
>
> Testing
> -------
>
> Added unittests for both CreateTable and CreateView
>
>
> Thanks,
>
> Venki Korukanti
>
>
Re: Review Request 33220: DRILL-2422: Before creating view make sure
if a table with given name already exists.
Posted by Venki Korukanti <ve...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33220/
-----------------------------------------------------------
(Updated April 15, 2015, 3:01 p.m.)
Review request for drill and Jinfeng Ni.
Changes
-------
uploading actual patch.
Repository: drill-git
Description
-------
See DRILL-2422 for details.
Diffs (updated)
-----
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/CreateTableHandler.java 300d65d
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/SqlHandlerUtil.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/ViewHandler.java 4347249
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/writer/TestParquetWriter.java 325f770
exec/java-exec/src/test/java/org/apache/drill/exec/sql/TestViewSupport.java 578eace
Diff: https://reviews.apache.org/r/33220/diff/
Testing
-------
Added unittests for both CreateTable and CreateView
Thanks,
Venki Korukanti