You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by daserge <gi...@git.apache.org> on 2014/11/07 09:51:33 UTC
[GitHub] cordova-windows pull request: CB-7985 windows platform does not bu...
GitHub user daserge opened a pull request:
https://github.com/apache/cordova-windows/pull/51
CB-7985 windows platform does not build with Visual Studio 14 CTP tools
This fixes the bug - Microsoft.Common.props is loaded successfully thus defining all needed MSBuild variables.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-windows CB-7985
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-windows/pull/51.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #51
----
commit 84c9547ab58bb256a3054f29612daec3d41196bc
Author: daserge <da...@yandex.ru>
Date: 2014-11-07T08:17:36Z
CB-7985 windows platform does not build with Visual Studio 14 CTP tools
This fixes the bug - Microsoft.Common.props is loaded succesfully
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: CB-7985 Make windows platform suppor...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-windows/pull/51
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: CB-7985 Make windows platform suppor...
Posted by daserge <gi...@git.apache.org>.
Github user daserge commented on the pull request:
https://github.com/apache/cordova-windows/pull/51#issuecomment-62513685
Hello Jesse,
Added the name,
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: CB-7985 Make windows platform suppor...
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-windows/pull/51#issuecomment-62489706
Hi @daserge
Thanks for the commit!
Can you please add your real name to your github profile so I can resolve your github user account to a signed iCLA? I know I've seen and accepted pull requests from you before, but I would like the tracking to be as easy as possible to resolve. I would have to do more digging if this was a bigger pull request, and I know you have some waiting in other repos.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org