You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Yingchun Lai (Code Review)" <ge...@cloudera.org> on 2023/02/21 05:38:01 UTC
[kudu-CR] [fs] make CommitDeletedBlocks output parameter nullable
Yingchun Lai has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19520
Change subject: [fs] make CommitDeletedBlocks output parameter nullable
......................................................................
[fs] make CommitDeletedBlocks output parameter nullable
The output parameter of BlockDeletionTransaction::CommitDeletedBlocks
'deleted' is useless in some cases, it could be set to nullptr to
reduce minor filling of the container.
This patch also fixes some issues reported by clang-tidy.
Change-Id: Ia92c36011cf8fc63d58fad7da0e08554b9d5dad6
---
M src/kudu/fs/block_manager.h
M src/kudu/fs/file_block_manager.cc
M src/kudu/fs/log_block_manager-test.cc
M src/kudu/fs/log_block_manager.cc
M src/kudu/tablet/tablet_metadata.cc
5 files changed, 78 insertions(+), 77 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/20/19520/1
--
To view, visit http://gerrit.cloudera.org:8080/19520
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia92c36011cf8fc63d58fad7da0e08554b9d5dad6
Gerrit-Change-Number: 19520
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <la...@apache.org>
[kudu-CR] [fs] make CommitDeletedBlocks output parameter nullable
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Alexey Serbin, Yuqi Du, Ashwani Raina, Kudu Jenkins, KeDeng, Wang Xixu,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19520
to look at the new patch set (#8).
Change subject: [fs] make CommitDeletedBlocks output parameter nullable
......................................................................
[fs] make CommitDeletedBlocks output parameter nullable
The output parameter of BlockDeletionTransaction::CommitDeletedBlocks
'deleted' is useless in some cases, it could be set to nullptr to
reduce minor filling of the container.
This patch also fixes some issues reported by clang-tidy.
Change-Id: Ia92c36011cf8fc63d58fad7da0e08554b9d5dad6
---
M src/kudu/fs/block_manager-test.cc
M src/kudu/fs/block_manager.h
M src/kudu/fs/file_block_manager.cc
M src/kudu/fs/log_block_manager-test.cc
M src/kudu/fs/log_block_manager.cc
M src/kudu/fs/log_block_manager.h
M src/kudu/tablet/tablet_metadata.cc
7 files changed, 89 insertions(+), 83 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/20/19520/8
--
To view, visit http://gerrit.cloudera.org:8080/19520
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia92c36011cf8fc63d58fad7da0e08554b9d5dad6
Gerrit-Change-Number: 19520
Gerrit-PatchSet: 8
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
[kudu-CR] [fs] make CommitDeletedBlocks output parameter nullable
Posted by "Ashwani Raina (Code Review)" <ge...@cloudera.org>.
Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/19520 )
Change subject: [fs] make CommitDeletedBlocks output parameter nullable
......................................................................
Patch Set 9: Code-Review+1
(1 comment)
LGTM, one question though for my understanding.
http://gerrit.cloudera.org:8080/#/c/19520/9/src/kudu/fs/file_block_manager.cc
File src/kudu/fs/file_block_manager.cc:
http://gerrit.cloudera.org:8080/#/c/19520/9/src/kudu/fs/file_block_manager.cc@236
PS9, Line 236: FileWritableBlock final
I am little unclear on this. Are you making this class "underivable from"? And why?
--
To view, visit http://gerrit.cloudera.org:8080/19520
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia92c36011cf8fc63d58fad7da0e08554b9d5dad6
Gerrit-Change-Number: 19520
Gerrit-PatchSet: 9
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Mon, 27 Feb 2023 15:49:58 +0000
Gerrit-HasComments: Yes
[kudu-CR] [fs] make CommitDeletedBlocks output parameter nullable
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19520
to look at the new patch set (#3).
Change subject: [fs] make CommitDeletedBlocks output parameter nullable
......................................................................
[fs] make CommitDeletedBlocks output parameter nullable
The output parameter of BlockDeletionTransaction::CommitDeletedBlocks
'deleted' is useless in some cases, it could be set to nullptr to
reduce minor filling of the container.
This patch also fixes some issues reported by clang-tidy.
Change-Id: Ia92c36011cf8fc63d58fad7da0e08554b9d5dad6
---
M src/kudu/fs/block_manager.h
M src/kudu/fs/file_block_manager.cc
M src/kudu/fs/log_block_manager-test.cc
M src/kudu/fs/log_block_manager.cc
M src/kudu/tablet/tablet_metadata.cc
5 files changed, 79 insertions(+), 78 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/20/19520/3
--
To view, visit http://gerrit.cloudera.org:8080/19520
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia92c36011cf8fc63d58fad7da0e08554b9d5dad6
Gerrit-Change-Number: 19520
Gerrit-PatchSet: 3
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] [fs] make CommitDeletedBlocks output parameter nullable
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19520 )
Change subject: [fs] make CommitDeletedBlocks output parameter nullable
......................................................................
[fs] make CommitDeletedBlocks output parameter nullable
The output parameter of BlockDeletionTransaction::CommitDeletedBlocks
'deleted' is useless in some cases, it could be set to nullptr to
reduce minor filling of the container.
This patch also fixes some issues reported by clang-tidy.
Change-Id: Ia92c36011cf8fc63d58fad7da0e08554b9d5dad6
Reviewed-on: http://gerrit.cloudera.org:8080/19520
Reviewed-by: Yifan Zhang <ch...@163.com>
Reviewed-by: Yuqi Du <sh...@gmail.com>
Reviewed-by: Ashwani Raina <ar...@cloudera.com>
Tested-by: Yingchun Lai <la...@apache.org>
---
M src/kudu/fs/block_manager-test.cc
M src/kudu/fs/block_manager.h
M src/kudu/fs/file_block_manager.cc
M src/kudu/fs/log_block_manager-test.cc
M src/kudu/fs/log_block_manager.cc
M src/kudu/fs/log_block_manager.h
M src/kudu/tablet/tablet_metadata.cc
7 files changed, 90 insertions(+), 83 deletions(-)
Approvals:
Yifan Zhang: Looks good to me, approved
Yuqi Du: Looks good to me, but someone else must approve
Ashwani Raina: Looks good to me, but someone else must approve
Yingchun Lai: Verified
--
To view, visit http://gerrit.cloudera.org:8080/19520
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia92c36011cf8fc63d58fad7da0e08554b9d5dad6
Gerrit-Change-Number: 19520
Gerrit-PatchSet: 10
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
[kudu-CR] [fs] make CommitDeletedBlocks output parameter nullable
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Alexey Serbin, Yuqi Du, Ashwani Raina, Kudu Jenkins, KeDeng, Wang Xixu,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19520
to look at the new patch set (#6).
Change subject: [fs] make CommitDeletedBlocks output parameter nullable
......................................................................
[fs] make CommitDeletedBlocks output parameter nullable
The output parameter of BlockDeletionTransaction::CommitDeletedBlocks
'deleted' is useless in some cases, it could be set to nullptr to
reduce minor filling of the container.
This patch also fixes some issues reported by clang-tidy.
Change-Id: Ia92c36011cf8fc63d58fad7da0e08554b9d5dad6
---
M src/kudu/fs/block_manager.h
M src/kudu/fs/file_block_manager.cc
M src/kudu/fs/log_block_manager-test.cc
M src/kudu/fs/log_block_manager.cc
M src/kudu/fs/log_block_manager.h
M src/kudu/tablet/tablet_metadata.cc
6 files changed, 86 insertions(+), 80 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/20/19520/6
--
To view, visit http://gerrit.cloudera.org:8080/19520
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia92c36011cf8fc63d58fad7da0e08554b9d5dad6
Gerrit-Change-Number: 19520
Gerrit-PatchSet: 6
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
[kudu-CR] [fs] make CommitDeletedBlocks output parameter nullable
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Alexey Serbin, Yuqi Du, Ashwani Raina, Kudu Jenkins, KeDeng, Wang Xixu,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19520
to look at the new patch set (#4).
Change subject: [fs] make CommitDeletedBlocks output parameter nullable
......................................................................
[fs] make CommitDeletedBlocks output parameter nullable
The output parameter of BlockDeletionTransaction::CommitDeletedBlocks
'deleted' is useless in some cases, it could be set to nullptr to
reduce minor filling of the container.
This patch also fixes some issues reported by clang-tidy.
Change-Id: Ia92c36011cf8fc63d58fad7da0e08554b9d5dad6
---
M src/kudu/fs/block_manager.h
M src/kudu/fs/file_block_manager.cc
M src/kudu/fs/log_block_manager-test.cc
M src/kudu/fs/log_block_manager.cc
M src/kudu/tablet/tablet_metadata.cc
5 files changed, 79 insertions(+), 78 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/20/19520/4
--
To view, visit http://gerrit.cloudera.org:8080/19520
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia92c36011cf8fc63d58fad7da0e08554b9d5dad6
Gerrit-Change-Number: 19520
Gerrit-PatchSet: 4
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
[kudu-CR] [fs] make CommitDeletedBlocks output parameter nullable
Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/19520 )
Change subject: [fs] make CommitDeletedBlocks output parameter nullable
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
LGTM.
http://gerrit.cloudera.org:8080/#/c/19520/4/src/kudu/fs/file_block_manager.cc
File src/kudu/fs/file_block_manager.cc:
http://gerrit.cloudera.org:8080/#/c/19520/4/src/kudu/fs/file_block_manager.cc@650
PS4, Line 650: Substitute("only deleted $0 blocks, first failure",
It seems be better if adding total deleted block count we expected in the log. such as:
Substitute("expected to delete $0 blocks, only deleted $1 blocks, first failure",
BTW, Adding another variable such as 'int32_t deleted_count' can be considered.
--
To view, visit http://gerrit.cloudera.org:8080/19520
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia92c36011cf8fc63d58fad7da0e08554b9d5dad6
Gerrit-Change-Number: 19520
Gerrit-PatchSet: 4
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Fri, 24 Feb 2023 03:18:50 +0000
Gerrit-HasComments: Yes
[kudu-CR] [fs] make CommitDeletedBlocks output parameter nullable
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Alexey Serbin, Yuqi Du, Ashwani Raina, Kudu Jenkins, KeDeng, Wang Xixu,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19520
to look at the new patch set (#5).
Change subject: [fs] make CommitDeletedBlocks output parameter nullable
......................................................................
[fs] make CommitDeletedBlocks output parameter nullable
The output parameter of BlockDeletionTransaction::CommitDeletedBlocks
'deleted' is useless in some cases, it could be set to nullptr to
reduce minor filling of the container.
This patch also fixes some issues reported by clang-tidy.
Change-Id: Ia92c36011cf8fc63d58fad7da0e08554b9d5dad6
---
M src/kudu/fs/block_manager.h
M src/kudu/fs/file_block_manager.cc
M src/kudu/fs/log_block_manager-test.cc
M src/kudu/fs/log_block_manager.cc
M src/kudu/tablet/tablet_metadata.cc
5 files changed, 84 insertions(+), 78 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/20/19520/5
--
To view, visit http://gerrit.cloudera.org:8080/19520
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia92c36011cf8fc63d58fad7da0e08554b9d5dad6
Gerrit-Change-Number: 19520
Gerrit-PatchSet: 5
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
[kudu-CR] [fs] make CommitDeletedBlocks output parameter nullable
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19520 )
Change subject: [fs] make CommitDeletedBlocks output parameter nullable
......................................................................
Patch Set 9:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/19520/9/src/kudu/fs/file_block_manager.cc
File src/kudu/fs/file_block_manager.cc:
http://gerrit.cloudera.org:8080/#/c/19520/9/src/kudu/fs/file_block_manager.cc@236
PS9, Line 236: FileWritableBlock final
> I am little unclear on this. Are you making this class "underivable from"?
It's a simple way to mute complains from Tidy Bot like https://gerrit.cloudera.org/c/19520/1/src/kudu/fs/file_block_manager.cc#310.
Otherwise, we have to write more confused code (like calling `FileWritableBlock::Abort()`, `FileWritableBlock::id()` in ~FileWritableBlock())
--
To view, visit http://gerrit.cloudera.org:8080/19520
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia92c36011cf8fc63d58fad7da0e08554b9d5dad6
Gerrit-Change-Number: 19520
Gerrit-PatchSet: 9
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Mon, 27 Feb 2023 16:13:14 +0000
Gerrit-HasComments: Yes
[kudu-CR] [fs] make CommitDeletedBlocks output parameter nullable
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19520 )
Change subject: [fs] make CommitDeletedBlocks output parameter nullable
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/19520
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia92c36011cf8fc63d58fad7da0e08554b9d5dad6
Gerrit-Change-Number: 19520
Gerrit-PatchSet: 3
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Tue, 21 Feb 2023 14:36:38 +0000
Gerrit-HasComments: No
[kudu-CR] [fs] make CommitDeletedBlocks output parameter nullable
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19520 )
Change subject: [fs] make CommitDeletedBlocks output parameter nullable
......................................................................
Patch Set 6:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/19520/5/src/kudu/fs/log_block_manager.cc
File src/kudu/fs/log_block_manager.cc:
http://gerrit.cloudera.org:8080/#/c/19520/5/src/kudu/fs/log_block_manager.cc@2659
PS5, Line 2659: Status LogBlockManager::RemoveLogBlocks(const vector<BlockId>& block_ids,
> warning: the parameter 'block_ids' is copied for each invocation but only u
Done
--
To view, visit http://gerrit.cloudera.org:8080/19520
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia92c36011cf8fc63d58fad7da0e08554b9d5dad6
Gerrit-Change-Number: 19520
Gerrit-PatchSet: 6
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Fri, 24 Feb 2023 10:08:34 +0000
Gerrit-HasComments: Yes
[kudu-CR] [fs] make CommitDeletedBlocks output parameter nullable
Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19520 )
Change subject: [fs] make CommitDeletedBlocks output parameter nullable
......................................................................
Patch Set 9: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/19520
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia92c36011cf8fc63d58fad7da0e08554b9d5dad6
Gerrit-Change-Number: 19520
Gerrit-PatchSet: 9
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Mon, 27 Feb 2023 09:51:08 +0000
Gerrit-HasComments: No
[kudu-CR] [fs] make CommitDeletedBlocks output parameter nullable
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19520 )
Change subject: [fs] make CommitDeletedBlocks output parameter nullable
......................................................................
Patch Set 9: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/19520
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia92c36011cf8fc63d58fad7da0e08554b9d5dad6
Gerrit-Change-Number: 19520
Gerrit-PatchSet: 9
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Mon, 27 Feb 2023 16:13:44 +0000
Gerrit-HasComments: No
[kudu-CR] [fs] make CommitDeletedBlocks output parameter nullable
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19520 )
Change subject: [fs] make CommitDeletedBlocks output parameter nullable
......................................................................
Patch Set 3:
> Patch Set 1:
>
> (4 comments)
fixed
--
To view, visit http://gerrit.cloudera.org:8080/19520
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia92c36011cf8fc63d58fad7da0e08554b9d5dad6
Gerrit-Change-Number: 19520
Gerrit-PatchSet: 3
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Tue, 21 Feb 2023 06:20:52 +0000
Gerrit-HasComments: No
[kudu-CR] [fs] make CommitDeletedBlocks output parameter nullable
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has removed a vote on this change.
Change subject: [fs] make CommitDeletedBlocks output parameter nullable
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/19520
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ia92c36011cf8fc63d58fad7da0e08554b9d5dad6
Gerrit-Change-Number: 19520
Gerrit-PatchSet: 9
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
[kudu-CR] [fs] make CommitDeletedBlocks output parameter nullable
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has removed a vote on this change.
Change subject: [fs] make CommitDeletedBlocks output parameter nullable
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/19520
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ia92c36011cf8fc63d58fad7da0e08554b9d5dad6
Gerrit-Change-Number: 19520
Gerrit-PatchSet: 3
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
[kudu-CR] [fs] make CommitDeletedBlocks output parameter nullable
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Alexey Serbin, Yuqi Du, Ashwani Raina, Kudu Jenkins, KeDeng, Wang Xixu,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19520
to look at the new patch set (#7).
Change subject: [fs] make CommitDeletedBlocks output parameter nullable
......................................................................
[fs] make CommitDeletedBlocks output parameter nullable
The output parameter of BlockDeletionTransaction::CommitDeletedBlocks
'deleted' is useless in some cases, it could be set to nullptr to
reduce minor filling of the container.
This patch also fixes some issues reported by clang-tidy.
Change-Id: Ia92c36011cf8fc63d58fad7da0e08554b9d5dad6
---
M src/kudu/fs/block_manager-test.cc
M src/kudu/fs/block_manager.h
M src/kudu/fs/file_block_manager.cc
M src/kudu/fs/log_block_manager-test.cc
M src/kudu/fs/log_block_manager.cc
M src/kudu/fs/log_block_manager.h
M src/kudu/tablet/tablet_metadata.cc
7 files changed, 87 insertions(+), 81 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/20/19520/7
--
To view, visit http://gerrit.cloudera.org:8080/19520
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia92c36011cf8fc63d58fad7da0e08554b9d5dad6
Gerrit-Change-Number: 19520
Gerrit-PatchSet: 7
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
[kudu-CR] [fs] make CommitDeletedBlocks output parameter nullable
Posted by "Wang Xixu (Code Review)" <ge...@cloudera.org>.
Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19520 )
Change subject: [fs] make CommitDeletedBlocks output parameter nullable
......................................................................
Patch Set 3: Code-Review+1
LGTM
--
To view, visit http://gerrit.cloudera.org:8080/19520
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia92c36011cf8fc63d58fad7da0e08554b9d5dad6
Gerrit-Change-Number: 19520
Gerrit-PatchSet: 3
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Wed, 22 Feb 2023 04:06:42 +0000
Gerrit-HasComments: No
[kudu-CR] [fs] make CommitDeletedBlocks output parameter nullable
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19520
to look at the new patch set (#2).
Change subject: [fs] make CommitDeletedBlocks output parameter nullable
......................................................................
[fs] make CommitDeletedBlocks output parameter nullable
The output parameter of BlockDeletionTransaction::CommitDeletedBlocks
'deleted' is useless in some cases, it could be set to nullptr to
reduce minor filling of the container.
This patch also fixes some issues reported by clang-tidy.
Change-Id: Ia92c36011cf8fc63d58fad7da0e08554b9d5dad6
---
M src/kudu/fs/block_manager.h
M src/kudu/fs/file_block_manager.cc
M src/kudu/fs/log_block_manager-test.cc
M src/kudu/fs/log_block_manager.cc
M src/kudu/tablet/tablet_metadata.cc
5 files changed, 79 insertions(+), 78 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/20/19520/2
--
To view, visit http://gerrit.cloudera.org:8080/19520
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia92c36011cf8fc63d58fad7da0e08554b9d5dad6
Gerrit-Change-Number: 19520
Gerrit-PatchSet: 2
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] [fs] make CommitDeletedBlocks output parameter nullable
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19520 )
Change subject: [fs] make CommitDeletedBlocks output parameter nullable
......................................................................
Patch Set 5:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/19520/4/src/kudu/fs/file_block_manager.cc
File src/kudu/fs/file_block_manager.cc:
http://gerrit.cloudera.org:8080/#/c/19520/4/src/kudu/fs/file_block_manager.cc@650
PS4, Line 650: if (!first_failure.ok()) {
> It seems be better if adding total deleted block count we expected in the l
Good suggestion, thanks!
--
To view, visit http://gerrit.cloudera.org:8080/19520
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia92c36011cf8fc63d58fad7da0e08554b9d5dad6
Gerrit-Change-Number: 19520
Gerrit-PatchSet: 5
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Fri, 24 Feb 2023 09:43:40 +0000
Gerrit-HasComments: Yes
[kudu-CR] [fs] make CommitDeletedBlocks output parameter nullable
Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/19520 )
Change subject: [fs] make CommitDeletedBlocks output parameter nullable
......................................................................
Patch Set 9: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/19520
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia92c36011cf8fc63d58fad7da0e08554b9d5dad6
Gerrit-Change-Number: 19520
Gerrit-PatchSet: 9
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Mon, 27 Feb 2023 10:38:39 +0000
Gerrit-HasComments: No
[kudu-CR] [fs] make CommitDeletedBlocks output parameter nullable
Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/19520 )
Change subject: [fs] make CommitDeletedBlocks output parameter nullable
......................................................................
Patch Set 6: Code-Review+1
LGTM.
--
To view, visit http://gerrit.cloudera.org:8080/19520
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia92c36011cf8fc63d58fad7da0e08554b9d5dad6
Gerrit-Change-Number: 19520
Gerrit-PatchSet: 6
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Fri, 24 Feb 2023 10:41:37 +0000
Gerrit-HasComments: No
[kudu-CR] [fs] make CommitDeletedBlocks output parameter nullable
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Alexey Serbin, Yuqi Du, Ashwani Raina, Kudu Jenkins, KeDeng, Wang Xixu,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19520
to look at the new patch set (#9).
Change subject: [fs] make CommitDeletedBlocks output parameter nullable
......................................................................
[fs] make CommitDeletedBlocks output parameter nullable
The output parameter of BlockDeletionTransaction::CommitDeletedBlocks
'deleted' is useless in some cases, it could be set to nullptr to
reduce minor filling of the container.
This patch also fixes some issues reported by clang-tidy.
Change-Id: Ia92c36011cf8fc63d58fad7da0e08554b9d5dad6
---
M src/kudu/fs/block_manager-test.cc
M src/kudu/fs/block_manager.h
M src/kudu/fs/file_block_manager.cc
M src/kudu/fs/log_block_manager-test.cc
M src/kudu/fs/log_block_manager.cc
M src/kudu/fs/log_block_manager.h
M src/kudu/tablet/tablet_metadata.cc
7 files changed, 90 insertions(+), 83 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/20/19520/9
--
To view, visit http://gerrit.cloudera.org:8080/19520
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia92c36011cf8fc63d58fad7da0e08554b9d5dad6
Gerrit-Change-Number: 19520
Gerrit-PatchSet: 9
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
[kudu-CR] [fs] make CommitDeletedBlocks output parameter nullable
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19520 )
Change subject: [fs] make CommitDeletedBlocks output parameter nullable
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/19520/3/src/kudu/fs/file_block_manager.cc
File src/kudu/fs/file_block_manager.cc:
http://gerrit.cloudera.org:8080/#/c/19520/3/src/kudu/fs/file_block_manager.cc@651
PS3, Line 651: partial
> nit: For cases when there is no block deletion - we could simply say "parti
Done
--
To view, visit http://gerrit.cloudera.org:8080/19520
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia92c36011cf8fc63d58fad7da0e08554b9d5dad6
Gerrit-Change-Number: 19520
Gerrit-PatchSet: 4
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Thu, 23 Feb 2023 16:18:37 +0000
Gerrit-HasComments: Yes
[kudu-CR] [fs] make CommitDeletedBlocks output parameter nullable
Posted by "Ashwani Raina (Code Review)" <ge...@cloudera.org>.
Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/19520 )
Change subject: [fs] make CommitDeletedBlocks output parameter nullable
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/19520/3/src/kudu/fs/file_block_manager.cc
File src/kudu/fs/file_block_manager.cc:
http://gerrit.cloudera.org:8080/#/c/19520/3/src/kudu/fs/file_block_manager.cc@651
PS3, Line 651: partial
nit: For cases when there is no block deletion - we could simply say "partial or no"
--
To view, visit http://gerrit.cloudera.org:8080/19520
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia92c36011cf8fc63d58fad7da0e08554b9d5dad6
Gerrit-Change-Number: 19520
Gerrit-PatchSet: 3
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Wed, 22 Feb 2023 10:22:20 +0000
Gerrit-HasComments: Yes