You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "gerlowskija (via GitHub)" <gi...@apache.org> on 2023/10/20 20:29:45 UTC
[PR] SOLR-17048: Update solrj dep on 'api' module [solr]
gerlowskija opened a new pull request, #2029:
URL: https://github.com/apache/solr/pull/2029
https://issues.apache.org/jira/browse/SOLR-17048
# Description
Solr 9.4 introduced a new 'api' module consumed by various other parts of Solr. The solrj module declared an 'implementation' dependency on this new module which worked for Solr's own build, but isn't actually sufficient to have the dependency picked up transitively in client apps, leading to a variety of ClassDefNotFound's.
# Solution
This commit updates SolrJ's declaration of its 'api' dependency to list it as an "api" type dependency. This should prevent any client-side ClassDefNotFound problems related to these jar contents.
(Users of 9.4 can workaround this problem by adding an explicit dependency on solr-api in their apps, as in:
```
<dependency>
<groupId>org.apache.solr</groupId>
<artifactId>solr-api</artifactId>
<version>9.4.0</version>
</dependency>
```
)
# Tests
Existing tests continue to pass.
# Checklist
Please review the following and check all that apply:
- [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [x] I have created a Jira issue and added the issue ID to my pull request title.
- [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [x] I have developed this patch against the `main` branch.
- [ ] I have run `./gradlew check`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-17048: Update solrj dep on 'api' module [solr]
Posted by "gerlowskija (via GitHub)" <gi...@apache.org>.
gerlowskija commented on PR #2029:
URL: https://github.com/apache/solr/pull/2029#issuecomment-1773356239
(FYI @risdenk - thanks for alerting me on SOLR-17048)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-17048: Update solrj dep on 'api' module [solr]
Posted by "gerlowskija (via GitHub)" <gi...@apache.org>.
gerlowskija merged PR #2029:
URL: https://github.com/apache/solr/pull/2029
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org