You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "lancelly (via GitHub)" <gi...@apache.org> on 2023/09/26 08:59:17 UTC
[GitHub] [iotdb] lancelly opened a new pull request, #11219: Finish canAddTsBlock of SharedTsBlockQueue to ensure that blocked Driver could be correctly finished
lancelly opened a new pull request, #11219:
URL: https://github.com/apache/iotdb/pull/11219
The blocked future of LocalSinkChannel is done when its downstream LocalSourceHandle asks it for data. In query with limit clause, it is possible that a Driver is blocked because its ISink is blocked. When the query finishes, we should ensure that the blocked Drivers can be waken and then be finished correctly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] codecov-commenter commented on pull request #11219: [IoTDB-6172] Finish canAddTsBlock of SharedTsBlockQueue to ensure that blocked Driver could be correctly finished
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #11219:
URL: https://github.com/apache/iotdb/pull/11219#issuecomment-1735208239
## [Codecov](https://app.codecov.io/gh/apache/iotdb/pull/11219?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#11219](https://app.codecov.io/gh/apache/iotdb/pull/11219?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (9c0da95) into [master](https://app.codecov.io/gh/apache/iotdb/commit/3250550f9a6176859bde1c4dc34020825efbe577?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (3250550) will **increase** coverage by `0.86%`.
> Report is 4 commits behind head on master.
> The diff coverage is `16.66%`.
```diff
@@ Coverage Diff @@
## master #11219 +/- ##
============================================
+ Coverage 47.58% 48.45% +0.86%
- Complexity 23671 24028 +357
============================================
Files 2789 2789
Lines 170528 170545 +17
Branches 20318 20321 +3
============================================
+ Hits 81152 82638 +1486
+ Misses 89376 87907 -1469
```
| [Files](https://app.codecov.io/gh/apache/iotdb/pull/11219?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...yengine/execution/exchange/SharedTsBlockQueue.java](https://app.codecov.io/gh/apache/iotdb/pull/11219?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvcXVlcnllbmdpbmUvZXhlY3V0aW9uL2V4Y2hhbmdlL1NoYXJlZFRzQmxvY2tRdWV1ZS5qYXZh) | `68.91% <16.66%> (-2.21%)` | :arrow_down: |
... and [31 files with indirect coverage changes](https://app.codecov.io/gh/apache/iotdb/pull/11219/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] sonarcloud[bot] commented on pull request #11219: Finish canAddTsBlock of SharedTsBlockQueue to ensure that blocked Driver could be correctly finished
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #11219:
URL: https://github.com/apache/iotdb/pull/11219#issuecomment-1735138295
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=11219)
[](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=11219&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=11219&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=11219&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=11219&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=11219&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=11219&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_iotdb&pullRequest=11219&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_iotdb&pullRequest=11219&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_iotdb&pullRequest=11219&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=11219&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=11219&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=11219&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=11219&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=11219&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=11219&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=11219&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] JackieTien97 merged pull request #11219: [IoTDB-6172] Finish canAddTsBlock of SharedTsBlockQueue to ensure that blocked Driver could be correctly finished
Posted by "JackieTien97 (via GitHub)" <gi...@apache.org>.
JackieTien97 merged PR #11219:
URL: https://github.com/apache/iotdb/pull/11219
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org