You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/10/14 12:16:17 UTC
[GitHub] [ozone] smitajoshi12 opened a new pull request, #3837: HDDS-7248 Recon Expand the container status page to show all unhealth…
smitajoshi12 opened a new pull request, #3837:
URL: https://github.com/apache/ozone/pull/3837
## What changes were proposed in this pull request?
To show Under Replicated ,Over Replicated,Mis Replicated and All Replicas UnHealthy from Overview and Left Side Panel.
(Please fill in changes proposed in this fix)
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-7248
## How was this patch tested?
Manually
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] smitajoshi12 commented on a diff in pull request #3837: HDDS-7248. Recon: Expand the container status page to show all unhealthy container states
Posted by GitBox <gi...@apache.org>.
smitajoshi12 commented on code in PR #3837:
URL: https://github.com/apache/ozone/pull/3837#discussion_r998162798
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/missingContainers/missingContainers.tsx:
##########
@@ -213,6 +565,13 @@ export class MissingContainers extends React.Component<Record<string, object>, I
console.log(current, pageSize);
};
+ onTabChange = (activeKey: string) => {
+ // Fetch inactive pipelines if tab is switched to "Inactive"
+ if (activeKey === '2') {
+ // Fetch inactive pipelines in the future
+ }
+ };
+
Review Comment:
Removed from Code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] smitajoshi12 commented on a diff in pull request #3837: HDDS-7248. Recon: Expand the container status page to show all unhealthy container states
Posted by GitBox <gi...@apache.org>.
smitajoshi12 commented on code in PR #3837:
URL: https://github.com/apache/ozone/pull/3837#discussion_r1000229250
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/missingContainers/missingContainers.tsx:
##########
@@ -192,16 +301,36 @@ export class MissingContainers extends React.Component<Record<string, object>, I
this.setState({
loading: true
});
- axios.get('/api/v1/containers/missing').then(response => {
- const missingContainersResponse: IMissingContainersResponse = response.data;
- const totalCount = missingContainersResponse.totalCount;
- const missingContainers: IMissingContainerResponse[] = missingContainersResponse.containers;
+
+ axios.all([
+ axios.get('/api/v1/containers/unhealthy/MISSING'),
Review Comment:
http://localhost:9888/api/v1/containers/unhealthy/MISSING
{"missingCount":0,"underReplicatedCount":1,"overReplicatedCount":0,"misReplicatedCount":0,"containers":[]}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] smitajoshi12 commented on a diff in pull request #3837: HDDS-7248. Recon: Expand the container status page to show all unhealthy container states
Posted by GitBox <gi...@apache.org>.
smitajoshi12 commented on code in PR #3837:
URL: https://github.com/apache/ozone/pull/3837#discussion_r998111172
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/missingContainers/missingContainers.tsx:
##########
@@ -35,18 +36,48 @@ interface IMissingContainerResponse {
pipelineID: string;
}
+interface IAllContainerResponse {
+ containerID: number;
+ containerState: string;
+ unhealthySince: string;
+ expectedReplicaCount: number;
+ actualReplicaCount: number;
+ replicaDeltaCount: number;
+ reason: string;
+ keys: number;
+ pipelineID: string;
+ replicas: IContainerReplicaAll[];
+}
+
export interface IContainerReplica {
containerId: number;
datanodeHost: string;
firstReportTimestamp: number;
lastReportTimestamp: number;
}
+export interface IContainerReplicaAll {
+ containerId: number;
+ datanodeUuid: string;
+ datanodeHost: string;
+ firstSeenTime: number;
+ lastSeenTime: number;
+ lastBcsId: number;
+}
+
export interface IMissingContainersResponse {
totalCount: number;
containers: IMissingContainerResponse[];
}
+interface IAllReplicatedContainersResponse {
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] smengcl commented on a diff in pull request #3837: HDDS-7248. Recon: Expand the container status page to show all unhealthy container states
Posted by GitBox <gi...@apache.org>.
smengcl commented on code in PR #3837:
URL: https://github.com/apache/ozone/pull/3837#discussion_r999697938
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/missingContainers/missingContainers.tsx:
##########
@@ -192,16 +301,36 @@ export class MissingContainers extends React.Component<Record<string, object>, I
this.setState({
loading: true
});
- axios.get('/api/v1/containers/missing').then(response => {
- const missingContainersResponse: IMissingContainersResponse = response.data;
- const totalCount = missingContainersResponse.totalCount;
- const missingContainers: IMissingContainerResponse[] = missingContainersResponse.containers;
+
+ axios.all([
+ axios.get('/api/v1/containers/unhealthy/MISSING'),
+ axios.get('/api/v1/containers/unhealthy/UNDER_REPLICATED'),
+ axios.get('/api/v1/containers/unhealthy/OVER_REPLICATED'),
+ axios.get('/api/v1/containers/unhealthy/MIS_REPLICATED')
Review Comment:
Let's try to get all unhealthy container information at once with:
```suggestion
axios.all([
axios.get('/api/v1/containers/unhealthy')
```
then change the logic accordingly. Hopefully this will be a small change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] smengcl commented on a diff in pull request #3837: HDDS-7248. Recon: Expand the container status page to show all unhealthy container states
Posted by GitBox <gi...@apache.org>.
smengcl commented on code in PR #3837:
URL: https://github.com/apache/ozone/pull/3837#discussion_r998549946
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/api/routes.json:
##########
@@ -23,5 +23,8 @@
"/namespace/du?path=/clunky&files=true": "/clunky",
"/namespace/summary?path=*": "/metadata",
"/namespace/quota?path=*": "/quota",
- "/task/status": "/taskStatus"
+ "/task/status": "/taskStatus",
+ "/containers/unhealthy/UNDER_REPLICATED": "/UNDER_REPLICATED",
+ "/containers/unhealthy/OVER_REPLICATED": "/OVER_REPLICATED",
+ "/containers/unhealthy/MIS_REPLICATED": "/MIS_REPLICATED"
Review Comment:
```suggestion
"/containers/unhealthy/UNDER_REPLICATED": "/containerUnhealthyUnderReplicated",
"/containers/unhealthy/OVER_REPLICATED": "/containerUnhealthyOverReplicated",
"/containers/unhealthy/MIS_REPLICATED": "/containerUnhealthyMisReplicated"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] dombizita commented on a diff in pull request #3837: HDDS-7248. Recon: Expand the container status page to show all unhealthy container states
Posted by GitBox <gi...@apache.org>.
dombizita commented on code in PR #3837:
URL: https://github.com/apache/ozone/pull/3837#discussion_r996774041
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/api/db.json:
##########
@@ -1260,5 +1260,334 @@
"lastUpdatedTimestamp": 1663421094507,
"lastUpdatedSeqNumber": 0
}
- ]
+ ],
+ "UNDER_REPLICATED": {
+ "missingCount": 0,
+ "underReplicatedCount": 1,
+ "overReplicatedCount": 0,
+ "misReplicatedCount": 0,
+ "containers": [
+ {
+ "containerID": 2,
+ "containerState": "UNDER_REPLICATED",
+ "unhealthySince": 1665590446222,
+ "expectedReplicaCount": 3,
+ "actualReplicaCount": 2,
+ "replicaDeltaCount": 1,
+ "reason": null,
+ "keys": 1,
+ "pipelineID": "a10ffab6-8ed5-414a-aaf5-79890ff3e8a1",
+ "replicas": [
+ {
+ "containerId": 2,
+ "datanodeUuid": "15526f1b-76f2-4d8f-876c-c343c94ea476",
+ "datanodeHost": "ozone_datanode_2.ozone_UnderReplicated2",
+ "firstSeenTime": 1665588176660,
+ "lastSeenTime": 1665590397315,
+ "lastBcsId": 2
+ },
+ {
+ "containerId": 2,
+ "datanodeUuid": "f55476ab-4687-464d-a100-1c65de4366e3",
+ "datanodeHost": "ozone_datanode_3.ozone_underreplicated2",
+ "firstSeenTime": 1665588176616,
+ "lastSeenTime": 1665590392293,
+ "lastBcsId": 2
+ },
+ {
+ "containerId": 2,
+ "datanodeUuid": "7a457bcb-d63e-49cc-b3ff-8b22bf48d130",
+ "datanodeHost": "ozone_datanode_1.ozone_underreplicated2",
+ "firstSeenTime": 1665588176660,
+ "lastSeenTime": 1665590272289,
+ "lastBcsId": 0
+ }
+ ]
+ },
+ {
+ "containerID": 3,
+ "containerState": "UNDER_REPLICATED",
+ "unhealthySince": 1665590446222,
+ "expectedReplicaCount": 4,
+ "actualReplicaCount": 2,
+ "replicaDeltaCount": 2,
+ "reason": null,
+ "keys": 1,
+ "pipelineID": "a10ffab6-8ed5-414a-aaf5-79890ff3e8a1",
+ "replicas": [
+ {
+ "containerId": 3,
+ "datanodeUuid": "15526f1b-76f2-4d8f-876c-c343c94ea476",
+ "datanodeHost": "ozone_datanode_2.ozone_underreplicated3",
+ "firstSeenTime": 1665588176660,
+ "lastSeenTime": 1665590397315,
+ "lastBcsId": 2
+ },
+ {
+ "containerId": 3,
+ "datanodeUuid": "f55476ab-4687-464d-a100-1c65de4366e3",
+ "datanodeHost": "ozone_datanode_3.ozone_underreplicated3",
+ "firstSeenTime": 1665588176616,
+ "lastSeenTime": 1665590392293,
+ "lastBcsId": 2
+ },
+ {
+ "containerId": 3,
+ "datanodeUuid": "7a457bcb-d63e-49cc-b3ff-8b22bf48d130",
+ "datanodeHost": "ozone_datanode_1.ozone_underreplicated3",
+ "firstSeenTime": 1665588176660,
+ "lastSeenTime": 1665590272289,
+ "lastBcsId": 0
+ }
+ ]
+ }
+ ]
+ },
+ "Over_REPLICATED": {
Review Comment:
I think `db.json` won't work with this misspell.
```suggestion
"OVER_REPLICATED": {
```
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/missingContainers/missingContainers.tsx:
##########
@@ -35,18 +36,48 @@ interface IMissingContainerResponse {
pipelineID: string;
}
+interface IAllContainerResponse {
+ containerID: number;
+ containerState: string;
+ unhealthySince: string;
+ expectedReplicaCount: number;
+ actualReplicaCount: number;
+ replicaDeltaCount: number;
+ reason: string;
+ keys: number;
+ pipelineID: string;
+ replicas: IContainerReplicaAll[];
+}
+
export interface IContainerReplica {
containerId: number;
datanodeHost: string;
firstReportTimestamp: number;
lastReportTimestamp: number;
}
+export interface IContainerReplicaAll {
Review Comment:
```suggestion
export interface IContainerReplicas {
```
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/missingContainers/missingContainers.tsx:
##########
@@ -158,6 +189,294 @@ const KEY_TABLE_COLUMNS = [
}
];
+const UCOLUMNS = [
Review Comment:
I checked and the `UCOLUMNS`, `OCOLUMNS`, `MCOLUMNS` and `ACOLUMNS` are exactly the same. Why do we have it copied 4 times?
If we want to handle the `MISSING` state the same as the others we could have only the COLUMNS (starts on line 97) and adjust it to the parameters.
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/api/db.json:
##########
@@ -1260,5 +1260,334 @@
"lastUpdatedTimestamp": 1663421094507,
"lastUpdatedSeqNumber": 0
}
- ]
+ ],
+ "UNDER_REPLICATED": {
+ "missingCount": 0,
+ "underReplicatedCount": 1,
+ "overReplicatedCount": 0,
+ "misReplicatedCount": 0,
+ "containers": [
+ {
+ "containerID": 2,
+ "containerState": "UNDER_REPLICATED",
+ "unhealthySince": 1665590446222,
+ "expectedReplicaCount": 3,
+ "actualReplicaCount": 2,
+ "replicaDeltaCount": 1,
+ "reason": null,
+ "keys": 1,
+ "pipelineID": "a10ffab6-8ed5-414a-aaf5-79890ff3e8a1",
+ "replicas": [
+ {
+ "containerId": 2,
+ "datanodeUuid": "15526f1b-76f2-4d8f-876c-c343c94ea476",
+ "datanodeHost": "ozone_datanode_2.ozone_UnderReplicated2",
+ "firstSeenTime": 1665588176660,
+ "lastSeenTime": 1665590397315,
+ "lastBcsId": 2
+ },
+ {
+ "containerId": 2,
+ "datanodeUuid": "f55476ab-4687-464d-a100-1c65de4366e3",
+ "datanodeHost": "ozone_datanode_3.ozone_underreplicated2",
+ "firstSeenTime": 1665588176616,
+ "lastSeenTime": 1665590392293,
+ "lastBcsId": 2
+ },
+ {
+ "containerId": 2,
+ "datanodeUuid": "7a457bcb-d63e-49cc-b3ff-8b22bf48d130",
+ "datanodeHost": "ozone_datanode_1.ozone_underreplicated2",
+ "firstSeenTime": 1665588176660,
+ "lastSeenTime": 1665590272289,
+ "lastBcsId": 0
+ }
+ ]
+ },
+ {
+ "containerID": 3,
+ "containerState": "UNDER_REPLICATED",
+ "unhealthySince": 1665590446222,
+ "expectedReplicaCount": 4,
+ "actualReplicaCount": 2,
+ "replicaDeltaCount": 2,
+ "reason": null,
+ "keys": 1,
+ "pipelineID": "a10ffab6-8ed5-414a-aaf5-79890ff3e8a1",
+ "replicas": [
+ {
+ "containerId": 3,
+ "datanodeUuid": "15526f1b-76f2-4d8f-876c-c343c94ea476",
+ "datanodeHost": "ozone_datanode_2.ozone_underreplicated3",
+ "firstSeenTime": 1665588176660,
+ "lastSeenTime": 1665590397315,
+ "lastBcsId": 2
+ },
+ {
+ "containerId": 3,
+ "datanodeUuid": "f55476ab-4687-464d-a100-1c65de4366e3",
+ "datanodeHost": "ozone_datanode_3.ozone_underreplicated3",
+ "firstSeenTime": 1665588176616,
+ "lastSeenTime": 1665590392293,
+ "lastBcsId": 2
+ },
+ {
+ "containerId": 3,
+ "datanodeUuid": "7a457bcb-d63e-49cc-b3ff-8b22bf48d130",
+ "datanodeHost": "ozone_datanode_1.ozone_underreplicated3",
+ "firstSeenTime": 1665588176660,
+ "lastSeenTime": 1665590272289,
+ "lastBcsId": 0
+ }
+ ]
+ }
+ ]
+ },
+ "Over_REPLICATED": {
+ "missingCount": 0,
+ "underReplicatedCount": 1,
+ "overReplicatedCount": 0,
+ "misReplicatedCount": 0,
+ "containers": [
+ {
+ "containerID": 2,
+ "containerState": "OVER_REPLICATED",
+ "unhealthySince": 1665590446222,
+ "expectedReplicaCount": 3,
+ "actualReplicaCount": 2,
+ "replicaDeltaCount": 1,
+ "reason": null,
+ "keys": 1,
+ "pipelineID": "a10ffab6-8ed5-414a-aaf5-79890ff3e8a1",
+ "replicas": [
+ {
+ "containerId": 2,
+ "datanodeUuid": "15526f1b-76f2-4d8f-876c-c343c94ea476",
+ "datanodeHost": "ozone_datanode_2.ozone_overreplicated2",
+ "firstSeenTime": 1665588176660,
+ "lastSeenTime": 1665590397315,
+ "lastBcsId": 2
+ },
+ {
+ "containerId": 2,
+ "datanodeUuid": "f55476ab-4687-464d-a100-1c65de4366e3",
+ "datanodeHost": "ozone_datanode_3.ozone_overreplicated22",
+ "firstSeenTime": 1665588176616,
+ "lastSeenTime": 1665590392293,
+ "lastBcsId": 2
+ },
+ {
+ "containerId": 2,
+ "datanodeUuid": "7a457bcb-d63e-49cc-b3ff-8b22bf48d130",
+ "datanodeHost": "ozone_datanode_1.ozone_overreplicated2",
+ "firstSeenTime": 1665588176660,
+ "lastSeenTime": 1665590272289,
+ "lastBcsId": 0
+ }
+ ]
+ },
+ {
+ "containerID": 3,
+ "containerState": "OVER_REPLICATED",
+ "unhealthySince": 1665590446222,
+ "expectedReplicaCount": 4,
+ "actualReplicaCount": 2,
+ "replicaDeltaCount": 2,
+ "reason": null,
+ "keys": 1,
+ "pipelineID": "a10ffab6-8ed5-414a-aaf5-79890ff3e8a1",
+ "replicas": [
+ {
+ "containerId": 3,
+ "datanodeUuid": "15526f1b-76f2-4d8f-876c-c343c94ea476",
+ "datanodeHost": "ozone_datanode_2.ozone_overreplicated3",
+ "firstSeenTime": 1665588176660,
+ "lastSeenTime": 1665590397315,
+ "lastBcsId": 2
+ },
+ {
+ "containerId": 3,
+ "datanodeUuid": "f55476ab-4687-464d-a100-1c65de4366e3",
+ "datanodeHost": "ozone_datanode_3.ozone_overreplicated3",
+ "firstSeenTime": 1665588176616,
+ "lastSeenTime": 1665590392293,
+ "lastBcsId": 2
+ },
+ {
+ "containerId": 3,
+ "datanodeUuid": "7a457bcb-d63e-49cc-b3ff-8b22bf48d130",
+ "datanodeHost": "ozone_datanode_1.ozone_overreplicated3",
+ "firstSeenTime": 1665588176660,
+ "lastSeenTime": 1665590272289,
+ "lastBcsId": 0
+ }
+ ]
+ }
+ ]
+ },
+ "MIS_REPLICATED": {
+ "missingCount": 0,
+ "underReplicatedCount": 1,
+ "overReplicatedCount": 0,
+ "misReplicatedCount": 0,
+ "containers": [
+ {
+ "containerID": 2,
+ "containerState": "MIS_REPLICATED",
+ "unhealthySince": 1665590446222,
+ "expectedReplicaCount": 3,
+ "actualReplicaCount": 2,
+ "replicaDeltaCount": 1,
+ "reason": null,
+ "keys": 1,
+ "pipelineID": "a10ffab6-8ed5-414a-aaf5-79890ff3e8a1",
+ "replicas": [
+ {
+ "containerId": 2,
+ "datanodeUuid": "15526f1b-76f2-4d8f-876c-c343c94ea476",
+ "datanodeHost": "ozone_datanode_2.ozone_misreplicated2",
+ "firstSeenTime": 1665588176660,
+ "lastSeenTime": 1665590397315,
+ "lastBcsId": 2
+ },
+ {
+ "containerId": 2,
+ "datanodeUuid": "f55476ab-4687-464d-a100-1c65de4366e3",
+ "datanodeHost": "ozone_datanode_3.ozone_misreplicated2",
+ "firstSeenTime": 1665588176616,
+ "lastSeenTime": 1665590392293,
+ "lastBcsId": 2
+ },
+ {
+ "containerId": 2,
+ "datanodeUuid": "7a457bcb-d63e-49cc-b3ff-8b22bf48d130",
+ "datanodeHost": "ozone_datanode_1.ozone_misreplicated2",
+ "firstSeenTime": 1665588176660,
+ "lastSeenTime": 1665590272289,
+ "lastBcsId": 0
+ }
+ ]
+ },
+ {
+ "containerID": 3,
+ "containerState": "MIS_REPLICATED",
+ "unhealthySince": 1665590446222,
+ "expectedReplicaCount": 4,
+ "actualReplicaCount": 2,
+ "replicaDeltaCount": 2,
+ "reason": null,
+ "keys": 1,
+ "pipelineID": "a10ffab6-8ed5-414a-aaf5-79890ff3e8a1",
+ "replicas": [
+ {
+ "containerId": 3,
+ "datanodeUuid": "15526f1b-76f2-4d8f-876c-c343c94ea476",
+ "datanodeHost": "ozone_datanode_2.ozone_misreplicated3",
+ "firstSeenTime": 1665588176660,
+ "lastSeenTime": 1665590397315,
+ "lastBcsId": 2
+ },
+ {
+ "containerId": 3,
+ "datanodeUuid": "f55476ab-4687-464d-a100-1c65de4366e3",
+ "datanodeHost": "ozone_datanode_3.ozone_misreplicated3",
+ "firstSeenTime": 1665588176616,
+ "lastSeenTime": 1665590392293,
+ "lastBcsId": 2
+ },
+ {
+ "containerId": 3,
+ "datanodeUuid": "7a457bcb-d63e-49cc-b3ff-8b22bf48d130",
+ "datanodeHost": "ozone_datanode_1.ozone_misreplicated3",
+ "firstSeenTime": 1665588176660,
+ "lastSeenTime": 1665590272289,
+ "lastBcsId": 0
+ }
+ ]
+ }
+ ]
+ },
+ "ALL_REPLICAS_UNHEALTHY": {
+ "missingCount": 0,
+ "underReplicatedCount": 1,
+ "overReplicatedCount": 1,
+ "misReplicatedCount": 1,
+ "containers": [
+ {
+ "containerID": 2,
+ "containerState": "ALL_REPLICAS_UNHEALTHY",
+ "unhealthySince": 1665590446222,
+ "expectedReplicaCount": 3,
+ "actualReplicaCount": 2,
+ "replicaDeltaCount": 1,
+ "reason": null,
+ "keys": 1,
+ "pipelineID": "a10ffab6-8ed5-414a-aaf5-79890ff3e8a1",
+ "replicas": [
+ {
+ "containerId": 2,
+ "datanodeUuid": "15526f1b-76f2-4d8f-876c-c343c94ea476",
+ "datanodeHost": "ozone_datanode_2.ozone_allreplica2",
+ "firstSeenTime": 1665588176660,
+ "lastSeenTime": 1665590397315,
+ "lastBcsId": 2
+ },
+ {
+ "containerId": 2,
+ "datanodeUuid": "f55476ab-4687-464d-a100-1c65de4366e3",
+ "datanodeHost": "ozone_datanode_3.ozone_allreplica2",
+ "firstSeenTime": 1665588176616,
+ "lastSeenTime": 1665590392293,
+ "lastBcsId": 2
+ },
+ {
+ "containerId": 2,
+ "datanodeUuid": "7a457bcb-d63e-49cc-b3ff-8b22bf48d130",
+ "datanodeHost": "ozone_datanode_1.ozone_allreplica2",
+ "firstSeenTime": 1665588176660,
+ "lastSeenTime": 1665590272289,
+ "lastBcsId": 0
+ }
+ ]
+ },
+ {
+ "containerID": 3,
+ "containerState": "ALL_REPLICAS_UNHEALTHY",
+ "unhealthySince": 1665590446222,
+ "expectedReplicaCount": 4,
+ "actualReplicaCount": 2,
+ "replicaDeltaCount": 2,
+ "reason": null,
+ "keys": 1,
+ "pipelineID": "a10ffab6-8ed5-414a-aaf5-79890ff3e8a1",
+ "replicas": [
+ {
+ "containerId": 3,
+ "datanodeUuid": "15526f1b-76f2-4d8f-876c-c343c94ea476",
+ "datanodeHost": "ozone_datanode_2.ozone_allreplica3",
+ "firstSeenTime": 1665588176660,
+ "lastSeenTime": 1665590397315,
+ "lastBcsId": 2
+ },
+ {
+ "containerId": 3,
+ "datanodeUuid": "f55476ab-4687-464d-a100-1c65de4366e3",
+ "datanodeHost": "ozone_datanode_3.ozone_allreplica3",
+ "firstSeenTime": 1665588176616,
+ "lastSeenTime": 1665590392293,
+ "lastBcsId": 2
+ },
+ {
+ "containerId": 3,
+ "datanodeUuid": "7a457bcb-d63e-49cc-b3ff-8b22bf48d130",
+ "datanodeHost": "ozone_datanode_1.ozone_allreplica3",
+ "firstSeenTime": 1665588176660,
+ "lastSeenTime": 1665590272289,
+ "lastBcsId": 0
+ }
+ ]
+ }
+ ]
+ }
+
Review Comment:
In this PR we shouldn't integrate with the state `ALL_REPLICA_UNHEALTHY` as the data is not populated correctly yet on the Recon side. I think we should remove code related to that and add it only if it is working correctly.
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/missingContainers/missingContainers.tsx:
##########
@@ -192,16 +519,41 @@ export class MissingContainers extends React.Component<Record<string, object>, I
this.setState({
loading: true
});
- axios.get('/api/v1/containers/missing').then(response => {
- const missingContainersResponse: IMissingContainersResponse = response.data;
- const totalCount = missingContainersResponse.totalCount;
- const missingContainers: IMissingContainerResponse[] = missingContainersResponse.containers;
+
+ axios.all([
+ axios.get('/api/v1/containers/missing'),
+ axios.get('/api/v1/containers/unhealthy/UNDER_REPLICATED'),
+ axios.get('/api/v1/containers/unhealthy/OVER_REPLICATED'),
+ axios.get('/api/v1/containers/unhealthy/MIS_REPLICATED'),
+ axios.get('/api/v1/containers/unhealthy/ALL_REPLICAS_UNHEALTHY'),
+ ]).then(axios.spread((missingContainersResponse, underReplicatedResponse, overReplicatedResponse, misReplicatedResponse, allReplicatedResponse) => {
+
+ const missingContainersResponse1: IMissingContainersResponse = missingContainersResponse.data;
Review Comment:
Why do we need to number (eg. `missingContainersResponse1`) the variables like this? I don't see other usages later.
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/missingContainers/missingContainers.tsx:
##########
@@ -213,6 +565,13 @@ export class MissingContainers extends React.Component<Record<string, object>, I
console.log(current, pageSize);
};
+ onTabChange = (activeKey: string) => {
+ // Fetch inactive pipelines if tab is switched to "Inactive"
+ if (activeKey === '2') {
+ // Fetch inactive pipelines in the future
+ }
+ };
+
Review Comment:
I don't understand this part and the comments. How do pipelines come here?
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/missingContainers/missingContainers.tsx:
##########
@@ -35,18 +36,48 @@ interface IMissingContainerResponse {
pipelineID: string;
}
+interface IAllContainerResponse {
Review Comment:
Some naming suggestions, maybe it is more clear what are these used for.
```suggestion
interface IContainerResponse {
```
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/missingContainers/missingContainers.tsx:
##########
@@ -82,7 +113,7 @@ const COLUMNS = [
key: 'replicas',
render: (replicas: IContainerReplica[]) => (
<div>
- {replicas.map(replica => {
+ {replicas && replicas.map(replica => {
Review Comment:
Can you help me understand why do we need this?
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/missingContainers/missingContainers.tsx:
##########
@@ -35,18 +36,48 @@ interface IMissingContainerResponse {
pipelineID: string;
}
+interface IAllContainerResponse {
+ containerID: number;
+ containerState: string;
+ unhealthySince: string;
+ expectedReplicaCount: number;
+ actualReplicaCount: number;
+ replicaDeltaCount: number;
+ reason: string;
+ keys: number;
+ pipelineID: string;
+ replicas: IContainerReplicaAll[];
+}
+
export interface IContainerReplica {
containerId: number;
datanodeHost: string;
firstReportTimestamp: number;
lastReportTimestamp: number;
}
+export interface IContainerReplicaAll {
+ containerId: number;
+ datanodeUuid: string;
+ datanodeHost: string;
+ firstSeenTime: number;
+ lastSeenTime: number;
+ lastBcsId: number;
+}
+
export interface IMissingContainersResponse {
totalCount: number;
containers: IMissingContainerResponse[];
}
+interface IAllReplicatedContainersResponse {
Review Comment:
```suggestion
interface IUnhealthyContainersResponse {
```
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/api/routes.json:
##########
@@ -23,5 +23,9 @@
"/namespace/du?path=/clunky&files=true": "/clunky",
"/namespace/summary?path=*": "/metadata",
"/namespace/quota?path=*": "/quota",
- "/task/status": "/taskStatus"
+ "/task/status": "/taskStatus",
+ "/containers/unhealthy/UNDER_REPLICATED": "/UNDER_REPLICATED",
+ "/containers/unhealthy/OVER_REPLICATED": "/OVER_REPLICATED",
+ "/containers/unhealthy/MIS_REPLICATED": "/MIS_REPLICATED",
+ "/containers/unhealthy/ALL_REPLICAS_UNHEALTHY": "/ALL_REPLICAS_UNHEALTHY"
Review Comment:
On the line 4 there is one route for the missing containers, maybe we should follow this pattern and add it like this (and remove the previous one). Also remove the route to `ALL_REPLICAS_UNHEALTHY`.
```suggestion
"/containers/unhealthy/MISSING": "/missingContainers",
"/containers/unhealthy/UNDER_REPLICATED": "/underreplicatedContainers",
"/containers/unhealthy/OVER_REPLICATED": "/overreplicatedContainers",
"/containers/unhealthy/MIS_REPLICATED": "/misreplicatedContainers"
```
Maybe we can consider to add the tag `@Deprecated` to the /missing endpoint in ContainerEndpoint. Let me know what you think @smengcl
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] smitajoshi12 commented on a diff in pull request #3837: HDDS-7248. Recon: Expand the container status page to show all unhealthy container states
Posted by GitBox <gi...@apache.org>.
smitajoshi12 commented on code in PR #3837:
URL: https://github.com/apache/ozone/pull/3837#discussion_r998186128
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/api/routes.json:
##########
@@ -23,5 +23,9 @@
"/namespace/du?path=/clunky&files=true": "/clunky",
"/namespace/summary?path=*": "/metadata",
"/namespace/quota?path=*": "/quota",
- "/task/status": "/taskStatus"
+ "/task/status": "/taskStatus",
+ "/containers/unhealthy/UNDER_REPLICATED": "/UNDER_REPLICATED",
+ "/containers/unhealthy/OVER_REPLICATED": "/OVER_REPLICATED",
+ "/containers/unhealthy/MIS_REPLICATED": "/MIS_REPLICATED",
+ "/containers/unhealthy/ALL_REPLICAS_UNHEALTHY": "/ALL_REPLICAS_UNHEALTHY"
Review Comment:
It is already defined at line number 4.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] smitajoshi12 commented on a diff in pull request #3837: HDDS-7248. Recon: Expand the container status page to show all unhealthy container states
Posted by GitBox <gi...@apache.org>.
smitajoshi12 commented on code in PR #3837:
URL: https://github.com/apache/ozone/pull/3837#discussion_r998104844
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/missingContainers/missingContainers.tsx:
##########
@@ -35,18 +36,48 @@ interface IMissingContainerResponse {
pipelineID: string;
}
+interface IAllContainerResponse {
+ containerID: number;
+ containerState: string;
+ unhealthySince: string;
+ expectedReplicaCount: number;
+ actualReplicaCount: number;
+ replicaDeltaCount: number;
+ reason: string;
+ keys: number;
+ pipelineID: string;
+ replicas: IContainerReplicaAll[];
+}
+
export interface IContainerReplica {
containerId: number;
datanodeHost: string;
firstReportTimestamp: number;
lastReportTimestamp: number;
}
+export interface IContainerReplicaAll {
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] smengcl commented on a diff in pull request #3837: HDDS-7248. Recon: Expand the container status page to show all unhealthy container states
Posted by GitBox <gi...@apache.org>.
smengcl commented on code in PR #3837:
URL: https://github.com/apache/ozone/pull/3837#discussion_r998556899
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/missingContainers/missingContainers.tsx:
##########
@@ -172,6 +275,9 @@ interface IExpandedRowState {
interface IMissingContainersState {
loading: boolean;
dataSource: IMissingContainerResponse[];
+ udataSource: IContainerResponse[];
+ odataSource: IContainerResponse[];
+ mdataSource: IContainerResponse[];
Review Comment:
1. Add a comment clarifying that `u` stands for `underReplicated` here;
2. or use full name for the variables here? e.g. `underReplicatedDataSource`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] smitajoshi12 commented on a diff in pull request #3837: HDDS-7248. Recon: Expand the container status page to show all unhealthy container states
Posted by GitBox <gi...@apache.org>.
smitajoshi12 commented on code in PR #3837:
URL: https://github.com/apache/ozone/pull/3837#discussion_r999440135
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/missingContainers/missingContainers.tsx:
##########
@@ -35,18 +36,48 @@ interface IMissingContainerResponse {
pipelineID: string;
}
+interface IContainerResponse {
+ containerID: number;
+ containerState: string;
+ unhealthySince: string;
+ expectedReplicaCount: number;
+ actualReplicaCount: number;
+ replicaDeltaCount: number;
+ reason: string;
+ keys: number;
+ pipelineID: string;
Review Comment:
In Java File I can see pipelineID.
https://github.com/apache/ozone/blob/master/hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/api/types/UnhealthyContainerMetadata.java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] smitajoshi12 commented on a diff in pull request #3837: HDDS-7248. Recon: Expand the container status page to show all unhealthy container states
Posted by GitBox <gi...@apache.org>.
smitajoshi12 commented on code in PR #3837:
URL: https://github.com/apache/ozone/pull/3837#discussion_r1000227620
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/missingContainers/missingContainers.tsx:
##########
@@ -192,16 +301,36 @@ export class MissingContainers extends React.Component<Record<string, object>, I
this.setState({
loading: true
});
- axios.get('/api/v1/containers/missing').then(response => {
- const missingContainersResponse: IMissingContainersResponse = response.data;
- const totalCount = missingContainersResponse.totalCount;
- const missingContainers: IMissingContainerResponse[] = missingContainersResponse.containers;
+
+ axios.all([
+ axios.get('/api/v1/containers/unhealthy/MISSING'),
Review Comment:
Getting this Response.
http://localhost:9888/api/v1/containers/unhealthy/
{"missingCount":0,"underReplicatedCount":0,"overReplicatedCount":0,"misReplicatedCount":0,"containers":[]} but not sure How will be Containers data and states so Can we change this things in next JIRA I am not sure about changes and logic unless I get proper data from cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] dombizita commented on a diff in pull request #3837: HDDS-7248. Recon: Expand the container status page to show all unhealthy container states
Posted by GitBox <gi...@apache.org>.
dombizita commented on code in PR #3837:
URL: https://github.com/apache/ozone/pull/3837#discussion_r1000239940
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/missingContainers/missingContainers.tsx:
##########
@@ -192,16 +301,36 @@ export class MissingContainers extends React.Component<Record<string, object>, I
this.setState({
loading: true
});
- axios.get('/api/v1/containers/missing').then(response => {
- const missingContainersResponse: IMissingContainersResponse = response.data;
- const totalCount = missingContainersResponse.totalCount;
- const missingContainers: IMissingContainerResponse[] = missingContainersResponse.containers;
+
+ axios.all([
+ axios.get('/api/v1/containers/unhealthy/MISSING'),
+ axios.get('/api/v1/containers/unhealthy/UNDER_REPLICATED'),
+ axios.get('/api/v1/containers/unhealthy/OVER_REPLICATED'),
+ axios.get('/api/v1/containers/unhealthy/MIS_REPLICATED')
Review Comment:
In what kind of cluster did you get this response? Did you change everything accordingly to this change? If you don't pass any state as a parameter to the endpoint it will return all the containers (javadoc on the `@Path("/unhealthy/{state}")`: `Passing null returns all containers.`) . Based on the javadoc on the `@Path("/unhealthy")`:
```
* Return
* {@link org.apache.hadoop.ozone.recon.api.types.UnhealthyContainerMetadata}
* for all unhealthy containers.
```
I am fine if we ask every states endpoint individually for now, but please change the `MISSING` state ask accordingly to the others (`/api/v1/containers/unhealthy/MISSING`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] smitajoshi12 commented on a diff in pull request #3837: HDDS-7248. Recon: Expand the container status page to show all unhealthy container states
Posted by GitBox <gi...@apache.org>.
smitajoshi12 commented on code in PR #3837:
URL: https://github.com/apache/ozone/pull/3837#discussion_r998120349
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/missingContainers/missingContainers.tsx:
##########
@@ -192,16 +519,41 @@ export class MissingContainers extends React.Component<Record<string, object>, I
this.setState({
loading: true
});
- axios.get('/api/v1/containers/missing').then(response => {
- const missingContainersResponse: IMissingContainersResponse = response.data;
- const totalCount = missingContainersResponse.totalCount;
- const missingContainers: IMissingContainerResponse[] = missingContainersResponse.containers;
+
+ axios.all([
+ axios.get('/api/v1/containers/missing'),
+ axios.get('/api/v1/containers/unhealthy/UNDER_REPLICATED'),
+ axios.get('/api/v1/containers/unhealthy/OVER_REPLICATED'),
+ axios.get('/api/v1/containers/unhealthy/MIS_REPLICATED'),
+ axios.get('/api/v1/containers/unhealthy/ALL_REPLICAS_UNHEALTHY'),
+ ]).then(axios.spread((missingContainersResponse, underReplicatedResponse, overReplicatedResponse, misReplicatedResponse, allReplicatedResponse) => {
+
+ const missingContainersResponse1: IMissingContainersResponse = missingContainersResponse.data;
Review Comment:
const missingContainersResponse1: IMissingContainersResponse = missingContainersResponse.data;
const totalCount = missingContainersResponse1.totalCount;
const missingContainers: IMissingContainerResponse[] = missingContainersResponse1.containers;
We are assigning to missingContainersResponse1.containers to missingContainers
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] smengcl commented on a diff in pull request #3837: HDDS-7248. Recon: Expand the container status page to show all unhealthy container states
Posted by GitBox <gi...@apache.org>.
smengcl commented on code in PR #3837:
URL: https://github.com/apache/ozone/pull/3837#discussion_r998556899
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/missingContainers/missingContainers.tsx:
##########
@@ -172,6 +275,9 @@ interface IExpandedRowState {
interface IMissingContainersState {
loading: boolean;
dataSource: IMissingContainerResponse[];
+ udataSource: IContainerResponse[];
+ odataSource: IContainerResponse[];
+ mdataSource: IContainerResponse[];
Review Comment:
1. Add a comment clarifying that `u` stands for `underReplicated` here; or
2. Use full name here?
```suggestion
udataSource: IContainerResponse[];
odataSource: IContainerResponse[];
mdataSource: IContainerResponse[];
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] smengcl commented on a diff in pull request #3837: HDDS-7248. Recon: Expand the container status page to show all unhealthy container states
Posted by GitBox <gi...@apache.org>.
smengcl commented on code in PR #3837:
URL: https://github.com/apache/ozone/pull/3837#discussion_r998564308
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/missingContainers/missingContainers.tsx:
##########
@@ -192,16 +519,41 @@ export class MissingContainers extends React.Component<Record<string, object>, I
this.setState({
loading: true
});
- axios.get('/api/v1/containers/missing').then(response => {
- const missingContainersResponse: IMissingContainersResponse = response.data;
- const totalCount = missingContainersResponse.totalCount;
- const missingContainers: IMissingContainerResponse[] = missingContainersResponse.containers;
+
+ axios.all([
+ axios.get('/api/v1/containers/missing'),
+ axios.get('/api/v1/containers/unhealthy/UNDER_REPLICATED'),
+ axios.get('/api/v1/containers/unhealthy/OVER_REPLICATED'),
+ axios.get('/api/v1/containers/unhealthy/MIS_REPLICATED'),
+ axios.get('/api/v1/containers/unhealthy/ALL_REPLICAS_UNHEALTHY'),
+ ]).then(axios.spread((missingContainersResponse, underReplicatedResponse, overReplicatedResponse, misReplicatedResponse, allReplicatedResponse) => {
+
+ const missingContainersResponse1: IMissingContainersResponse = missingContainersResponse.data;
Review Comment:
Pls avoid ambiguous variable names like this in non-test code. Better rename this to `missingContainersResponseData`?
```suggestion
const missingContainersResponseData: IMissingContainersResponse = missingContainersResponse.data;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] smitajoshi12 commented on a diff in pull request #3837: HDDS-7248. Recon: Expand the container status page to show all unhealthy container states
Posted by GitBox <gi...@apache.org>.
smitajoshi12 commented on code in PR #3837:
URL: https://github.com/apache/ozone/pull/3837#discussion_r999407772
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/components/navBar/navBar.tsx:
##########
@@ -66,6 +66,11 @@ class NavBar extends React.Component<INavBarProps> {
<span>Pipelines</span>
<Link to='/Pipelines'/>
</Menu.Item>
+ <Menu.Item key='/Containers'>
+ <Icon type='container'/>
Review Comment:
It looks like below image.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] dombizita commented on a diff in pull request #3837: HDDS-7248. Recon: Expand the container status page to show all unhealthy container states
Posted by GitBox <gi...@apache.org>.
dombizita commented on code in PR #3837:
URL: https://github.com/apache/ozone/pull/3837#discussion_r999591046
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/missingContainers/missingContainers.tsx:
##########
@@ -158,6 +189,294 @@ const KEY_TABLE_COLUMNS = [
}
];
+const UCOLUMNS = [
Review Comment:
We can use the `Unhealthy Since` column for the `MISSING` state as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] dombizita commented on a diff in pull request #3837: HDDS-7248. Recon: Expand the container status page to show all unhealthy container states
Posted by GitBox <gi...@apache.org>.
dombizita commented on code in PR #3837:
URL: https://github.com/apache/ozone/pull/3837#discussion_r1000243147
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/missingContainers/missingContainers.tsx:
##########
@@ -192,16 +301,36 @@ export class MissingContainers extends React.Component<Record<string, object>, I
this.setState({
loading: true
});
- axios.get('/api/v1/containers/missing').then(response => {
- const missingContainersResponse: IMissingContainersResponse = response.data;
- const totalCount = missingContainersResponse.totalCount;
- const missingContainers: IMissingContainerResponse[] = missingContainersResponse.containers;
+
+ axios.all([
+ axios.get('/api/v1/containers/unhealthy/MISSING'),
Review Comment:
What kind of response did you expect from the endpoint? What is the state of the cluster? If we don't have missing containers in the cluster this is a good response, this is the scheme we are looking for.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] smitajoshi12 commented on a diff in pull request #3837: HDDS-7248. Recon: Expand the container status page to show all unhealthy container states
Posted by GitBox <gi...@apache.org>.
smitajoshi12 commented on code in PR #3837:
URL: https://github.com/apache/ozone/pull/3837#discussion_r1000225673
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/missingContainers/missingContainers.tsx:
##########
@@ -192,16 +301,36 @@ export class MissingContainers extends React.Component<Record<string, object>, I
this.setState({
loading: true
});
- axios.get('/api/v1/containers/missing').then(response => {
- const missingContainersResponse: IMissingContainersResponse = response.data;
- const totalCount = missingContainersResponse.totalCount;
- const missingContainers: IMissingContainerResponse[] = missingContainersResponse.containers;
+
+ axios.all([
+ axios.get('/api/v1/containers/unhealthy/MISSING'),
+ axios.get('/api/v1/containers/unhealthy/UNDER_REPLICATED'),
+ axios.get('/api/v1/containers/unhealthy/OVER_REPLICATED'),
+ axios.get('/api/v1/containers/unhealthy/MIS_REPLICATED')
Review Comment:
Getting this Response.
{"missingCount":0,"underReplicatedCount":0,"overReplicatedCount":0,"misReplicatedCount":0,"containers":[]} but not sure How will be Containers data and states so Can we change this things in next JIRA I am not sure about changes and logic unless I get proper data from cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] smitajoshi12 commented on a diff in pull request #3837: HDDS-7248. Recon: Expand the container status page to show all unhealthy container states
Posted by GitBox <gi...@apache.org>.
smitajoshi12 commented on code in PR #3837:
URL: https://github.com/apache/ozone/pull/3837#discussion_r998084691
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/api/db.json:
##########
@@ -1260,5 +1260,334 @@
"lastUpdatedTimestamp": 1663421094507,
"lastUpdatedSeqNumber": 0
}
- ]
+ ],
+ "UNDER_REPLICATED": {
+ "missingCount": 0,
+ "underReplicatedCount": 1,
+ "overReplicatedCount": 0,
+ "misReplicatedCount": 0,
+ "containers": [
+ {
+ "containerID": 2,
+ "containerState": "UNDER_REPLICATED",
+ "unhealthySince": 1665590446222,
+ "expectedReplicaCount": 3,
+ "actualReplicaCount": 2,
+ "replicaDeltaCount": 1,
+ "reason": null,
+ "keys": 1,
+ "pipelineID": "a10ffab6-8ed5-414a-aaf5-79890ff3e8a1",
+ "replicas": [
+ {
+ "containerId": 2,
+ "datanodeUuid": "15526f1b-76f2-4d8f-876c-c343c94ea476",
+ "datanodeHost": "ozone_datanode_2.ozone_UnderReplicated2",
+ "firstSeenTime": 1665588176660,
+ "lastSeenTime": 1665590397315,
+ "lastBcsId": 2
+ },
+ {
+ "containerId": 2,
+ "datanodeUuid": "f55476ab-4687-464d-a100-1c65de4366e3",
+ "datanodeHost": "ozone_datanode_3.ozone_underreplicated2",
+ "firstSeenTime": 1665588176616,
+ "lastSeenTime": 1665590392293,
+ "lastBcsId": 2
+ },
+ {
+ "containerId": 2,
+ "datanodeUuid": "7a457bcb-d63e-49cc-b3ff-8b22bf48d130",
+ "datanodeHost": "ozone_datanode_1.ozone_underreplicated2",
+ "firstSeenTime": 1665588176660,
+ "lastSeenTime": 1665590272289,
+ "lastBcsId": 0
+ }
+ ]
+ },
+ {
+ "containerID": 3,
+ "containerState": "UNDER_REPLICATED",
+ "unhealthySince": 1665590446222,
+ "expectedReplicaCount": 4,
+ "actualReplicaCount": 2,
+ "replicaDeltaCount": 2,
+ "reason": null,
+ "keys": 1,
+ "pipelineID": "a10ffab6-8ed5-414a-aaf5-79890ff3e8a1",
+ "replicas": [
+ {
+ "containerId": 3,
+ "datanodeUuid": "15526f1b-76f2-4d8f-876c-c343c94ea476",
+ "datanodeHost": "ozone_datanode_2.ozone_underreplicated3",
+ "firstSeenTime": 1665588176660,
+ "lastSeenTime": 1665590397315,
+ "lastBcsId": 2
+ },
+ {
+ "containerId": 3,
+ "datanodeUuid": "f55476ab-4687-464d-a100-1c65de4366e3",
+ "datanodeHost": "ozone_datanode_3.ozone_underreplicated3",
+ "firstSeenTime": 1665588176616,
+ "lastSeenTime": 1665590392293,
+ "lastBcsId": 2
+ },
+ {
+ "containerId": 3,
+ "datanodeUuid": "7a457bcb-d63e-49cc-b3ff-8b22bf48d130",
+ "datanodeHost": "ozone_datanode_1.ozone_underreplicated3",
+ "firstSeenTime": 1665588176660,
+ "lastSeenTime": 1665590272289,
+ "lastBcsId": 0
+ }
+ ]
+ }
+ ]
+ },
+ "Over_REPLICATED": {
+ "missingCount": 0,
+ "underReplicatedCount": 1,
+ "overReplicatedCount": 0,
+ "misReplicatedCount": 0,
+ "containers": [
+ {
+ "containerID": 2,
+ "containerState": "OVER_REPLICATED",
+ "unhealthySince": 1665590446222,
+ "expectedReplicaCount": 3,
+ "actualReplicaCount": 2,
+ "replicaDeltaCount": 1,
+ "reason": null,
+ "keys": 1,
+ "pipelineID": "a10ffab6-8ed5-414a-aaf5-79890ff3e8a1",
+ "replicas": [
+ {
+ "containerId": 2,
+ "datanodeUuid": "15526f1b-76f2-4d8f-876c-c343c94ea476",
+ "datanodeHost": "ozone_datanode_2.ozone_overreplicated2",
+ "firstSeenTime": 1665588176660,
+ "lastSeenTime": 1665590397315,
+ "lastBcsId": 2
+ },
+ {
+ "containerId": 2,
+ "datanodeUuid": "f55476ab-4687-464d-a100-1c65de4366e3",
+ "datanodeHost": "ozone_datanode_3.ozone_overreplicated22",
+ "firstSeenTime": 1665588176616,
+ "lastSeenTime": 1665590392293,
+ "lastBcsId": 2
+ },
+ {
+ "containerId": 2,
+ "datanodeUuid": "7a457bcb-d63e-49cc-b3ff-8b22bf48d130",
+ "datanodeHost": "ozone_datanode_1.ozone_overreplicated2",
+ "firstSeenTime": 1665588176660,
+ "lastSeenTime": 1665590272289,
+ "lastBcsId": 0
+ }
+ ]
+ },
+ {
+ "containerID": 3,
+ "containerState": "OVER_REPLICATED",
+ "unhealthySince": 1665590446222,
+ "expectedReplicaCount": 4,
+ "actualReplicaCount": 2,
+ "replicaDeltaCount": 2,
+ "reason": null,
+ "keys": 1,
+ "pipelineID": "a10ffab6-8ed5-414a-aaf5-79890ff3e8a1",
+ "replicas": [
+ {
+ "containerId": 3,
+ "datanodeUuid": "15526f1b-76f2-4d8f-876c-c343c94ea476",
+ "datanodeHost": "ozone_datanode_2.ozone_overreplicated3",
+ "firstSeenTime": 1665588176660,
+ "lastSeenTime": 1665590397315,
+ "lastBcsId": 2
+ },
+ {
+ "containerId": 3,
+ "datanodeUuid": "f55476ab-4687-464d-a100-1c65de4366e3",
+ "datanodeHost": "ozone_datanode_3.ozone_overreplicated3",
+ "firstSeenTime": 1665588176616,
+ "lastSeenTime": 1665590392293,
+ "lastBcsId": 2
+ },
+ {
+ "containerId": 3,
+ "datanodeUuid": "7a457bcb-d63e-49cc-b3ff-8b22bf48d130",
+ "datanodeHost": "ozone_datanode_1.ozone_overreplicated3",
+ "firstSeenTime": 1665588176660,
+ "lastSeenTime": 1665590272289,
+ "lastBcsId": 0
+ }
+ ]
+ }
+ ]
+ },
+ "MIS_REPLICATED": {
+ "missingCount": 0,
+ "underReplicatedCount": 1,
+ "overReplicatedCount": 0,
+ "misReplicatedCount": 0,
+ "containers": [
+ {
+ "containerID": 2,
+ "containerState": "MIS_REPLICATED",
+ "unhealthySince": 1665590446222,
+ "expectedReplicaCount": 3,
+ "actualReplicaCount": 2,
+ "replicaDeltaCount": 1,
+ "reason": null,
+ "keys": 1,
+ "pipelineID": "a10ffab6-8ed5-414a-aaf5-79890ff3e8a1",
+ "replicas": [
+ {
+ "containerId": 2,
+ "datanodeUuid": "15526f1b-76f2-4d8f-876c-c343c94ea476",
+ "datanodeHost": "ozone_datanode_2.ozone_misreplicated2",
+ "firstSeenTime": 1665588176660,
+ "lastSeenTime": 1665590397315,
+ "lastBcsId": 2
+ },
+ {
+ "containerId": 2,
+ "datanodeUuid": "f55476ab-4687-464d-a100-1c65de4366e3",
+ "datanodeHost": "ozone_datanode_3.ozone_misreplicated2",
+ "firstSeenTime": 1665588176616,
+ "lastSeenTime": 1665590392293,
+ "lastBcsId": 2
+ },
+ {
+ "containerId": 2,
+ "datanodeUuid": "7a457bcb-d63e-49cc-b3ff-8b22bf48d130",
+ "datanodeHost": "ozone_datanode_1.ozone_misreplicated2",
+ "firstSeenTime": 1665588176660,
+ "lastSeenTime": 1665590272289,
+ "lastBcsId": 0
+ }
+ ]
+ },
+ {
+ "containerID": 3,
+ "containerState": "MIS_REPLICATED",
+ "unhealthySince": 1665590446222,
+ "expectedReplicaCount": 4,
+ "actualReplicaCount": 2,
+ "replicaDeltaCount": 2,
+ "reason": null,
+ "keys": 1,
+ "pipelineID": "a10ffab6-8ed5-414a-aaf5-79890ff3e8a1",
+ "replicas": [
+ {
+ "containerId": 3,
+ "datanodeUuid": "15526f1b-76f2-4d8f-876c-c343c94ea476",
+ "datanodeHost": "ozone_datanode_2.ozone_misreplicated3",
+ "firstSeenTime": 1665588176660,
+ "lastSeenTime": 1665590397315,
+ "lastBcsId": 2
+ },
+ {
+ "containerId": 3,
+ "datanodeUuid": "f55476ab-4687-464d-a100-1c65de4366e3",
+ "datanodeHost": "ozone_datanode_3.ozone_misreplicated3",
+ "firstSeenTime": 1665588176616,
+ "lastSeenTime": 1665590392293,
+ "lastBcsId": 2
+ },
+ {
+ "containerId": 3,
+ "datanodeUuid": "7a457bcb-d63e-49cc-b3ff-8b22bf48d130",
+ "datanodeHost": "ozone_datanode_1.ozone_misreplicated3",
+ "firstSeenTime": 1665588176660,
+ "lastSeenTime": 1665590272289,
+ "lastBcsId": 0
+ }
+ ]
+ }
+ ]
+ },
+ "ALL_REPLICAS_UNHEALTHY": {
+ "missingCount": 0,
+ "underReplicatedCount": 1,
+ "overReplicatedCount": 1,
+ "misReplicatedCount": 1,
+ "containers": [
+ {
+ "containerID": 2,
+ "containerState": "ALL_REPLICAS_UNHEALTHY",
+ "unhealthySince": 1665590446222,
+ "expectedReplicaCount": 3,
+ "actualReplicaCount": 2,
+ "replicaDeltaCount": 1,
+ "reason": null,
+ "keys": 1,
+ "pipelineID": "a10ffab6-8ed5-414a-aaf5-79890ff3e8a1",
+ "replicas": [
+ {
+ "containerId": 2,
+ "datanodeUuid": "15526f1b-76f2-4d8f-876c-c343c94ea476",
+ "datanodeHost": "ozone_datanode_2.ozone_allreplica2",
+ "firstSeenTime": 1665588176660,
+ "lastSeenTime": 1665590397315,
+ "lastBcsId": 2
+ },
+ {
+ "containerId": 2,
+ "datanodeUuid": "f55476ab-4687-464d-a100-1c65de4366e3",
+ "datanodeHost": "ozone_datanode_3.ozone_allreplica2",
+ "firstSeenTime": 1665588176616,
+ "lastSeenTime": 1665590392293,
+ "lastBcsId": 2
+ },
+ {
+ "containerId": 2,
+ "datanodeUuid": "7a457bcb-d63e-49cc-b3ff-8b22bf48d130",
+ "datanodeHost": "ozone_datanode_1.ozone_allreplica2",
+ "firstSeenTime": 1665588176660,
+ "lastSeenTime": 1665590272289,
+ "lastBcsId": 0
+ }
+ ]
+ },
+ {
+ "containerID": 3,
+ "containerState": "ALL_REPLICAS_UNHEALTHY",
+ "unhealthySince": 1665590446222,
+ "expectedReplicaCount": 4,
+ "actualReplicaCount": 2,
+ "replicaDeltaCount": 2,
+ "reason": null,
+ "keys": 1,
+ "pipelineID": "a10ffab6-8ed5-414a-aaf5-79890ff3e8a1",
+ "replicas": [
+ {
+ "containerId": 3,
+ "datanodeUuid": "15526f1b-76f2-4d8f-876c-c343c94ea476",
+ "datanodeHost": "ozone_datanode_2.ozone_allreplica3",
+ "firstSeenTime": 1665588176660,
+ "lastSeenTime": 1665590397315,
+ "lastBcsId": 2
+ },
+ {
+ "containerId": 3,
+ "datanodeUuid": "f55476ab-4687-464d-a100-1c65de4366e3",
+ "datanodeHost": "ozone_datanode_3.ozone_allreplica3",
+ "firstSeenTime": 1665588176616,
+ "lastSeenTime": 1665590392293,
+ "lastBcsId": 2
+ },
+ {
+ "containerId": 3,
+ "datanodeUuid": "7a457bcb-d63e-49cc-b3ff-8b22bf48d130",
+ "datanodeHost": "ozone_datanode_1.ozone_allreplica3",
+ "firstSeenTime": 1665588176660,
+ "lastSeenTime": 1665590272289,
+ "lastBcsId": 0
+ }
+ ]
+ }
+ ]
+ }
+
Review Comment:
Done
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/api/db.json:
##########
@@ -1260,5 +1260,334 @@
"lastUpdatedTimestamp": 1663421094507,
"lastUpdatedSeqNumber": 0
}
- ]
+ ],
+ "UNDER_REPLICATED": {
+ "missingCount": 0,
+ "underReplicatedCount": 1,
+ "overReplicatedCount": 0,
+ "misReplicatedCount": 0,
+ "containers": [
+ {
+ "containerID": 2,
+ "containerState": "UNDER_REPLICATED",
+ "unhealthySince": 1665590446222,
+ "expectedReplicaCount": 3,
+ "actualReplicaCount": 2,
+ "replicaDeltaCount": 1,
+ "reason": null,
+ "keys": 1,
+ "pipelineID": "a10ffab6-8ed5-414a-aaf5-79890ff3e8a1",
+ "replicas": [
+ {
+ "containerId": 2,
+ "datanodeUuid": "15526f1b-76f2-4d8f-876c-c343c94ea476",
+ "datanodeHost": "ozone_datanode_2.ozone_UnderReplicated2",
+ "firstSeenTime": 1665588176660,
+ "lastSeenTime": 1665590397315,
+ "lastBcsId": 2
+ },
+ {
+ "containerId": 2,
+ "datanodeUuid": "f55476ab-4687-464d-a100-1c65de4366e3",
+ "datanodeHost": "ozone_datanode_3.ozone_underreplicated2",
+ "firstSeenTime": 1665588176616,
+ "lastSeenTime": 1665590392293,
+ "lastBcsId": 2
+ },
+ {
+ "containerId": 2,
+ "datanodeUuid": "7a457bcb-d63e-49cc-b3ff-8b22bf48d130",
+ "datanodeHost": "ozone_datanode_1.ozone_underreplicated2",
+ "firstSeenTime": 1665588176660,
+ "lastSeenTime": 1665590272289,
+ "lastBcsId": 0
+ }
+ ]
+ },
+ {
+ "containerID": 3,
+ "containerState": "UNDER_REPLICATED",
+ "unhealthySince": 1665590446222,
+ "expectedReplicaCount": 4,
+ "actualReplicaCount": 2,
+ "replicaDeltaCount": 2,
+ "reason": null,
+ "keys": 1,
+ "pipelineID": "a10ffab6-8ed5-414a-aaf5-79890ff3e8a1",
+ "replicas": [
+ {
+ "containerId": 3,
+ "datanodeUuid": "15526f1b-76f2-4d8f-876c-c343c94ea476",
+ "datanodeHost": "ozone_datanode_2.ozone_underreplicated3",
+ "firstSeenTime": 1665588176660,
+ "lastSeenTime": 1665590397315,
+ "lastBcsId": 2
+ },
+ {
+ "containerId": 3,
+ "datanodeUuid": "f55476ab-4687-464d-a100-1c65de4366e3",
+ "datanodeHost": "ozone_datanode_3.ozone_underreplicated3",
+ "firstSeenTime": 1665588176616,
+ "lastSeenTime": 1665590392293,
+ "lastBcsId": 2
+ },
+ {
+ "containerId": 3,
+ "datanodeUuid": "7a457bcb-d63e-49cc-b3ff-8b22bf48d130",
+ "datanodeHost": "ozone_datanode_1.ozone_underreplicated3",
+ "firstSeenTime": 1665588176660,
+ "lastSeenTime": 1665590272289,
+ "lastBcsId": 0
+ }
+ ]
+ }
+ ]
+ },
+ "Over_REPLICATED": {
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] kerneltime commented on pull request #3837: HDDS-7248. Recon: Expand the container status page to show all unhealthy container states
Posted by GitBox <gi...@apache.org>.
kerneltime commented on PR #3837:
URL: https://github.com/apache/ozone/pull/3837#issuecomment-1281114158
cc @dombizita
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] smengcl commented on a diff in pull request #3837: HDDS-7248. Recon: Expand the container status page to show all unhealthy container states
Posted by GitBox <gi...@apache.org>.
smengcl commented on code in PR #3837:
URL: https://github.com/apache/ozone/pull/3837#discussion_r998551981
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/components/navBar/navBar.tsx:
##########
@@ -66,6 +66,11 @@ class NavBar extends React.Component<INavBarProps> {
<span>Pipelines</span>
<Link to='/Pipelines'/>
</Menu.Item>
+ <Menu.Item key='/Containers'>
+ <Icon type='container'/>
Review Comment:
What does the container icon look like?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] smengcl commented on a diff in pull request #3837: HDDS-7248. Recon: Expand the container status page to show all unhealthy container states
Posted by GitBox <gi...@apache.org>.
smengcl commented on code in PR #3837:
URL: https://github.com/apache/ozone/pull/3837#discussion_r998556899
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/missingContainers/missingContainers.tsx:
##########
@@ -172,6 +275,9 @@ interface IExpandedRowState {
interface IMissingContainersState {
loading: boolean;
dataSource: IMissingContainerResponse[];
+ udataSource: IContainerResponse[];
+ odataSource: IContainerResponse[];
+ mdataSource: IContainerResponse[];
Review Comment:
1. Add a comment clarifying that `u` stands for `underReplicated` here;
2. or use full name here?
```suggestion
udataSource: IContainerResponse[];
odataSource: IContainerResponse[];
mdataSource: IContainerResponse[];
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] smitajoshi12 commented on a diff in pull request #3837: HDDS-7248. Recon: Expand the container status page to show all unhealthy container states
Posted by GitBox <gi...@apache.org>.
smitajoshi12 commented on code in PR #3837:
URL: https://github.com/apache/ozone/pull/3837#discussion_r998095579
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/missingContainers/missingContainers.tsx:
##########
@@ -158,6 +189,294 @@ const KEY_TABLE_COLUMNS = [
}
];
+const UCOLUMNS = [
Review Comment:
I have used another REPLICATEDCOLUMNS as one columns differs Unhealthy Since.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] smengcl commented on a diff in pull request #3837: HDDS-7248. Recon: Expand the container status page to show all unhealthy container states
Posted by GitBox <gi...@apache.org>.
smengcl commented on code in PR #3837:
URL: https://github.com/apache/ozone/pull/3837#discussion_r998555173
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/missingContainers/missingContainers.tsx:
##########
@@ -158,6 +189,78 @@ const KEY_TABLE_COLUMNS = [
}
];
+const REPLICATEDCOLUMNS = [
Review Comment:
Maybe this name is more suitable?
```suggestion
const CONTAINER_TAB_COLUMNS = [
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] smengcl commented on a diff in pull request #3837: HDDS-7248. Recon: Expand the container status page to show all unhealthy container states
Posted by GitBox <gi...@apache.org>.
smengcl commented on code in PR #3837:
URL: https://github.com/apache/ozone/pull/3837#discussion_r998565110
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/missingContainers/missingContainers.tsx:
##########
@@ -211,8 +340,7 @@ export class MissingContainers extends React.Component<Record<string, object>, I
onShowSizeChange = (current: number, pageSize: number) => {
console.log(current, pageSize);
- };
-
+ };
Review Comment:
```suggestion
};
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] smengcl merged pull request #3837: HDDS-7248. Recon: Expand the container status page to show all unhealthy container states
Posted by GitBox <gi...@apache.org>.
smengcl merged PR #3837:
URL: https://github.com/apache/ozone/pull/3837
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] smengcl commented on a diff in pull request #3837: HDDS-7248. Recon: Expand the container status page to show all unhealthy container states
Posted by GitBox <gi...@apache.org>.
smengcl commented on code in PR #3837:
URL: https://github.com/apache/ozone/pull/3837#discussion_r999698594
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/missingContainers/missingContainers.tsx:
##########
@@ -192,16 +301,36 @@ export class MissingContainers extends React.Component<Record<string, object>, I
this.setState({
loading: true
});
- axios.get('/api/v1/containers/missing').then(response => {
- const missingContainersResponse: IMissingContainersResponse = response.data;
- const totalCount = missingContainersResponse.totalCount;
- const missingContainers: IMissingContainerResponse[] = missingContainersResponse.containers;
+
+ axios.all([
+ axios.get('/api/v1/containers/unhealthy/MISSING'),
Review Comment:
TODO: Try with docker compose cluster response.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] smitajoshi12 commented on a diff in pull request #3837: HDDS-7248. Recon: Expand the container status page to show all unhealthy container states
Posted by GitBox <gi...@apache.org>.
smitajoshi12 commented on code in PR #3837:
URL: https://github.com/apache/ozone/pull/3837#discussion_r1000230177
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/missingContainers/missingContainers.tsx:
##########
@@ -192,16 +301,36 @@ export class MissingContainers extends React.Component<Record<string, object>, I
this.setState({
loading: true
});
- axios.get('/api/v1/containers/missing').then(response => {
- const missingContainersResponse: IMissingContainersResponse = response.data;
- const totalCount = missingContainersResponse.totalCount;
- const missingContainers: IMissingContainerResponse[] = missingContainersResponse.containers;
+
+ axios.all([
+ axios.get('/api/v1/containers/unhealthy/MISSING'),
Review Comment:
Tried with Docker Cluster Response but not getting actual response.
http://localhost:9888/api/v1/containers/unhealthy/MISSING
{"missingCount":0,"underReplicatedCount":1,"overReplicatedCount":0,"misReplicatedCount":0,"containers":[]}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] smitajoshi12 commented on a diff in pull request #3837: HDDS-7248. Recon: Expand the container status page to show all unhealthy container states
Posted by GitBox <gi...@apache.org>.
smitajoshi12 commented on code in PR #3837:
URL: https://github.com/apache/ozone/pull/3837#discussion_r999449702
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/missingContainers/missingContainers.tsx:
##########
@@ -158,6 +189,78 @@ const KEY_TABLE_COLUMNS = [
}
];
+const REPLICATEDCOLUMNS = [
Review Comment:
Changes Completed.
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/missingContainers/missingContainers.tsx:
##########
@@ -172,6 +275,9 @@ interface IExpandedRowState {
interface IMissingContainersState {
loading: boolean;
dataSource: IMissingContainerResponse[];
+ udataSource: IContainerResponse[];
+ odataSource: IContainerResponse[];
+ mdataSource: IContainerResponse[];
Review Comment:
Changes Completed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] smengcl commented on a diff in pull request #3837: HDDS-7248. Recon: Expand the container status page to show all unhealthy container states
Posted by GitBox <gi...@apache.org>.
smengcl commented on code in PR #3837:
URL: https://github.com/apache/ozone/pull/3837#discussion_r998549946
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/api/routes.json:
##########
@@ -23,5 +23,8 @@
"/namespace/du?path=/clunky&files=true": "/clunky",
"/namespace/summary?path=*": "/metadata",
"/namespace/quota?path=*": "/quota",
- "/task/status": "/taskStatus"
+ "/task/status": "/taskStatus",
+ "/containers/unhealthy/UNDER_REPLICATED": "/UNDER_REPLICATED",
+ "/containers/unhealthy/OVER_REPLICATED": "/OVER_REPLICATED",
+ "/containers/unhealthy/MIS_REPLICATED": "/MIS_REPLICATED"
Review Comment:
```suggestion
"/containers/unhealthy/UNDER_REPLICATED": "/unhealthyUnderReplicated",
"/containers/unhealthy/OVER_REPLICATED": "/unhealthyOverReplicated",
"/containers/unhealthy/MIS_REPLICATED": "/unhealthyMisReplicated"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] smengcl commented on a diff in pull request #3837: HDDS-7248. Recon: Expand the container status page to show all unhealthy container states
Posted by GitBox <gi...@apache.org>.
smengcl commented on code in PR #3837:
URL: https://github.com/apache/ozone/pull/3837#discussion_r998552277
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/missingContainers/missingContainers.tsx:
##########
@@ -35,18 +36,48 @@ interface IMissingContainerResponse {
pipelineID: string;
}
+interface IContainerResponse {
+ containerID: number;
Review Comment:
```suggestion
containerId: number;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] smitajoshi12 commented on a diff in pull request #3837: HDDS-7248. Recon: Expand the container status page to show all unhealthy container states
Posted by GitBox <gi...@apache.org>.
smitajoshi12 commented on code in PR #3837:
URL: https://github.com/apache/ozone/pull/3837#discussion_r997756174
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/missingContainers/missingContainers.tsx:
##########
@@ -82,7 +113,7 @@ const COLUMNS = [
key: 'replicas',
render: (replicas: IContainerReplica[]) => (
<div>
- {replicas.map(replica => {
+ {replicas && replicas.map(replica => {
Review Comment:
It is standard practice to avoid undefined and empty array mapping. Just to make sure we have valid data before map.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] smengcl commented on a diff in pull request #3837: HDDS-7248. Recon: Expand the container status page to show all unhealthy container states
Posted by GitBox <gi...@apache.org>.
smengcl commented on code in PR #3837:
URL: https://github.com/apache/ozone/pull/3837#discussion_r999726148
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/missingContainers/missingContainers.tsx:
##########
@@ -35,18 +36,48 @@ interface IMissingContainerResponse {
pipelineID: string;
}
+interface IContainerResponse {
+ containerID: number;
Review Comment:
Got it. In this case let's keep the original case then
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] smengcl commented on a diff in pull request #3837: HDDS-7248. Recon: Expand the container status page to show all unhealthy container states
Posted by GitBox <gi...@apache.org>.
smengcl commented on code in PR #3837:
URL: https://github.com/apache/ozone/pull/3837#discussion_r998552498
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/missingContainers/missingContainers.tsx:
##########
@@ -35,18 +36,48 @@ interface IMissingContainerResponse {
pipelineID: string;
}
+interface IContainerResponse {
+ containerID: number;
+ containerState: string;
+ unhealthySince: string;
+ expectedReplicaCount: number;
+ actualReplicaCount: number;
+ replicaDeltaCount: number;
+ reason: string;
+ keys: number;
+ pipelineID: string;
Review Comment:
```suggestion
pipelineId: string;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] dombizita commented on a diff in pull request #3837: HDDS-7248. Recon: Expand the container status page to show all unhealthy container states
Posted by GitBox <gi...@apache.org>.
dombizita commented on code in PR #3837:
URL: https://github.com/apache/ozone/pull/3837#discussion_r999589563
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/api/routes.json:
##########
@@ -23,5 +23,9 @@
"/namespace/du?path=/clunky&files=true": "/clunky",
"/namespace/summary?path=*": "/metadata",
"/namespace/quota?path=*": "/quota",
- "/task/status": "/taskStatus"
+ "/task/status": "/taskStatus",
+ "/containers/unhealthy/UNDER_REPLICATED": "/UNDER_REPLICATED",
+ "/containers/unhealthy/OVER_REPLICATED": "/OVER_REPLICATED",
+ "/containers/unhealthy/MIS_REPLICATED": "/MIS_REPLICATED",
+ "/containers/unhealthy/ALL_REPLICAS_UNHEALTHY": "/ALL_REPLICAS_UNHEALTHY"
Review Comment:
I also mentioned that it is on line number 4, but I think it would make the code more readable if we move it the other unhealthy routes and use the `"/containers/unhealthy/MISSING": "/missingContainers"` path. See my suggestion above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] smitajoshi12 commented on a diff in pull request #3837: HDDS-7248. Recon: Expand the container status page to show all unhealthy container states
Posted by GitBox <gi...@apache.org>.
smitajoshi12 commented on code in PR #3837:
URL: https://github.com/apache/ozone/pull/3837#discussion_r998100443
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/missingContainers/missingContainers.tsx:
##########
@@ -35,18 +36,48 @@ interface IMissingContainerResponse {
pipelineID: string;
}
+interface IAllContainerResponse {
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] smitajoshi12 commented on a diff in pull request #3837: HDDS-7248. Recon: Expand the container status page to show all unhealthy container states
Posted by GitBox <gi...@apache.org>.
smitajoshi12 commented on code in PR #3837:
URL: https://github.com/apache/ozone/pull/3837#discussion_r999449118
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/missingContainers/missingContainers.tsx:
##########
@@ -192,16 +519,41 @@ export class MissingContainers extends React.Component<Record<string, object>, I
this.setState({
loading: true
});
- axios.get('/api/v1/containers/missing').then(response => {
- const missingContainersResponse: IMissingContainersResponse = response.data;
- const totalCount = missingContainersResponse.totalCount;
- const missingContainers: IMissingContainerResponse[] = missingContainersResponse.containers;
+
+ axios.all([
+ axios.get('/api/v1/containers/missing'),
+ axios.get('/api/v1/containers/unhealthy/UNDER_REPLICATED'),
+ axios.get('/api/v1/containers/unhealthy/OVER_REPLICATED'),
+ axios.get('/api/v1/containers/unhealthy/MIS_REPLICATED'),
+ axios.get('/api/v1/containers/unhealthy/ALL_REPLICAS_UNHEALTHY'),
+ ]).then(axios.spread((missingContainersResponse, underReplicatedResponse, overReplicatedResponse, misReplicatedResponse, allReplicatedResponse) => {
+
+ const missingContainersResponse1: IMissingContainersResponse = missingContainersResponse.data;
Review Comment:
Changes Completed.
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/api/routes.json:
##########
@@ -23,5 +23,8 @@
"/namespace/du?path=/clunky&files=true": "/clunky",
"/namespace/summary?path=*": "/metadata",
"/namespace/quota?path=*": "/quota",
- "/task/status": "/taskStatus"
+ "/task/status": "/taskStatus",
+ "/containers/unhealthy/UNDER_REPLICATED": "/UNDER_REPLICATED",
+ "/containers/unhealthy/OVER_REPLICATED": "/OVER_REPLICATED",
+ "/containers/unhealthy/MIS_REPLICATED": "/MIS_REPLICATED"
Review Comment:
Changes Completed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] smitajoshi12 commented on a diff in pull request #3837: HDDS-7248. Recon: Expand the container status page to show all unhealthy container states
Posted by GitBox <gi...@apache.org>.
smitajoshi12 commented on code in PR #3837:
URL: https://github.com/apache/ozone/pull/3837#discussion_r999450191
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/missingContainers/missingContainers.tsx:
##########
@@ -211,8 +340,7 @@ export class MissingContainers extends React.Component<Record<string, object>, I
onShowSizeChange = (current: number, pageSize: number) => {
console.log(current, pageSize);
- };
-
+ };
Review Comment:
Changes Completed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] smitajoshi12 commented on a diff in pull request #3837: HDDS-7248. Recon: Expand the container status page to show all unhealthy container states
Posted by GitBox <gi...@apache.org>.
smitajoshi12 commented on code in PR #3837:
URL: https://github.com/apache/ozone/pull/3837#discussion_r999448647
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/api/routes.json:
##########
@@ -23,5 +23,9 @@
"/namespace/du?path=/clunky&files=true": "/clunky",
"/namespace/summary?path=*": "/metadata",
"/namespace/quota?path=*": "/quota",
- "/task/status": "/taskStatus"
+ "/task/status": "/taskStatus",
+ "/containers/unhealthy/UNDER_REPLICATED": "/UNDER_REPLICATED",
+ "/containers/unhealthy/OVER_REPLICATED": "/OVER_REPLICATED",
+ "/containers/unhealthy/MIS_REPLICATED": "/MIS_REPLICATED",
+ "/containers/unhealthy/ALL_REPLICAS_UNHEALTHY": "/ALL_REPLICAS_UNHEALTHY"
Review Comment:
Changes Completed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] smengcl commented on a diff in pull request #3837: HDDS-7248. Recon: Expand the container status page to show all unhealthy container states
Posted by GitBox <gi...@apache.org>.
smengcl commented on code in PR #3837:
URL: https://github.com/apache/ozone/pull/3837#discussion_r999673889
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/missingContainers/missingContainers.tsx:
##########
@@ -35,18 +36,48 @@ interface IMissingContainerResponse {
pipelineID: string;
}
+interface IContainerResponse {
+ containerID: number;
+ containerState: string;
+ unhealthySince: string;
+ expectedReplicaCount: number;
+ actualReplicaCount: number;
+ replicaDeltaCount: number;
+ reason: string;
+ keys: number;
+ pipelineID: string;
Review Comment:
Got it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] smengcl commented on a diff in pull request #3837: HDDS-7248. Recon: Expand the container status page to show all unhealthy container states
Posted by GitBox <gi...@apache.org>.
smengcl commented on code in PR #3837:
URL: https://github.com/apache/ozone/pull/3837#discussion_r999725096
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/api/routes.json:
##########
@@ -23,5 +23,9 @@
"/namespace/du?path=/clunky&files=true": "/clunky",
"/namespace/summary?path=*": "/metadata",
"/namespace/quota?path=*": "/quota",
- "/task/status": "/taskStatus"
+ "/task/status": "/taskStatus",
+ "/containers/unhealthy/UNDER_REPLICATED": "/UNDER_REPLICATED",
+ "/containers/unhealthy/OVER_REPLICATED": "/OVER_REPLICATED",
+ "/containers/unhealthy/MIS_REPLICATED": "/MIS_REPLICATED",
+ "/containers/unhealthy/ALL_REPLICAS_UNHEALTHY": "/ALL_REPLICAS_UNHEALTHY"
Review Comment:
done in 23de1ecac9f98374f5d647a60b18811be02a19d1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] smitajoshi12 commented on a diff in pull request #3837: HDDS-7248. Recon: Expand the container status page to show all unhealthy container states
Posted by GitBox <gi...@apache.org>.
smitajoshi12 commented on code in PR #3837:
URL: https://github.com/apache/ozone/pull/3837#discussion_r1000223700
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/missingContainers/missingContainers.tsx:
##########
@@ -158,6 +189,294 @@ const KEY_TABLE_COLUMNS = [
}
];
+const UCOLUMNS = [
Review Comment:
Done Code Changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] smitajoshi12 commented on a diff in pull request #3837: HDDS-7248. Recon: Expand the container status page to show all unhealthy container states
Posted by GitBox <gi...@apache.org>.
smitajoshi12 commented on code in PR #3837:
URL: https://github.com/apache/ozone/pull/3837#discussion_r999438366
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/missingContainers/missingContainers.tsx:
##########
@@ -35,18 +36,48 @@ interface IMissingContainerResponse {
pipelineID: string;
}
+interface IContainerResponse {
+ containerID: number;
Review Comment:
https://github.com/apache/ozone/blob/master/hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/api/types/UnhealthyContainerMetadata.java
If we go through this Java File I can see ContainerID and PipelineID
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] smengcl commented on a diff in pull request #3837: HDDS-7248. Recon: Expand the container status page to show all unhealthy container states
Posted by GitBox <gi...@apache.org>.
smengcl commented on code in PR #3837:
URL: https://github.com/apache/ozone/pull/3837#discussion_r999698594
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/missingContainers/missingContainers.tsx:
##########
@@ -192,16 +301,36 @@ export class MissingContainers extends React.Component<Record<string, object>, I
this.setState({
loading: true
});
- axios.get('/api/v1/containers/missing').then(response => {
- const missingContainersResponse: IMissingContainersResponse = response.data;
- const totalCount = missingContainersResponse.totalCount;
- const missingContainers: IMissingContainerResponse[] = missingContainersResponse.containers;
+
+ axios.all([
+ axios.get('/api/v1/containers/unhealthy/MISSING'),
Review Comment:
TODO: Try with real docker cluster response.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] smengcl commented on a diff in pull request #3837: HDDS-7248. Recon: Expand the container status page to show all unhealthy container states
Posted by GitBox <gi...@apache.org>.
smengcl commented on code in PR #3837:
URL: https://github.com/apache/ozone/pull/3837#discussion_r1001443096
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/missingContainers/missingContainers.tsx:
##########
@@ -192,16 +301,36 @@ export class MissingContainers extends React.Component<Record<string, object>, I
this.setState({
loading: true
});
- axios.get('/api/v1/containers/missing').then(response => {
- const missingContainersResponse: IMissingContainersResponse = response.data;
- const totalCount = missingContainersResponse.totalCount;
- const missingContainers: IMissingContainerResponse[] = missingContainersResponse.containers;
+
+ axios.all([
+ axios.get('/api/v1/containers/unhealthy/MISSING'),
+ axios.get('/api/v1/containers/unhealthy/UNDER_REPLICATED'),
+ axios.get('/api/v1/containers/unhealthy/OVER_REPLICATED'),
+ axios.get('/api/v1/containers/unhealthy/MIS_REPLICATED')
Review Comment:
> Can we change this things in next JIRA I am not sure about changes and logic unless I get proper data from cluster.
Alright. Let's move the refactoring work to a follow-up JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] smengcl commented on a diff in pull request #3837: HDDS-7248. Recon: Expand the container status page to show all unhealthy container states
Posted by GitBox <gi...@apache.org>.
smengcl commented on code in PR #3837:
URL: https://github.com/apache/ozone/pull/3837#discussion_r998565110
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/missingContainers/missingContainers.tsx:
##########
@@ -211,8 +340,7 @@ export class MissingContainers extends React.Component<Record<string, object>, I
onShowSizeChange = (current: number, pageSize: number) => {
console.log(current, pageSize);
- };
-
+ };
Review Comment:
Remove the unnecessary extra whitespace; restore the newline
```suggestion
};
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org