You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "itholic (via GitHub)" <gi...@apache.org> on 2023/05/30 05:42:26 UTC
[GitHub] [spark] itholic opened a new pull request, #41376: [SPARK-43680][PS][FOLLOWUP] Fix wrong usage for `is_remote`
itholic opened a new pull request, #41376:
URL: https://github.com/apache/spark/pull/41376
### What changes were proposed in this pull request?
This PR follow up for https://github.com/apache/spark/pull/41361 to fix misusage for `is_remote` on `if` clause.
### Why are the changes needed?
To fix the wrong function call
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Manually tested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #41376: [SPARK-43680][PS][FOLLOWUP] Fix wrong usage for `is_remote`
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #41376: [SPARK-43680][PS][FOLLOWUP] Fix wrong usage for `is_remote`
URL: https://github.com/apache/spark/pull/41376
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #41376: [SPARK-43680][PS][FOLLOWUP] Fix wrong usage for `is_remote`
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #41376:
URL: https://github.com/apache/spark/pull/41376#issuecomment-1568257964
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a diff in pull request #41376: [SPARK-43680][PS][FOLLOWUP] Fix wrong usage for `is_remote`
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #41376:
URL: https://github.com/apache/spark/pull/41376#discussion_r1209799972
##########
python/pyspark/pandas/data_type_ops/null_ops.py:
##########
@@ -46,31 +46,31 @@ def pretty_name(self) -> str:
def lt(self, left: IndexOpsLike, right: Any) -> SeriesOrIndex:
_sanitize_list_like(right)
result = pyspark_column_op("__lt__")(left, right)
- if is_remote:
+ if is_remote():
# In Spark Connect, it returns None instead of False, so we manually cast it.
Review Comment:
can you update this comment too? with the jira you filed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic commented on a diff in pull request #41376: [SPARK-43680][PS][FOLLOWUP] Fix wrong usage for `is_remote`
Posted by "itholic (via GitHub)" <gi...@apache.org>.
itholic commented on code in PR #41376:
URL: https://github.com/apache/spark/pull/41376#discussion_r1210029087
##########
python/pyspark/pandas/data_type_ops/null_ops.py:
##########
@@ -46,31 +46,31 @@ def pretty_name(self) -> str:
def lt(self, left: IndexOpsLike, right: Any) -> SeriesOrIndex:
_sanitize_list_like(right)
result = pyspark_column_op("__lt__")(left, right)
- if is_remote:
+ if is_remote():
# In Spark Connect, it returns None instead of False, so we manually cast it.
Review Comment:
Updated!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org