You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andy Pang <pa...@huawei.com> on 2016/02/03 09:27:20 UTC

Review Request 43136: Support libprocess build run in aarch64 cpu.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43136/
-----------------------------------------------------------

Review request for mesos, BenjaminVW BenjaminVW, Jie Yu, and Vinod Kone.


Bugs: MESOS-4577
    https://issues.apache.org/jira/browse/MESOS-4577


Repository: mesos


Description
-------

on AArch64 architecture stack 16-byte aligned mandatory,so in libprocess achieve syscal "clone" must distinguish different cpus.


Diffs
-----

  3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp f8a4d5a 

Diff: https://reviews.apache.org/r/43136/diff/


Testing
-------

test run ok in AArch64.


Thanks,

Andy Pang


Re: Review Request 43136: Support libprocess build run in aarch64 cpu.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43136/#review117792
-----------------------------------------------------------



Bad patch!

Reviews applied: [43136]

Failed command: ./support/apply-review.sh -n -r 43136

Error:
2016-02-04 10:52:41 URL:https://reviews.apache.org/r/43136/diff/raw/ [1711/1711] -> "43136.patch" [1]
Total errors found: 0
Checking 2 files
ERROR: Commit spanning multiple projects.

Please use separate commits for mesos, libprocess and stout.

Paths grouped by project:
mesos:
  src/tests/containerizer/routing_tests.cpp
stout:
  3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp

Full log: https://builds.apache.org/job/mesos-reviewbot/11238/console

- Mesos ReviewBot


On Feb. 4, 2016, 8:56 a.m., Andy Pang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43136/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2016, 8:56 a.m.)
> 
> 
> Review request for mesos, BenjaminVW BenjaminVW, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-4577
>     https://issues.apache.org/jira/browse/MESOS-4577
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Support libprocess build run in aarch64 cpu.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp f8a4d5ae12cfc2d2bd4a24226e200e1aabe0b8a8 
>   src/tests/containerizer/routing_tests.cpp 4ebb01213ce20f954c2633df95e898cf66a2d9e9 
> 
> Diff: https://reviews.apache.org/r/43136/diff/
> 
> 
> Testing
> -------
> 
> test run ok in AArch64.
> 
> 
> Thanks,
> 
> Andy Pang
> 
>


Re: Review Request 43136: Support libprocess build run in aarch64 cpu.

Posted by Andy Pang <pa...@huawei.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43136/
-----------------------------------------------------------

(Updated 二月 4, 2016, 8:56 a.m.)


Review request for mesos, BenjaminVW BenjaminVW, Jie Yu, and Vinod Kone.


Changes
-------

split dir src/...and 3rdparty/... modify into different patches


Bugs: MESOS-4577
    https://issues.apache.org/jira/browse/MESOS-4577


Repository: mesos


Description
-------

Support libprocess build run in aarch64 cpu.


Diffs (updated)
-----

  3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp f8a4d5ae12cfc2d2bd4a24226e200e1aabe0b8a8 
  src/tests/containerizer/routing_tests.cpp 4ebb01213ce20f954c2633df95e898cf66a2d9e9 

Diff: https://reviews.apache.org/r/43136/diff/


Testing
-------

test run ok in AArch64.


Thanks,

Andy Pang


Re: Review Request 43136: Support libprocess build run in aarch64 cpu.

Posted by haosdent huang <ha...@gmail.com>.

> On Feb. 4, 2016, 7:41 a.m., haosdent huang wrote:
> > Ship It!
> 
> haosdent huang wrote:
>     You combine `src/...` and `3rdparty/...` in a same patch, usually we split them into different patches. And we have `support/hooks/pre-commit` to check this when you execute `git commit`. Do you have already run `./bootstrap` in local?
> 
> haosdent huang wrote:
>     Could you check whether `.git/hooks/pre-commit` exist in your local machine and that `reset --soft` and submit again? Usually it would execute `support/mesos_split.py` to make sure `the commits are properly split between mesos, libprocess and stout.`.
> 
> haosdent huang wrote:
>     yes, it would generate two patches finally.
> 
> Andy Pang wrote:
>     Thanks,i have modify it.
> 
> haosdent huang wrote:
>     hmm, still not correct. Let me find a example for you.

I think you could refer to https://reviews.apache.org/r/41870/diff/4#index_header and https://reviews.apache.org/r/42015/diff/1#index_header . Keep in mind `Depends On` and `Blocks` field in review board.

Usually you could do it by
```
git add 3rdparty
git commit ....
git add src
git commit ....
./support/post_review.py...
```


- haosdent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43136/#review117771
-----------------------------------------------------------


On Feb. 4, 2016, 8:56 a.m., Andy Pang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43136/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2016, 8:56 a.m.)
> 
> 
> Review request for mesos, BenjaminVW BenjaminVW, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-4577
>     https://issues.apache.org/jira/browse/MESOS-4577
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Support libprocess build run in aarch64 cpu.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp f8a4d5ae12cfc2d2bd4a24226e200e1aabe0b8a8 
>   src/tests/containerizer/routing_tests.cpp 4ebb01213ce20f954c2633df95e898cf66a2d9e9 
> 
> Diff: https://reviews.apache.org/r/43136/diff/
> 
> 
> Testing
> -------
> 
> test run ok in AArch64.
> 
> 
> Thanks,
> 
> Andy Pang
> 
>


Re: Review Request 43136: Support libprocess build run in aarch64 cpu.

Posted by haosdent huang <ha...@gmail.com>.

> On Feb. 4, 2016, 7:41 a.m., haosdent huang wrote:
> > Ship It!
> 
> haosdent huang wrote:
>     You combine `src/...` and `3rdparty/...` in a same patch, usually we split them into different patches. And we have `support/hooks/pre-commit` to check this when you execute `git commit`. Do you have already run `./bootstrap` in local?
> 
> haosdent huang wrote:
>     Could you check whether `.git/hooks/pre-commit` exist in your local machine and that `reset --soft` and submit again? Usually it would execute `support/mesos_split.py` to make sure `the commits are properly split between mesos, libprocess and stout.`.

yes, it would generate two patches finally.


- haosdent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43136/#review117771
-----------------------------------------------------------


On Feb. 4, 2016, 7:40 a.m., Andy Pang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43136/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2016, 7:40 a.m.)
> 
> 
> Review request for mesos, BenjaminVW BenjaminVW, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-4577
>     https://issues.apache.org/jira/browse/MESOS-4577
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Support libprocess build run in aarch64 cpu.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp f8a4d5ae12cfc2d2bd4a24226e200e1aabe0b8a8 
>   src/tests/containerizer/routing_tests.cpp 4ebb01213ce20f954c2633df95e898cf66a2d9e9 
> 
> Diff: https://reviews.apache.org/r/43136/diff/
> 
> 
> Testing
> -------
> 
> test run ok in AArch64.
> 
> 
> Thanks,
> 
> Andy Pang
> 
>


Re: Review Request 43136: Support libprocess build run in aarch64 cpu.

Posted by haosdent huang <ha...@gmail.com>.

> On Feb. 4, 2016, 7:41 a.m., haosdent huang wrote:
> > Ship It!

You combine `src/...` and `3rdparty/...` in a same patch, usually we split them into different patches. And we have `support/hooks/pre-commit` to check this when you execute `git commit`. Do you have already run `./bootstrap` in local?


- haosdent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43136/#review117771
-----------------------------------------------------------


On Feb. 4, 2016, 7:40 a.m., Andy Pang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43136/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2016, 7:40 a.m.)
> 
> 
> Review request for mesos, BenjaminVW BenjaminVW, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-4577
>     https://issues.apache.org/jira/browse/MESOS-4577
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Support libprocess build run in aarch64 cpu.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp f8a4d5ae12cfc2d2bd4a24226e200e1aabe0b8a8 
>   src/tests/containerizer/routing_tests.cpp 4ebb01213ce20f954c2633df95e898cf66a2d9e9 
> 
> Diff: https://reviews.apache.org/r/43136/diff/
> 
> 
> Testing
> -------
> 
> test run ok in AArch64.
> 
> 
> Thanks,
> 
> Andy Pang
> 
>


Re: Review Request 43136: Support libprocess build run in aarch64 cpu.

Posted by haosdent huang <ha...@gmail.com>.

> On Feb. 4, 2016, 7:41 a.m., haosdent huang wrote:
> > Ship It!
> 
> haosdent huang wrote:
>     You combine `src/...` and `3rdparty/...` in a same patch, usually we split them into different patches. And we have `support/hooks/pre-commit` to check this when you execute `git commit`. Do you have already run `./bootstrap` in local?
> 
> haosdent huang wrote:
>     Could you check whether `.git/hooks/pre-commit` exist in your local machine and that `reset --soft` and submit again? Usually it would execute `support/mesos_split.py` to make sure `the commits are properly split between mesos, libprocess and stout.`.
> 
> haosdent huang wrote:
>     yes, it would generate two patches finally.
> 
> Andy Pang wrote:
>     Thanks,i have modify it.

hmm, still not correct. Let me find a example for you.


- haosdent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43136/#review117771
-----------------------------------------------------------


On Feb. 4, 2016, 8:56 a.m., Andy Pang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43136/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2016, 8:56 a.m.)
> 
> 
> Review request for mesos, BenjaminVW BenjaminVW, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-4577
>     https://issues.apache.org/jira/browse/MESOS-4577
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Support libprocess build run in aarch64 cpu.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp f8a4d5ae12cfc2d2bd4a24226e200e1aabe0b8a8 
>   src/tests/containerizer/routing_tests.cpp 4ebb01213ce20f954c2633df95e898cf66a2d9e9 
> 
> Diff: https://reviews.apache.org/r/43136/diff/
> 
> 
> Testing
> -------
> 
> test run ok in AArch64.
> 
> 
> Thanks,
> 
> Andy Pang
> 
>


Re: Review Request 43136: Support libprocess build run in aarch64 cpu.

Posted by Andy Pang <pa...@huawei.com>.

> On 二月 4, 2016, 7:41 a.m., haosdent huang wrote:
> > Ship It!
> 
> haosdent huang wrote:
>     You combine `src/...` and `3rdparty/...` in a same patch, usually we split them into different patches. And we have `support/hooks/pre-commit` to check this when you execute `git commit`. Do you have already run `./bootstrap` in local?
> 
> haosdent huang wrote:
>     Could you check whether `.git/hooks/pre-commit` exist in your local machine and that `reset --soft` and submit again? Usually it would execute `support/mesos_split.py` to make sure `the commits are properly split between mesos, libprocess and stout.`.
> 
> haosdent huang wrote:
>     yes, it would generate two patches finally.

Thanks,i have modify it.


- Andy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43136/#review117771
-----------------------------------------------------------


On 二月 4, 2016, 8:56 a.m., Andy Pang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43136/
> -----------------------------------------------------------
> 
> (Updated 二月 4, 2016, 8:56 a.m.)
> 
> 
> Review request for mesos, BenjaminVW BenjaminVW, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-4577
>     https://issues.apache.org/jira/browse/MESOS-4577
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Support libprocess build run in aarch64 cpu.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp f8a4d5ae12cfc2d2bd4a24226e200e1aabe0b8a8 
>   src/tests/containerizer/routing_tests.cpp 4ebb01213ce20f954c2633df95e898cf66a2d9e9 
> 
> Diff: https://reviews.apache.org/r/43136/diff/
> 
> 
> Testing
> -------
> 
> test run ok in AArch64.
> 
> 
> Thanks,
> 
> Andy Pang
> 
>


Re: Review Request 43136: Support libprocess build run in aarch64 cpu.

Posted by haosdent huang <ha...@gmail.com>.

> On Feb. 4, 2016, 7:41 a.m., haosdent huang wrote:
> > Ship It!
> 
> haosdent huang wrote:
>     You combine `src/...` and `3rdparty/...` in a same patch, usually we split them into different patches. And we have `support/hooks/pre-commit` to check this when you execute `git commit`. Do you have already run `./bootstrap` in local?

Could you check whether `.git/hooks/pre-commit` exist in your local machine and that `reset --soft` and submit again? Usually it would execute `support/mesos_split.py` to make sure `the commits are properly split between mesos, libprocess and stout.`.


- haosdent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43136/#review117771
-----------------------------------------------------------


On Feb. 4, 2016, 7:40 a.m., Andy Pang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43136/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2016, 7:40 a.m.)
> 
> 
> Review request for mesos, BenjaminVW BenjaminVW, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-4577
>     https://issues.apache.org/jira/browse/MESOS-4577
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Support libprocess build run in aarch64 cpu.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp f8a4d5ae12cfc2d2bd4a24226e200e1aabe0b8a8 
>   src/tests/containerizer/routing_tests.cpp 4ebb01213ce20f954c2633df95e898cf66a2d9e9 
> 
> Diff: https://reviews.apache.org/r/43136/diff/
> 
> 
> Testing
> -------
> 
> test run ok in AArch64.
> 
> 
> Thanks,
> 
> Andy Pang
> 
>


Re: Review Request 43136: Support libprocess build run in aarch64 cpu.

Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43136/#review117771
-----------------------------------------------------------


Ship it!




Ship It!

- haosdent huang


On Feb. 4, 2016, 7:40 a.m., Andy Pang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43136/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2016, 7:40 a.m.)
> 
> 
> Review request for mesos, BenjaminVW BenjaminVW, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-4577
>     https://issues.apache.org/jira/browse/MESOS-4577
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Support libprocess build run in aarch64 cpu.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp f8a4d5ae12cfc2d2bd4a24226e200e1aabe0b8a8 
>   src/tests/containerizer/routing_tests.cpp 4ebb01213ce20f954c2633df95e898cf66a2d9e9 
> 
> Diff: https://reviews.apache.org/r/43136/diff/
> 
> 
> Testing
> -------
> 
> test run ok in AArch64.
> 
> 
> Thanks,
> 
> Andy Pang
> 
>


Re: Review Request 43136: Support libprocess build run in aarch64 cpu.

Posted by Andy Pang <pa...@huawei.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43136/
-----------------------------------------------------------

(Updated 二月 4, 2016, 7:40 a.m.)


Review request for mesos, BenjaminVW BenjaminVW, Jie Yu, and Vinod Kone.


Changes
-------

Add routing_tests.cpp support aarch64 cpu.


Bugs: MESOS-4577
    https://issues.apache.org/jira/browse/MESOS-4577


Repository: mesos


Description (updated)
-------

Support libprocess build run in aarch64 cpu.


Diffs (updated)
-----

  3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp f8a4d5ae12cfc2d2bd4a24226e200e1aabe0b8a8 
  src/tests/containerizer/routing_tests.cpp 4ebb01213ce20f954c2633df95e898cf66a2d9e9 

Diff: https://reviews.apache.org/r/43136/diff/


Testing
-------

test run ok in AArch64.


Thanks,

Andy Pang


Re: Review Request 43136: Support libprocess build run in aarch64 cpu.

Posted by Andy Pang <pa...@huawei.com>.

> On 二月 3, 2016, 8:43 a.m., haosdent huang wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp, line 71
> > <https://reviews.apache.org/r/43136/diff/1/?file=1230818#file1230818line71>
> >
> >     Do we also need fix similar ::clone syscall in routing_tests.cpp?
> >     ```
> >     TEST_F(RoutingVethTest, ROOT_LinkCreatePid)
> >     {
> >       // Stack used in the child process.
> >       unsigned long long stack[32];
> >     
> >       pid_t pid = ::clone(child, &stack[31], CLONE_NEWNET | SIGCHLD, NULL);
> >     ```

Add routing_tests.cpp support aarch64 cpu.


- Andy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43136/#review117595
-----------------------------------------------------------


On 二月 4, 2016, 7:40 a.m., Andy Pang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43136/
> -----------------------------------------------------------
> 
> (Updated 二月 4, 2016, 7:40 a.m.)
> 
> 
> Review request for mesos, BenjaminVW BenjaminVW, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-4577
>     https://issues.apache.org/jira/browse/MESOS-4577
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Support libprocess build run in aarch64 cpu.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp f8a4d5ae12cfc2d2bd4a24226e200e1aabe0b8a8 
>   src/tests/containerizer/routing_tests.cpp 4ebb01213ce20f954c2633df95e898cf66a2d9e9 
> 
> Diff: https://reviews.apache.org/r/43136/diff/
> 
> 
> Testing
> -------
> 
> test run ok in AArch64.
> 
> 
> Thanks,
> 
> Andy Pang
> 
>


Re: Review Request 43136: Support libprocess build run in aarch64 cpu.

Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43136/#review117595
-----------------------------------------------------------




3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp (line 71)
<https://reviews.apache.org/r/43136/#comment178837>

    Do we also need fix similar ::clone syscall in routing_tests.cpp?
    ```
    TEST_F(RoutingVethTest, ROOT_LinkCreatePid)
    {
      // Stack used in the child process.
      unsigned long long stack[32];
    
      pid_t pid = ::clone(child, &stack[31], CLONE_NEWNET | SIGCHLD, NULL);
    ```


- haosdent huang


On Feb. 3, 2016, 8:27 a.m., Andy Pang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43136/
> -----------------------------------------------------------
> 
> (Updated Feb. 3, 2016, 8:27 a.m.)
> 
> 
> Review request for mesos, BenjaminVW BenjaminVW, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-4577
>     https://issues.apache.org/jira/browse/MESOS-4577
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> on AArch64 architecture stack 16-byte aligned mandatory,so in libprocess achieve syscal "clone" must distinguish different cpus.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp f8a4d5a 
> 
> Diff: https://reviews.apache.org/r/43136/diff/
> 
> 
> Testing
> -------
> 
> test run ok in AArch64.
> 
> 
> Thanks,
> 
> Andy Pang
> 
>


Re: Review Request 43136: Support libprocess build run in aarch64 cpu.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43136/#review117605
-----------------------------------------------------------



Patch looks great!

Reviews applied: [43136]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 3, 2016, 8:27 a.m., Andy Pang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43136/
> -----------------------------------------------------------
> 
> (Updated Feb. 3, 2016, 8:27 a.m.)
> 
> 
> Review request for mesos, BenjaminVW BenjaminVW, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-4577
>     https://issues.apache.org/jira/browse/MESOS-4577
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> on AArch64 architecture stack 16-byte aligned mandatory,so in libprocess achieve syscal "clone" must distinguish different cpus.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp f8a4d5a 
> 
> Diff: https://reviews.apache.org/r/43136/diff/
> 
> 
> Testing
> -------
> 
> test run ok in AArch64.
> 
> 
> Thanks,
> 
> Andy Pang
> 
>