You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2019/11/04 02:15:02 UTC

[GitHub] [incubator-iotdb] jt2594838 commented on a change in pull request #506: [IOTDB-259] level query of path

jt2594838 commented on a change in pull request #506: [IOTDB-259] level query of path
URL: https://github.com/apache/incubator-iotdb/pull/506#discussion_r341889647
 
 

 ##########
 File path: service-rpc/src/main/thrift/rpc.thrift
 ##########
 @@ -184,6 +184,7 @@ struct TSFetchMetadataResp{
 		8: optional set<string> devices
 		9: optional list<string> nodesList
 		10: optional map<string, string> nodeTimeseriesNum
+		11: optional set<string> childPaths
 
 Review comment:
   It is not much related to this PR, but seeing this, I think maybe we should break down this Resp into several smaller ones so that it is more clear what it responds to.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services