You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "xuxin930 (via GitHub)" <gi...@apache.org> on 2024/11/02 17:50:01 UTC
[PR] cmake(bugfix):fix ymodem cmake typo error and sotest build error [nuttx-apps]
xuxin930 opened a new pull request, #2815:
URL: https://github.com/apache/nuttx-apps/pull/2815
## Summary
1. fix ymodem typo
2. implement cmake sotest when kernel build does not support yet
## Impact
No
## Testing
CI test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] cmake(bugfix):fix ymodem cmake typo error and sotest build error [nuttx-apps]
Posted by "cederom (via GitHub)" <gi...@apache.org>.
cederom commented on PR #2815:
URL: https://github.com/apache/nuttx-apps/pull/2815#issuecomment-2453120128
Hmm
```
====================================================================================
Configuration/Tool: omnibusf4/nsh,CONFIG_ARM_TOOLCHAIN_CLANG
2024-11-02 18:32:08
------------------------------------------------------------------------------------
Cleaning...
Configuring...
Disabling CONFIG_ARM_TOOLCHAIN_GNU_EABI
Enabling CONFIG_ARM_TOOLCHAIN_CLANG
Building NuttX...
Error: mtd/sector512.c:554:19: error: incomplete definition of type 'struct partition_info_s'
554 | info->numsectors = priv->neblocks * priv->stdperblock;
| ~~~~^
mtd/sector512.c:550:22: note: forward declaration of 'struct partition_info_s'
550 | FAR struct partition_info_s *info =
| ^
Error: mtd/sector512.c:555:19: error: incomplete definition of type 'struct partition_info_s'
555 | info->sectorsize = SECTOR_512;
| ~~~~^
mtd/sector512.c:550:22: note: forward declaration of 'struct partition_info_s'
550 | FAR struct partition_info_s *info =
| ^
Error: mtd/sector512.c:556:19: error: incomplete definition of type 'struct partition_info_s'
556 | info->startsector = 0;
| ~~~~^
mtd/sector512.c:550:22: note: forward declaration of 'struct partition_info_s'
550 | FAR struct partition_info_s *info =
| ^
Error: mtd/sector512.c:557:19: error: incomplete definition of type 'struct partition_info_s'
557 | info->parent[0] = '\0';
| ~~~~^
mtd/sector512.c:550:22: note: forward declaration of 'struct partition_info_s'
550 | FAR struct partition_info_s *info =
| ^
4 errors generated.
make[1]: *** [Makefile:107: sector512.o] Error 1
Error: video/max7456.c:772:7: error: call to undeclared function 'up_udelay'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
772 | up_udelay(100);
| ^
Error: video/max7456.c:805:7: error: call to undeclared function 'up_udelay'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
805 | up_udelay(10);
| ^
2 errors generated.
make[1]: *** [Makefile:107: max7456.o] Error 1
make[1]: Target 'libdrivers.a' not remade because of errors.
make: *** [tools/LibTargets.mk:107: drivers/libdrivers.a] Error 2
Warning: chip/stm32_gpio.c:41:11: warning: CONFIG_STM32_USE_LEGACY_PINMAP will be deprecated migrate board.h see tools/stm32_pinmap_tool.py [-W#pragma-messages]
41 | # pragma message "CONFIG_STM32_USE_LEGACY_PINMAP will be deprecated migrate board.h see tools/stm32_pinmap_tool.py"
| ^
1 warning generated.
make: Target 'all' not remade because of errors.
/github/workspace/sources/nuttx/tools/testbuild.sh: line 385: /github/workspace/sources/nuttx/../nuttx/nuttx.manifest: No such file or directory
Normalize omnibusf4/nsh
====================================================================================
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] cmake(bugfix):fix ymodem cmake typo error and sotest build error [nuttx-apps]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #2815:
URL: https://github.com/apache/nuttx-apps/pull/2815
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] cmake(bugfix):fix ymodem cmake typo error and sotest build error [nuttx-apps]
Posted by "nuttxpr (via GitHub)" <gi...@apache.org>.
nuttxpr commented on PR #2815:
URL: https://github.com/apache/nuttx-apps/pull/2815#issuecomment-2453063219
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues)
No. The PR description lacks crucial details required by the NuttX guidelines.
Here's why:
* **Summary:** While it mentions a typo fix and CMake implementation, it doesn't explain *what* the typo was or *how* the CMake implementation works. It needs more context. What part of ymodem had a typo? What exactly does "when kernel build does not support yet" mean? Which kernels are affected?
* **Impact:** Simply saying "No" is insufficient. Each impact item (user, build, hardware, documentation, security, compatibility) needs to be addressed individually with "NO" or "YES" followed by an explanation if "YES." Even if there's no impact, explicitly stating "NO" for each item demonstrates that the contributor considered the potential impacts.
* **Testing:** "CI test" is too vague. The guidelines require specific details about the build host and target environment(s) used for testing. Additionally, providing "before" and "after" logs, even if they seem trivial for a typo fix, is essential for demonstrating the change's effect. Which CI test? What platform is it running on?
In short, the PR author needs to provide substantially more information to meet the NuttX requirements.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] cmake(bugfix):fix ymodem cmake typo error and sotest build error [nuttx-apps]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on PR #2815:
URL: https://github.com/apache/nuttx-apps/pull/2815#issuecomment-2453251218
Fix here: https://github.com/apache/nuttx/pull/14609
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org