You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/02/16 18:25:11 UTC

[GitHub] [superset] samtfm commented on pull request #13144: feat: Add error pages

samtfm commented on pull request #13144:
URL: https://github.com/apache/superset/pull/13144#issuecomment-780030805


   Thanks all. Copying the css into the two files sounds good. I'd also propose I move the referenced image files into this static-pages directory.
   
   I'm a little wary of the legibility of embedding images as base64 if these aren't going to be auto-generated, but I suppose I could still include the source files in the same folder, and include the steps for updating the html in the README. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org