You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@qpid.apache.org by kw...@apache.org on 2017/01/25 07:17:48 UTC

svn commit: r1780139 - in /qpid/java/trunk: broker-core/src/main/java/org/apache/qpid/server/connection/ broker-core/src/main/java/org/apache/qpid/server/consumer/ broker-core/src/main/java/org/apache/qpid/server/logging/ broker-core/src/main/java/org/...

Author: kwall
Date: Wed Jan 25 07:17:47 2017
New Revision: 1780139

URL: http://svn.apache.org/viewvc?rev=1780139&view=rev
Log:
QPID-7633: Remove interface AMQSessionModel

Removed:
    qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/protocol/AMQSessionModel.java
Modified:
    qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/connection/SessionPrincipal.java
    qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/consumer/AbstractConsumerTarget.java
    qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/consumer/ConsumerTarget.java
    qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/logging/AbstractMessageLogger.java
    qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/logging/LogSubject.java
    qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/logging/subjects/ChannelLogSubject.java
    qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/message/MessageSource.java
    qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/model/Consumer.java
    qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/protocol/CapacityChecker.java
    qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/queue/AbstractQueue.java
    qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/queue/QueueConsumerImpl.java
    qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/session/AMQPSession.java
    qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/transport/AMQPConnection.java
    qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/txn/DistributedTransaction.java
    qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/txn/DtxBranch.java
    qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/txn/DtxRegistry.java
    qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/virtualhost/AbstractSystemMessageSource.java
    qpid/java/trunk/broker-core/src/test/java/org/apache/qpid/server/consumer/TestConsumerTarget.java
    qpid/java/trunk/broker-core/src/test/java/org/apache/qpid/server/logging/subjects/ChannelLogSubjectTest.java
    qpid/java/trunk/broker-core/src/test/java/org/apache/qpid/server/model/BrokerTestHelper.java
    qpid/java/trunk/broker-core/src/test/java/org/apache/qpid/server/queue/AbstractQueueTestBase.java
    qpid/java/trunk/broker-plugins/amqp-0-10-protocol/src/main/java/org/apache/qpid/server/protocol/v0_10/AMQPConnection_0_10Impl.java
    qpid/java/trunk/broker-plugins/amqp-0-10-protocol/src/main/java/org/apache/qpid/server/protocol/v0_10/ServerConnection.java
    qpid/java/trunk/broker-plugins/amqp-0-10-protocol/src/main/java/org/apache/qpid/server/protocol/v0_10/Session_0_10.java
    qpid/java/trunk/broker-plugins/amqp-0-8-protocol/src/main/java/org/apache/qpid/server/protocol/v0_8/AMQChannel.java
    qpid/java/trunk/broker-plugins/amqp-0-8-protocol/src/main/java/org/apache/qpid/server/protocol/v0_8/AMQPConnection_0_8Impl.java
    qpid/java/trunk/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/AMQPConnection_1_0Impl.java
    qpid/java/trunk/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/Session_1_0.java
    qpid/java/trunk/broker-plugins/management-amqp/src/main/java/org/apache/qpid/server/management/amqp/ManagementAddressSpace.java
    qpid/java/trunk/broker-plugins/management-amqp/src/main/java/org/apache/qpid/server/management/amqp/ManagementNode.java
    qpid/java/trunk/broker-plugins/management-amqp/src/main/java/org/apache/qpid/server/management/amqp/ManagementNodeConsumer.java
    qpid/java/trunk/broker-plugins/management-amqp/src/main/java/org/apache/qpid/server/management/amqp/ProxyMessageSource.java
    qpid/java/trunk/systests/src/test/java/org/apache/qpid/server/store/VirtualHostMessageStoreTest.java

Modified: qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/connection/SessionPrincipal.java
URL: http://svn.apache.org/viewvc/qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/connection/SessionPrincipal.java?rev=1780139&r1=1780138&r2=1780139&view=diff
==============================================================================
--- qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/connection/SessionPrincipal.java (original)
+++ qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/connection/SessionPrincipal.java Wed Jan 25 07:17:47 2017
@@ -20,23 +20,23 @@
  */
 package org.apache.qpid.server.connection;
 
-import org.apache.qpid.server.protocol.AMQSessionModel;
-
 import java.io.Serializable;
 import java.security.Principal;
 
+import org.apache.qpid.server.session.AMQPSession;
+
 public class SessionPrincipal implements Principal, Serializable
 {
     private static final long serialVersionUID = 1L;
 
-    private final AMQSessionModel _session;
+    private final AMQPSession<?,?> _session;
 
-    public SessionPrincipal(final AMQSessionModel session)
+    public SessionPrincipal(final AMQPSession<?, ?> session)
     {
         _session = session;
     }
 
-    public AMQSessionModel getSession()
+    public AMQPSession<?, ?> getSession()
     {
         return _session;
     }

Modified: qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/consumer/AbstractConsumerTarget.java
URL: http://svn.apache.org/viewvc/qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/consumer/AbstractConsumerTarget.java?rev=1780139&r1=1780138&r2=1780139&view=diff
==============================================================================
--- qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/consumer/AbstractConsumerTarget.java (original)
+++ qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/consumer/AbstractConsumerTarget.java Wed Jan 25 07:17:47 2017
@@ -35,9 +35,9 @@ import org.apache.qpid.server.logging.me
 import org.apache.qpid.server.message.MessageInstance;
 import org.apache.qpid.server.message.MessageInstanceConsumer;
 import org.apache.qpid.server.model.Consumer;
-import org.apache.qpid.server.protocol.AMQSessionModel;
 import org.apache.qpid.server.message.MessageContainer;
 import org.apache.qpid.server.queue.SuspendedConsumerLoggingTicker;
+import org.apache.qpid.server.session.AMQPSession;
 import org.apache.qpid.server.transport.AMQPConnection;
 
 public abstract class AbstractConsumerTarget<T extends AbstractConsumerTarget<T>> implements ConsumerTarget<T>
@@ -172,8 +172,7 @@ public abstract class AbstractConsumerTa
 
     private ListenableFuture<Void> doOnIoThreadAsync(final Runnable task)
     {
-        AMQSessionModel<?,T> sessionModel = getSessionModel();
-        return sessionModel.getAMQPConnection().doOnIOThreadAsync(task);
+        return getSessionModel().getAMQPConnection().doOnIOThreadAsync(task);
     }
 
     private void consumerRemovedInternal(final MessageInstanceConsumer sub)

Modified: qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/consumer/ConsumerTarget.java
URL: http://svn.apache.org/viewvc/qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/consumer/ConsumerTarget.java?rev=1780139&r1=1780138&r2=1780139&view=diff
==============================================================================
--- qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/consumer/ConsumerTarget.java (original)
+++ qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/consumer/ConsumerTarget.java Wed Jan 25 07:17:47 2017
@@ -25,7 +25,7 @@ import com.google.common.util.concurrent
 import org.apache.qpid.server.message.MessageInstance;
 import org.apache.qpid.server.message.MessageInstanceConsumer;
 import org.apache.qpid.server.message.ServerMessage;
-import org.apache.qpid.server.protocol.AMQSessionModel;
+import org.apache.qpid.server.session.AMQPSession;
 
 public interface ConsumerTarget<T extends ConsumerTarget<T>>
 {
@@ -58,7 +58,7 @@ public interface ConsumerTarget<T extend
 
     long getUnacknowledgedMessages();
 
-    AMQSessionModel<?,T> getSessionModel();
+    AMQPSession<?,T> getSessionModel();
 
     void send(final MessageInstanceConsumer<T> consumer, MessageInstance entry, boolean batch);
 

Modified: qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/logging/AbstractMessageLogger.java
URL: http://svn.apache.org/viewvc/qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/logging/AbstractMessageLogger.java?rev=1780139&r1=1780138&r2=1780139&view=diff
==============================================================================
--- qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/logging/AbstractMessageLogger.java (original)
+++ qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/logging/AbstractMessageLogger.java Wed Jan 25 07:17:47 2017
@@ -36,10 +36,10 @@ import javax.security.auth.Subject;
 import org.apache.qpid.server.connection.ConnectionPrincipal;
 import org.apache.qpid.server.connection.SessionPrincipal;
 import org.apache.qpid.server.logging.subjects.LogSubjectFormat;
-import org.apache.qpid.server.protocol.AMQSessionModel;
 import org.apache.qpid.server.security.auth.AuthenticatedPrincipal;
 import org.apache.qpid.server.security.auth.ManagementConnectionPrincipal;
 import org.apache.qpid.server.security.auth.TaskPrincipal;
+import org.apache.qpid.server.session.AMQPSession;
 import org.apache.qpid.server.transport.AMQPConnection;
 
 public abstract class AbstractMessageLogger implements MessageLogger
@@ -197,7 +197,7 @@ public abstract class AbstractMessageLog
         }
     }
 
-    protected String generateSessionMessage(final AMQSessionModel session)
+    protected String generateSessionMessage(final AMQPSession session)
     {
         AMQPConnection<?> connection = session.getAMQPConnection();
         return "[" + MessageFormat.format(CHANNEL_FORMAT, connection == null ? -1L : connection.getConnectionId(),

Modified: qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/logging/LogSubject.java
URL: http://svn.apache.org/viewvc/qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/logging/LogSubject.java?rev=1780139&r1=1780138&r2=1780139&view=diff
==============================================================================
--- qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/logging/LogSubject.java (original)
+++ qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/logging/LogSubject.java Wed Jan 25 07:17:47 2017
@@ -32,5 +32,5 @@ public interface LogSubject
      *
      * @return String the display representation of this LogSubject
      */
-    public String toLogString();
+    String toLogString();
 }
\ No newline at end of file

Modified: qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/logging/subjects/ChannelLogSubject.java
URL: http://svn.apache.org/viewvc/qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/logging/subjects/ChannelLogSubject.java?rev=1780139&r1=1780138&r2=1780139&view=diff
==============================================================================
--- qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/logging/subjects/ChannelLogSubject.java (original)
+++ qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/logging/subjects/ChannelLogSubject.java Wed Jan 25 07:17:47 2017
@@ -22,13 +22,13 @@ package org.apache.qpid.server.logging.s
 
 import static org.apache.qpid.server.logging.subjects.LogSubjectFormat.CHANNEL_FORMAT;
 
-import org.apache.qpid.server.protocol.AMQSessionModel;
+import org.apache.qpid.server.session.AMQPSession;
 import org.apache.qpid.server.transport.AMQPConnection;
 
 public class ChannelLogSubject extends AbstractLogSubject
 {
-    private final AMQSessionModel<?,?> _sessionModel;
-    public ChannelLogSubject(AMQSessionModel session)
+    private final AMQPSession<?,?> _sessionModel;
+    public ChannelLogSubject(AMQPSession<?,?> session)
     {
         _sessionModel = session;
         updateSessionDetails();

Modified: qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/message/MessageSource.java
URL: http://svn.apache.org/viewvc/qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/message/MessageSource.java?rev=1780139&r1=1780138&r2=1780139&view=diff
==============================================================================
--- qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/message/MessageSource.java (original)
+++ qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/message/MessageSource.java Wed Jan 25 07:17:47 2017
@@ -26,7 +26,7 @@ import java.util.EnumSet;
 import org.apache.qpid.server.consumer.ConsumerOption;
 import org.apache.qpid.server.consumer.ConsumerTarget;
 import org.apache.qpid.server.filter.FilterManager;
-import org.apache.qpid.server.protocol.AMQSessionModel;
+import org.apache.qpid.server.session.AMQPSession;
 import org.apache.qpid.server.store.TransactionLogResource;
 
 public interface MessageSource extends TransactionLogResource, MessageNode
@@ -41,7 +41,7 @@ public interface MessageSource extends T
 
     Collection<? extends MessageInstanceConsumer> getConsumers();
 
-    boolean verifySessionAccess(AMQSessionModel<?,?> session);
+    boolean verifySessionAccess(AMQPSession<?,?> session);
 
     /**
      * ExistingExclusiveConsumer signals a failure to create a consumer, because an exclusive consumer

Modified: qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/model/Consumer.java
URL: http://svn.apache.org/viewvc/qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/model/Consumer.java?rev=1780139&r1=1780138&r2=1780139&view=diff
==============================================================================
--- qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/model/Consumer.java (original)
+++ qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/model/Consumer.java Wed Jan 25 07:17:47 2017
@@ -24,7 +24,7 @@ import java.util.concurrent.atomic.Atomi
 
 import org.apache.qpid.server.consumer.ConsumerTarget;
 import org.apache.qpid.server.message.MessageInstanceConsumer;
-import org.apache.qpid.server.protocol.AMQSessionModel;
+import org.apache.qpid.server.session.AMQPSession;
 
 @ManagedObject(creatable = false, amqpName = "org.apache.qpid.Consumer")
 public interface Consumer<X extends Consumer<X,T>, T extends ConsumerTarget> extends ConfiguredObject<X>, MessageInstanceConsumer<T>
@@ -80,7 +80,7 @@ public interface Consumer<X extends Cons
     long getUnacknowledgedMessages();
 
 
-    AMQSessionModel getSessionModel();
+    AMQPSession<?,?> getSessionModel();
 
     long getConsumerNumber();
 

Modified: qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/protocol/CapacityChecker.java
URL: http://svn.apache.org/viewvc/qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/protocol/CapacityChecker.java?rev=1780139&r1=1780138&r2=1780139&view=diff
==============================================================================
--- qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/protocol/CapacityChecker.java (original)
+++ qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/protocol/CapacityChecker.java Wed Jan 25 07:17:47 2017
@@ -20,7 +20,9 @@
  */
 package org.apache.qpid.server.protocol;
 
+import org.apache.qpid.server.session.AMQPSession;
+
 public interface CapacityChecker
 {
-    void checkCapacity(AMQSessionModel<?,?> channel);
+    void checkCapacity(AMQPSession<?,?> channel);
 }

Modified: qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/queue/AbstractQueue.java
URL: http://svn.apache.org/viewvc/qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/queue/AbstractQueue.java?rev=1780139&r1=1780138&r2=1780139&view=diff
==============================================================================
--- qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/queue/AbstractQueue.java (original)
+++ qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/queue/AbstractQueue.java Wed Jan 25 07:17:47 2017
@@ -98,11 +98,11 @@ import org.apache.qpid.server.model.pref
 import org.apache.qpid.server.plugin.MessageConverter;
 import org.apache.qpid.server.plugin.MessageFilterFactory;
 import org.apache.qpid.server.plugin.QpidServiceLoader;
-import org.apache.qpid.server.protocol.AMQSessionModel;
 import org.apache.qpid.server.protocol.MessageConverterRegistry;
 import org.apache.qpid.server.security.SecurityToken;
 import org.apache.qpid.server.security.access.Operation;
 import org.apache.qpid.server.security.auth.AuthenticatedPrincipal;
+import org.apache.qpid.server.session.AMQPSession;
 import org.apache.qpid.server.store.MessageDurability;
 import org.apache.qpid.server.store.MessageEnqueueRecord;
 import org.apache.qpid.server.store.StorableMessageMetaData;
@@ -208,7 +208,7 @@ public abstract class AbstractQueue<X ex
 
     private AtomicBoolean _stopped = new AtomicBoolean(false);
 
-    private final Set<AMQSessionModel<?,?>> _blockedChannels = Collections.newSetFromMap(new ConcurrentHashMap<AMQSessionModel<?, ?>, Boolean>());
+    private final Set<AMQPSession<?,?>> _blockedChannels = Collections.newSetFromMap(new ConcurrentHashMap<AMQPSession<?,?>, Boolean>());
 
     private final AtomicBoolean _deleted = new AtomicBoolean(false);
     private final SettableFuture<Integer> _deleteFuture = SettableFuture.create();
@@ -357,7 +357,7 @@ public abstract class AbstractQueue<X ex
         _queueHouseKeepingTask = new AdvanceConsumersTask();
         Subject activeSubject = Subject.getSubject(AccessController.getContext());
         Set<SessionPrincipal> sessionPrincipals = activeSubject == null ? Collections.<SessionPrincipal>emptySet() : activeSubject.getPrincipals(SessionPrincipal.class);
-        AMQSessionModel<?,?> sessionModel;
+        AMQPSession<?, ?> sessionModel;
         if(sessionPrincipals.isEmpty())
         {
             sessionModel = null;
@@ -1734,7 +1734,7 @@ public abstract class AbstractQueue<X ex
     }
 
     @Override
-    public void checkCapacity(AMQSessionModel<?,?> channel)
+    public void checkCapacity(AMQPSession<?,?> channel)
     {
         if(_queueFlowControlSizeBytes != 0L)
         {
@@ -1767,6 +1767,7 @@ public abstract class AbstractQueue<X ex
         }
     }
 
+    @Override
     public void checkCapacity()
     {
         if(getEntries() != null)
@@ -1783,7 +1784,7 @@ public abstract class AbstractQueue<X ex
                                                                          _queueFlowResumeSizeBytes));
                     }
 
-                    for (final AMQSessionModel<?,?> blockedChannel : _blockedChannels)
+                    for (final AMQPSession<?,?> blockedChannel : _blockedChannels)
                     {
                         blockedChannel.unblock(this);
                         _blockedChannels.remove(blockedChannel);
@@ -2587,7 +2588,7 @@ public abstract class AbstractQueue<X ex
     }
 
     @Override
-    public boolean verifySessionAccess(final AMQSessionModel<?,?> session)
+    public boolean verifySessionAccess(final AMQPSession<?,?> session)
     {
         boolean allowed;
         switch(_exclusive)
@@ -2682,7 +2683,7 @@ public abstract class AbstractQueue<X ex
             case PRINCIPAL:
             case CONTAINER:
             case CONNECTION:
-                AMQSessionModel session = null;
+                AMQPSession<?,?> session = null;
                 Iterator<QueueConsumer<?,?>> queueConsumerIterator = _queueConsumerManager.getAllIterator();
                 while(queueConsumerIterator.hasNext())
                 {
@@ -2728,7 +2729,7 @@ public abstract class AbstractQueue<X ex
                 _exclusiveOwner = con;
                 break;
             case SESSION:
-                _exclusiveOwner = _exclusiveOwner == null ? null : ((AMQSessionModel)_exclusiveOwner).getAMQPConnection();
+                _exclusiveOwner = _exclusiveOwner == null ? null : ((AMQPSession<?,?>)_exclusiveOwner).getAMQPConnection();
                 break;
             case LINK:
                 _exclusiveOwner = _exclusiveSubscriber == null ? null : _exclusiveSubscriber.getSessionModel().getAMQPConnection();
@@ -2761,7 +2762,7 @@ public abstract class AbstractQueue<X ex
                 _exclusiveOwner = _exclusiveOwner == null ? null : ((AMQPConnection)_exclusiveOwner).getRemoteContainerName();
                 break;
             case SESSION:
-                _exclusiveOwner = _exclusiveOwner == null ? null : ((AMQSessionModel)_exclusiveOwner).getAMQPConnection().getRemoteContainerName();
+                _exclusiveOwner = _exclusiveOwner == null ? null : ((AMQPSession<?,?>)_exclusiveOwner).getAMQPConnection().getRemoteContainerName();
                 break;
             case LINK:
                 _exclusiveOwner = _exclusiveSubscriber == null ? null : _exclusiveSubscriber.getSessionModel().getAMQPConnection().getRemoteContainerName();
@@ -2795,7 +2796,7 @@ public abstract class AbstractQueue<X ex
                 _exclusiveOwner = _exclusiveOwner == null ? null : ((AMQPConnection)_exclusiveOwner).getAuthorizedPrincipal();
                 break;
             case SESSION:
-                _exclusiveOwner = _exclusiveOwner == null ? null : ((AMQSessionModel)_exclusiveOwner).getAMQPConnection().getAuthorizedPrincipal();
+                _exclusiveOwner = _exclusiveOwner == null ? null : ((AMQPSession<?,?>)_exclusiveOwner).getAMQPConnection().getAuthorizedPrincipal();
                 break;
             case LINK:
                 _exclusiveOwner = _exclusiveSubscriber == null ? null : _exclusiveSubscriber.getSessionModel().getAMQPConnection().getAuthorizedPrincipal();

Modified: qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/queue/QueueConsumerImpl.java
URL: http://svn.apache.org/viewvc/qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/queue/QueueConsumerImpl.java?rev=1780139&r1=1780138&r2=1780139&view=diff
==============================================================================
--- qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/queue/QueueConsumerImpl.java (original)
+++ qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/queue/QueueConsumerImpl.java Wed Jan 25 07:17:47 2017
@@ -56,9 +56,9 @@ import org.apache.qpid.server.model.Abst
 import org.apache.qpid.server.model.LifetimePolicy;
 import org.apache.qpid.server.model.ManagedAttributeField;
 import org.apache.qpid.server.model.Queue;
-import org.apache.qpid.server.protocol.AMQSessionModel;
 import org.apache.qpid.server.protocol.MessageConverterRegistry;
 import org.apache.qpid.server.security.access.Operation;
+import org.apache.qpid.server.session.AMQPSession;
 import org.apache.qpid.server.util.StateChangeListener;
 
 class QueueConsumerImpl<T extends ConsumerTarget>
@@ -132,7 +132,7 @@ class QueueConsumerImpl<T extends Consum
         setupLogging();
     }
 
-    private static Map<String, Object> createAttributeMap(final AMQSessionModel sessionModel,
+    private static Map<String, Object> createAttributeMap(final AMQPSession<?,?> sessionModel,
                                                           String linkName,
                                                           FilterManager filters,
                                                           EnumSet<ConsumerOption> optionSet,
@@ -215,7 +215,7 @@ class QueueConsumerImpl<T extends Consum
     }
 
     @Override
-    public AMQSessionModel getSessionModel()
+    public AMQPSession<?,?> getSessionModel()
     {
         return _target.getSessionModel();
     }

Modified: qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/session/AMQPSession.java
URL: http://svn.apache.org/viewvc/qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/session/AMQPSession.java?rev=1780139&r1=1780138&r2=1780139&view=diff
==============================================================================
--- qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/session/AMQPSession.java (original)
+++ qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/session/AMQPSession.java Wed Jan 25 07:17:47 2017
@@ -20,16 +20,79 @@
  */
 package org.apache.qpid.server.session;
 
+import java.util.Collection;
+import java.util.UUID;
+
 import org.apache.qpid.server.consumer.ConsumerTarget;
 import org.apache.qpid.server.logging.EventLoggerProvider;
+import org.apache.qpid.server.logging.LogSubject;
+import org.apache.qpid.server.model.Consumer;
+import org.apache.qpid.server.model.Queue;
 import org.apache.qpid.server.model.Session;
-import org.apache.qpid.server.protocol.AMQSessionModel;
+import org.apache.qpid.server.transport.AMQPConnection;
 import org.apache.qpid.server.util.Deletable;
+import org.apache.qpid.transport.network.Ticker;
 
 public interface AMQPSession<S extends org.apache.qpid.server.session.AMQPSession<S, X>,
                              X extends ConsumerTarget<X>> extends Session<S>,
                                                                   Deletable<S>,
-                                                                  EventLoggerProvider,
-                                                                  AMQSessionModel<S, X>
+                                                                  EventLoggerProvider
 {
+    Object getConnectionReference();
+
+    int getChannelId();
+
+    AMQPConnection<?> getAMQPConnection();
+
+    LogSubject getLogSubject();
+
+    void doTimeoutAction(String reason);
+
+    void block(Queue<?> queue);
+
+    void unblock(Queue<?> queue);
+
+    void block();
+
+    void unblock();
+
+    boolean getBlocking();
+
+    int getUnacknowledgedMessageCount();
+
+    long getTxnStart();
+
+    long getTxnCommits();
+
+    long getTxnRejects();
+
+    long getConsumerCount();
+
+    Collection<Consumer<?,X>> getConsumers();
+
+    /**
+     * Return the time the current transaction started.
+     *
+     * @return the time this transaction started or 0 if not in a transaction
+     */
+    long getTransactionStartTimeLong();
+
+    /**
+     * Return the time of the last activity on the current transaction.
+     *
+     * @return the time of the last activity or 0 if not in a transaction
+     */
+    long getTransactionUpdateTimeLong();
+
+    void transportStateChanged();
+
+    boolean processPending();
+
+    void addTicker(Ticker ticker);
+
+    void removeTicker(Ticker ticker);
+
+    void notifyWork(X target);
+
+    void close();
 }

Modified: qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/transport/AMQPConnection.java
URL: http://svn.apache.org/viewvc/qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/transport/AMQPConnection.java?rev=1780139&r1=1780138&r2=1780139&view=diff
==============================================================================
--- qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/transport/AMQPConnection.java (original)
+++ qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/transport/AMQPConnection.java Wed Jan 25 07:17:47 2017
@@ -32,9 +32,7 @@ import com.google.common.util.concurrent
 import org.apache.qpid.server.logging.EventLoggerProvider;
 import org.apache.qpid.server.model.Broker;
 import org.apache.qpid.server.model.Connection;
-import org.apache.qpid.server.model.ContextProvider;
-import org.apache.qpid.server.model.NamedAddressSpace;
-import org.apache.qpid.server.protocol.AMQSessionModel;
+import org.apache.qpid.server.session.AMQPSession;
 import org.apache.qpid.server.util.Deletable;
 
 public interface AMQPConnection<C extends AMQPConnection<C>> extends Connection<C>, Deletable<C>, EventLoggerProvider
@@ -65,7 +63,7 @@ public interface AMQPConnection<C extend
 
     void registerMessageDelivered(long size);
 
-    void closeSessionAsync(AMQSessionModel<?,?> session, CloseReason reason, String message);
+    void closeSessionAsync(AMQPSession<?,?> session, CloseReason reason, String message);
 
     SocketAddress getRemoteSocketAddress();
 
@@ -101,11 +99,11 @@ public interface AMQPConnection<C extend
      *
      * @return list of sessions
      */
-    Collection<? extends AMQSessionModel<?,?>> getSessionModels();
+    Collection<? extends AMQPSession<?,?>> getSessionModels();
 
     void resetStatistics();
 
-    void notifyWork(AMQSessionModel<?,?> sessionModel);
+    void notifyWork(AMQPSession<?,?> sessionModel);
 
     boolean isTransportBlockedForWriting();
 

Modified: qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/txn/DistributedTransaction.java
URL: http://svn.apache.org/viewvc/qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/txn/DistributedTransaction.java?rev=1780139&r1=1780138&r2=1780139&view=diff
==============================================================================
--- qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/txn/DistributedTransaction.java (original)
+++ qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/txn/DistributedTransaction.java Wed Jan 25 07:17:47 2017
@@ -25,8 +25,8 @@ import java.util.Collection;
 
 import org.apache.qpid.server.message.EnqueueableMessage;
 import org.apache.qpid.server.message.MessageInstance;
-import org.apache.qpid.server.protocol.AMQSessionModel;
 import org.apache.qpid.server.queue.BaseQueue;
+import org.apache.qpid.server.session.AMQPSession;
 import org.apache.qpid.server.store.MessageEnqueueRecord;
 import org.apache.qpid.server.store.TransactionLogResource;
 import org.apache.qpid.transport.Xid;
@@ -37,11 +37,11 @@ public class DistributedTransaction impl
     private final AutoCommitTransaction _autoCommitTransaction;
 
     private DtxBranch _branch;
-    private AMQSessionModel _session;
-    private DtxRegistry _dtxRegistry;
+    private final AMQPSession<?,?> _session;
+    private final DtxRegistry _dtxRegistry;
 
 
-    public DistributedTransaction(AMQSessionModel session, DtxRegistry dtxRegistry)
+    public DistributedTransaction(AMQPSession<?,?> session, DtxRegistry dtxRegistry)
     {
         _session = session;
         _dtxRegistry = dtxRegistry;

Modified: qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/txn/DtxBranch.java
URL: http://svn.apache.org/viewvc/qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/txn/DtxBranch.java?rev=1780139&r1=1780138&r2=1780139&view=diff
==============================================================================
--- qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/txn/DtxBranch.java (original)
+++ qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/txn/DtxBranch.java Wed Jan 25 07:17:47 2017
@@ -31,7 +31,7 @@ import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
 import org.apache.qpid.server.message.EnqueueableMessage;
-import org.apache.qpid.server.protocol.AMQSessionModel;
+import org.apache.qpid.server.session.AMQPSession;
 import org.apache.qpid.server.store.MessageEnqueueRecord;
 import org.apache.qpid.server.store.StoreException;
 import org.apache.qpid.server.store.Transaction;
@@ -47,7 +47,7 @@ public class DtxBranch
     private final List<ServerTransaction.Action> _postTransactionActions = new ArrayList<ServerTransaction.Action>();
     private       State                          _state = State.ACTIVE;
     private long _timeout;
-    private Map<AMQSessionModel, State> _associatedSessions = new HashMap<AMQSessionModel, State>();
+    private Map<AMQPSession<?,?>, State> _associatedSessions = new HashMap<>();
     private final List<EnqueueRecord> _enqueueRecords = new ArrayList<>();
     private final List<DequeueRecord> _dequeueRecords = new ArrayList<>();
 
@@ -146,7 +146,7 @@ public class DtxBranch
         return _timeout != 0 && _expiration < System.currentTimeMillis();
     }
 
-    public synchronized boolean isAssociated(AMQSessionModel session)
+    public synchronized boolean isAssociated(AMQPSession<?,?> session)
     {
         return _associatedSessions.containsKey(session);
     }
@@ -177,17 +177,17 @@ public class DtxBranch
         _associatedSessions.clear();
     }
 
-    synchronized boolean associateSession(AMQSessionModel associatedSession)
+    synchronized boolean associateSession(AMQPSession<?,?> associatedSession)
     {
         return _associatedSessions.put(associatedSession, State.ACTIVE) != null;
     }
 
-    synchronized boolean disassociateSession(AMQSessionModel associatedSession)
+    synchronized boolean disassociateSession(AMQPSession<?,?> associatedSession)
     {
         return _associatedSessions.remove(associatedSession) != null;
     }
 
-    public synchronized boolean resumeSession(AMQSessionModel session)
+    public synchronized boolean resumeSession(AMQPSession<?,?> session)
     {
         if(_associatedSessions.containsKey(session) && _associatedSessions.get(session) == State.SUSPENDED)
         {
@@ -197,7 +197,7 @@ public class DtxBranch
         return false;
     }
 
-    public synchronized boolean suspendSession(AMQSessionModel session)
+    public synchronized boolean suspendSession(AMQPSession<?,?> session)
     {
         if(_associatedSessions.containsKey(session) && _associatedSessions.get(session) == State.ACTIVE)
         {

Modified: qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/txn/DtxRegistry.java
URL: http://svn.apache.org/viewvc/qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/txn/DtxRegistry.java?rev=1780139&r1=1780138&r2=1780139&view=diff
==============================================================================
--- qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/txn/DtxRegistry.java (original)
+++ qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/txn/DtxRegistry.java Wed Jan 25 07:17:47 2017
@@ -27,7 +27,7 @@ import java.util.List;
 import java.util.Map;
 import java.util.concurrent.ScheduledFuture;
 
-import org.apache.qpid.server.protocol.AMQSessionModel;
+import org.apache.qpid.server.session.AMQPSession;
 import org.apache.qpid.server.store.MessageStore;
 import org.apache.qpid.server.store.StoreException;
 import org.apache.qpid.server.virtualhost.QueueManagingVirtualHost;
@@ -328,7 +328,7 @@ public class DtxRegistry
         return inDoubt;
     }
 
-    public synchronized void endAssociations(AMQSessionModel session)
+    public synchronized void endAssociations(AMQPSession<?,?> session)
     {
         for(DtxBranch branch : _branches.values())
         {

Modified: qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/virtualhost/AbstractSystemMessageSource.java
URL: http://svn.apache.org/viewvc/qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/virtualhost/AbstractSystemMessageSource.java?rev=1780139&r1=1780138&r2=1780139&view=diff
==============================================================================
--- qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/virtualhost/AbstractSystemMessageSource.java (original)
+++ qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/virtualhost/AbstractSystemMessageSource.java Wed Jan 25 07:17:47 2017
@@ -40,8 +40,8 @@ import org.apache.qpid.server.message.Me
 import org.apache.qpid.server.message.ServerMessage;
 import org.apache.qpid.server.message.internal.InternalMessage;
 import org.apache.qpid.server.model.NamedAddressSpace;
-import org.apache.qpid.server.protocol.AMQSessionModel;
 import org.apache.qpid.server.message.MessageContainer;
+import org.apache.qpid.server.session.AMQPSession;
 import org.apache.qpid.server.store.MessageDurability;
 import org.apache.qpid.server.store.MessageEnqueueRecord;
 import org.apache.qpid.server.store.TransactionLogResource;
@@ -104,7 +104,7 @@ public abstract class AbstractSystemMess
     }
 
     @Override
-    public boolean verifySessionAccess(final AMQSessionModel<?,?> session)
+    public boolean verifySessionAccess(final AMQPSession<?,?> session)
     {
         return true;
     }

Modified: qpid/java/trunk/broker-core/src/test/java/org/apache/qpid/server/consumer/TestConsumerTarget.java
URL: http://svn.apache.org/viewvc/qpid/java/trunk/broker-core/src/test/java/org/apache/qpid/server/consumer/TestConsumerTarget.java?rev=1780139&r1=1780138&r2=1780139&view=diff
==============================================================================
--- qpid/java/trunk/broker-core/src/test/java/org/apache/qpid/server/consumer/TestConsumerTarget.java (original)
+++ qpid/java/trunk/broker-core/src/test/java/org/apache/qpid/server/consumer/TestConsumerTarget.java Wed Jan 25 07:17:47 2017
@@ -25,29 +25,17 @@ import static org.mockito.Mockito.mock;
 import static org.mockito.Mockito.when;
 
 import java.util.ArrayList;
-import java.util.Collection;
-import java.util.UUID;
 
 import com.google.common.util.concurrent.Futures;
 import com.google.common.util.concurrent.ListenableFuture;
 
-import org.apache.qpid.server.configuration.updater.CurrentThreadTaskExecutor;
-import org.apache.qpid.server.configuration.updater.TaskExecutor;
-import org.apache.qpid.server.logging.LogSubject;
+import org.apache.qpid.server.message.MessageContainer;
 import org.apache.qpid.server.message.MessageInstance;
 import org.apache.qpid.server.message.MessageInstanceConsumer;
 import org.apache.qpid.server.message.ServerMessage;
-import org.apache.qpid.server.model.BrokerModel;
-import org.apache.qpid.server.model.ConfiguredObjectFactory;
-import org.apache.qpid.server.model.ConfiguredObjectFactoryImpl;
-import org.apache.qpid.server.model.Consumer;
 import org.apache.qpid.server.model.Queue;
-import org.apache.qpid.server.model.Session;
-import org.apache.qpid.server.protocol.AMQSessionModel;
-import org.apache.qpid.server.message.MessageContainer;
+import org.apache.qpid.server.session.AMQPSession;
 import org.apache.qpid.server.transport.AMQPConnection;
-import org.apache.qpid.server.util.Action;
-import org.apache.qpid.transport.network.Ticker;
 
 public class TestConsumerTarget implements ConsumerTarget<TestConsumerTarget>
 {
@@ -56,13 +44,19 @@ public class TestConsumerTarget implemen
     private String tag = "mocktag";
     private Queue<?> queue = null;
     private State _state = State.OPEN;
-    private ArrayList<MessageInstance> _messages = new ArrayList<MessageInstance>();
+    private ArrayList<MessageInstance> _messages = new ArrayList<>();
 
     private boolean _isActive = true;
     private MessageInstanceConsumer _consumer;
-    private MockSessionModel _sessionModel = new MockSessionModel();
+    private AMQPSession _sessionModel = mock(AMQPSession.class);
     private boolean _notifyDesired;
 
+    public TestConsumerTarget()
+    {
+        when(_sessionModel.getChannelId()).thenReturn(0);
+        when(_sessionModel.getAMQPConnection()).thenReturn(mock(AMQPConnection.class));
+    }
+
     public boolean close()
     {
         _closed = true;
@@ -91,7 +85,7 @@ public class TestConsumerTarget implemen
         return queue;
     }
 
-    public AMQSessionModel getSessionModel()
+    public AMQPSession getSessionModel()
     {
         return _sessionModel;
     }
@@ -236,182 +230,4 @@ public class TestConsumerTarget implemen
             _notifyDesired = isNotifyWorkDesired();
         }
     }
-
-    private static class MockSessionModel implements AMQSessionModel<MockSessionModel, TestConsumerTarget>
-    {
-        private final UUID _id = UUID.randomUUID();
-        private Session _modelObject;
-        private AMQPConnection<?> _connection = mock(AMQPConnection.class);
-
-        private MockSessionModel()
-        {
-            _modelObject = mock(Session.class);
-            when(_modelObject.getCategoryClass()).thenReturn(Session.class);
-            ConfiguredObjectFactory factory = new ConfiguredObjectFactoryImpl(BrokerModel.getInstance());
-            when(_modelObject.getObjectFactory()).thenReturn(factory);
-            when(_modelObject.getModel()).thenReturn(factory.getModel());
-            TaskExecutor taskExecutor = CurrentThreadTaskExecutor.newStartedInstance();
-            when(_modelObject.getTaskExecutor()).thenReturn(taskExecutor);
-            when(_modelObject.getChildExecutor()).thenReturn(taskExecutor);
-        }
-
-        @Override
-        public UUID getId()
-        {
-            return _id;
-        }
-
-        @Override
-        public AMQPConnection<?> getAMQPConnection()
-        {
-            return _connection;
-        }
-
-        @Override
-        public void close()
-        {
-        }
-
-        @Override
-        public LogSubject getLogSubject()
-        {
-            return null;
-        }
-
-        @Override
-        public void doTimeoutAction(final String reason)
-        {
-        }
-
-        @Override
-        public void block(Queue<?> queue)
-        {
-        }
-
-        @Override
-        public void unblock(Queue<?> queue)
-        {
-        }
-
-        @Override
-        public void block()
-        {
-        }
-
-        @Override
-        public void unblock()
-        {
-        }
-
-        @Override
-        public boolean getBlocking()
-        {
-            return false;
-        }
-
-        @Override
-        public Object getConnectionReference()
-        {
-            return this;
-        }
-
-        @Override
-        public int getUnacknowledgedMessageCount()
-        {
-            return 0;
-        }
-
-        @Override
-        public long getTxnStart()
-        {
-            return 0L;
-        }
-
-        @Override
-        public long getTxnCommits()
-        {
-            return 0L;
-        }
-
-        @Override
-        public long getTxnRejects()
-        {
-            return 0L;
-        }
-
-        @Override
-        public int getChannelId()
-        {
-            return 0;
-        }
-
-        @Override
-        public long getConsumerCount()
-        {
-            return 0;
-        }
-
-        @Override
-        public Collection<Consumer<?,TestConsumerTarget>> getConsumers()
-        {
-            return null;
-        }
-
-        @Override
-        public long getTransactionStartTimeLong()
-        {
-            return 0;
-        }
-
-        @Override
-        public long getTransactionUpdateTimeLong()
-        {
-            return 0;
-        }
-
-        @Override
-        public void addDeleteTask(final Action task)
-        {
-
-        }
-
-        @Override
-        public void removeDeleteTask(final Action task)
-        {
-
-        }
-
-
-        @Override
-        public void transportStateChanged()
-        {
-
-        }
-
-        @Override
-        public boolean processPending()
-        {
-            return false;
-        }
-
-        @Override
-        public void addTicker(final Ticker ticker)
-        {
-
-        }
-
-        @Override
-        public void removeTicker(final Ticker ticker)
-        {
-
-        }
-
-        @Override
-        public void notifyWork(final TestConsumerTarget target)
-        {
-            _connection.notifyWork(this);
-        }
-
-    }
-
 }

Modified: qpid/java/trunk/broker-core/src/test/java/org/apache/qpid/server/logging/subjects/ChannelLogSubjectTest.java
URL: http://svn.apache.org/viewvc/qpid/java/trunk/broker-core/src/test/java/org/apache/qpid/server/logging/subjects/ChannelLogSubjectTest.java?rev=1780139&r1=1780138&r2=1780139&view=diff
==============================================================================
--- qpid/java/trunk/broker-core/src/test/java/org/apache/qpid/server/logging/subjects/ChannelLogSubjectTest.java (original)
+++ qpid/java/trunk/broker-core/src/test/java/org/apache/qpid/server/logging/subjects/ChannelLogSubjectTest.java Wed Jan 25 07:17:47 2017
@@ -20,11 +20,11 @@
  */
 package org.apache.qpid.server.logging.subjects;
 
-import org.apache.qpid.server.protocol.AMQSessionModel;
-
 import static org.mockito.Mockito.mock;
 import static org.mockito.Mockito.when;
 
+import org.apache.qpid.server.session.AMQPSession;
+
 /**
  * Validate ChannelLogSubjects are logged as expected
  */
@@ -37,7 +37,7 @@ public class ChannelLogSubjectTest exten
     {
         super.setUp();
 
-        AMQSessionModel session = mock(AMQSessionModel.class);
+        AMQPSession<?,?> session = mock(AMQPSession.class);
         when(session.getAMQPConnection()).thenReturn(getConnection());
         when(session.getChannelId()).thenReturn(_channelID);
         _subject = new ChannelLogSubject(session);

Modified: qpid/java/trunk/broker-core/src/test/java/org/apache/qpid/server/model/BrokerTestHelper.java
URL: http://svn.apache.org/viewvc/qpid/java/trunk/broker-core/src/test/java/org/apache/qpid/server/model/BrokerTestHelper.java?rev=1780139&r1=1780138&r2=1780139&view=diff
==============================================================================
--- qpid/java/trunk/broker-core/src/test/java/org/apache/qpid/server/model/BrokerTestHelper.java (original)
+++ qpid/java/trunk/broker-core/src/test/java/org/apache/qpid/server/model/BrokerTestHelper.java Wed Jan 25 07:17:47 2017
@@ -49,11 +49,11 @@ import org.apache.bcel.generic.ClassGen;
 import org.apache.qpid.server.configuration.updater.CurrentThreadTaskExecutor;
 import org.apache.qpid.server.configuration.updater.TaskExecutor;
 import org.apache.qpid.server.logging.EventLogger;
-import org.apache.qpid.server.protocol.AMQSessionModel;
 import org.apache.qpid.server.security.AccessControl;
 import org.apache.qpid.server.security.Result;
 import org.apache.qpid.server.security.SecurityToken;
 import org.apache.qpid.server.security.access.Operation;
+import org.apache.qpid.server.session.AMQPSession;
 import org.apache.qpid.server.store.DurableConfigurationStore;
 import org.apache.qpid.server.store.preferences.PreferenceStore;
 import org.apache.qpid.server.transport.AMQPConnection;
@@ -225,22 +225,22 @@ public class BrokerTestHelper
         return createVirtualHost(attributes, broker, defaultVHN, accessControl);
     }
 
-    public static AMQSessionModel<?,?> createSession(int channelId, AMQPConnection<?> connection)
+    public static AMQPSession<?,?> createSession(int channelId, AMQPConnection<?> connection)
     {
         @SuppressWarnings("rawtypes")
-        AMQSessionModel session = mock(AMQSessionModel.class);
+        AMQPSession session = mock(AMQPSession.class);
         when(session.getAMQPConnection()).thenReturn(connection);
         when(session.getChannelId()).thenReturn(channelId);
         return session;
     }
 
-    public static AMQSessionModel<?,?> createSession(int channelId) throws Exception
+    public static AMQPSession<?,?> createSession(int channelId) throws Exception
     {
         AMQPConnection<?> session = createConnection();
         return createSession(channelId, session);
     }
 
-    public static AMQSessionModel<?,?> createSession() throws Exception
+    public static AMQPSession<?,?> createSession() throws Exception
     {
         return createSession(1);
     }

Modified: qpid/java/trunk/broker-core/src/test/java/org/apache/qpid/server/queue/AbstractQueueTestBase.java
URL: http://svn.apache.org/viewvc/qpid/java/trunk/broker-core/src/test/java/org/apache/qpid/server/queue/AbstractQueueTestBase.java?rev=1780139&r1=1780138&r2=1780139&view=diff
==============================================================================
--- qpid/java/trunk/broker-core/src/test/java/org/apache/qpid/server/queue/AbstractQueueTestBase.java (original)
+++ qpid/java/trunk/broker-core/src/test/java/org/apache/qpid/server/queue/AbstractQueueTestBase.java Wed Jan 25 07:17:47 2017
@@ -79,7 +79,7 @@ abstract class AbstractQueueTestBase ext
     private String _owner = "owner";
     private String _routingKey = "routing key";
     private DirectExchangeImpl _exchange;
-    private TestConsumerTarget _consumerTarget = new TestConsumerTarget();
+    private TestConsumerTarget _consumerTarget = new TestConsumerTarget();  // TODO replace with minimally configured mockito mock
     private QueueConsumer<?,?> _consumer;
     private Map<String,Object> _arguments = Collections.emptyMap();
 

Modified: qpid/java/trunk/broker-plugins/amqp-0-10-protocol/src/main/java/org/apache/qpid/server/protocol/v0_10/AMQPConnection_0_10Impl.java
URL: http://svn.apache.org/viewvc/qpid/java/trunk/broker-plugins/amqp-0-10-protocol/src/main/java/org/apache/qpid/server/protocol/v0_10/AMQPConnection_0_10Impl.java?rev=1780139&r1=1780138&r2=1780139&view=diff
==============================================================================
--- qpid/java/trunk/broker-plugins/amqp-0-10-protocol/src/main/java/org/apache/qpid/server/protocol/v0_10/AMQPConnection_0_10Impl.java (original)
+++ qpid/java/trunk/broker-plugins/amqp-0-10-protocol/src/main/java/org/apache/qpid/server/protocol/v0_10/AMQPConnection_0_10Impl.java Wed Jan 25 07:17:47 2017
@@ -40,8 +40,8 @@ import org.apache.qpid.server.model.Brok
 import org.apache.qpid.server.model.Protocol;
 import org.apache.qpid.server.model.Transport;
 import org.apache.qpid.server.model.port.AmqpPort;
-import org.apache.qpid.server.protocol.AMQSessionModel;
 import org.apache.qpid.server.security.SubjectCreator;
+import org.apache.qpid.server.session.AMQPSession;
 import org.apache.qpid.server.store.StoreException;
 import org.apache.qpid.server.transport.AbstractAMQPConnection;
 import org.apache.qpid.server.transport.AggregateTicker;
@@ -71,8 +71,8 @@ public class AMQPConnection_0_10Impl ext
     private final AtomicReference<Action<ProtocolEngine>> _workListener = new AtomicReference<>();
     private ServerDisassembler _disassembler;
 
-    private final Set<AMQSessionModel<?,?>> _sessionsWithWork =
-            Collections.newSetFromMap(new ConcurrentHashMap<AMQSessionModel<?,?>, Boolean>());
+    private final Set<AMQPSession<?,?>> _sessionsWithWork =
+            Collections.newSetFromMap(new ConcurrentHashMap<AMQPSession<?,?>, Boolean>());
 
 
     public AMQPConnection_0_10Impl(final Broker<?> broker,
@@ -278,7 +278,7 @@ public class AMQPConnection_0_10Impl ext
     }
 
     @Override
-    public void notifyWork(final AMQSessionModel<?,?> sessionModel)
+    public void notifyWork(final AMQPSession<?,?> sessionModel)
     {
         _sessionsWithWork.add(sessionModel);
         notifyWork();
@@ -309,7 +309,7 @@ public class AMQPConnection_0_10Impl ext
     }
 
     @Override
-    public void closeSessionAsync(final AMQSessionModel<?,?> session,
+    public void closeSessionAsync(final AMQPSession<?,?> session,
                                   final CloseReason reason, final String message)
     {
         ServerSession s = ((Session_0_10)session).getServerSession();

Modified: qpid/java/trunk/broker-plugins/amqp-0-10-protocol/src/main/java/org/apache/qpid/server/protocol/v0_10/ServerConnection.java
URL: http://svn.apache.org/viewvc/qpid/java/trunk/broker-plugins/amqp-0-10-protocol/src/main/java/org/apache/qpid/server/protocol/v0_10/ServerConnection.java?rev=1780139&r1=1780138&r2=1780139&view=diff
==============================================================================
--- qpid/java/trunk/broker-plugins/amqp-0-10-protocol/src/main/java/org/apache/qpid/server/protocol/v0_10/ServerConnection.java (original)
+++ qpid/java/trunk/broker-plugins/amqp-0-10-protocol/src/main/java/org/apache/qpid/server/protocol/v0_10/ServerConnection.java Wed Jan 25 07:17:47 2017
@@ -46,8 +46,8 @@ import org.apache.qpid.server.model.Brok
 import org.apache.qpid.server.model.NamedAddressSpace;
 import org.apache.qpid.server.model.Transport;
 import org.apache.qpid.server.model.port.AmqpPort;
-import org.apache.qpid.server.protocol.AMQSessionModel;
 import org.apache.qpid.server.protocol.ConnectionClosingTicker;
+import org.apache.qpid.server.session.AMQPSession;
 import org.apache.qpid.server.transport.AMQPConnection;
 import org.apache.qpid.server.transport.ServerNetworkConnection;
 import org.apache.qpid.server.util.Action;
@@ -486,16 +486,16 @@ public class ServerConnection extends Co
         }
     }
 
-    public Iterator<Runnable> processPendingIterator(final Set<AMQSessionModel<?,?>> sessionsWithWork)
+    public Iterator<Runnable> processPendingIterator(final Set<AMQPSession<?,?>> sessionsWithWork)
     {
         return new ProcessPendingIterator(sessionsWithWork);
     }
 
     private class ProcessPendingIterator implements Iterator<Runnable>
     {
-        private final Collection<AMQSessionModel<?,?>> _sessionsWithPending;
-        private Iterator<? extends AMQSessionModel<?,?>> _sessionIterator;
-        private ProcessPendingIterator(final Set<AMQSessionModel<?,?>> sessionsWithWork)
+        private final Collection<AMQPSession<?,?>> _sessionsWithPending;
+        private Iterator<? extends AMQPSession<?,?>> _sessionIterator;
+        private ProcessPendingIterator(final Set<AMQPSession<?,?>> sessionsWithWork)
         {
             _sessionsWithPending = sessionsWithWork;
             _sessionIterator = _sessionsWithPending.iterator();
@@ -547,7 +547,7 @@ public class ServerConnection extends Co
                     {
                         _sessionIterator = _sessionsWithPending.iterator();
                     }
-                    final AMQSessionModel<?,?> session = _sessionIterator.next();
+                    final AMQPSession<?,?> session = _sessionIterator.next();
                     return new Runnable()
                     {
                         @Override

Modified: qpid/java/trunk/broker-plugins/amqp-0-10-protocol/src/main/java/org/apache/qpid/server/protocol/v0_10/Session_0_10.java
URL: http://svn.apache.org/viewvc/qpid/java/trunk/broker-plugins/amqp-0-10-protocol/src/main/java/org/apache/qpid/server/protocol/v0_10/Session_0_10.java?rev=1780139&r1=1780138&r2=1780139&view=diff
==============================================================================
--- qpid/java/trunk/broker-plugins/amqp-0-10-protocol/src/main/java/org/apache/qpid/server/protocol/v0_10/Session_0_10.java (original)
+++ qpid/java/trunk/broker-plugins/amqp-0-10-protocol/src/main/java/org/apache/qpid/server/protocol/v0_10/Session_0_10.java Wed Jan 25 07:17:47 2017
@@ -30,13 +30,12 @@ import org.apache.qpid.server.logging.Lo
 import org.apache.qpid.server.model.Connection;
 import org.apache.qpid.server.model.Consumer;
 import org.apache.qpid.server.model.Queue;
-import org.apache.qpid.server.protocol.AMQSessionModel;
 import org.apache.qpid.server.protocol.PublishAuthorisationCache;
 import org.apache.qpid.server.session.AbstractAMQPSession;
 import org.apache.qpid.server.util.Action;
 
 public class Session_0_10 extends AbstractAMQPSession<Session_0_10, ConsumerTarget_0_10>
-        implements AMQSessionModel<Session_0_10, ConsumerTarget_0_10>, LogSubject
+        implements LogSubject, org.apache.qpid.server.util.Deletable<Session_0_10>
 {
     private final AMQPConnection_0_10 _connection;
     private final ServerSession _serverSession;

Modified: qpid/java/trunk/broker-plugins/amqp-0-8-protocol/src/main/java/org/apache/qpid/server/protocol/v0_8/AMQChannel.java
URL: http://svn.apache.org/viewvc/qpid/java/trunk/broker-plugins/amqp-0-8-protocol/src/main/java/org/apache/qpid/server/protocol/v0_8/AMQChannel.java?rev=1780139&r1=1780138&r2=1780139&view=diff
==============================================================================
--- qpid/java/trunk/broker-plugins/amqp-0-8-protocol/src/main/java/org/apache/qpid/server/protocol/v0_8/AMQChannel.java (original)
+++ qpid/java/trunk/broker-plugins/amqp-0-8-protocol/src/main/java/org/apache/qpid/server/protocol/v0_8/AMQChannel.java Wed Jan 25 07:17:47 2017
@@ -67,6 +67,7 @@ import org.apache.qpid.server.filter.Fil
 import org.apache.qpid.server.filter.MessageFilter;
 import org.apache.qpid.server.logging.EventLoggerProvider;
 import org.apache.qpid.server.logging.LogMessage;
+import org.apache.qpid.server.logging.LogSubject;
 import org.apache.qpid.server.logging.messages.ChannelMessages;
 import org.apache.qpid.server.logging.messages.ExchangeMessages;
 import org.apache.qpid.server.message.InstanceProperties;
@@ -78,7 +79,6 @@ import org.apache.qpid.server.message.Me
 import org.apache.qpid.server.message.RoutingResult;
 import org.apache.qpid.server.message.ServerMessage;
 import org.apache.qpid.server.model.*;
-import org.apache.qpid.server.protocol.AMQSessionModel;
 import org.apache.qpid.server.protocol.CapacityChecker;
 import org.apache.qpid.server.protocol.v0_8.UnacknowledgedMessageMap.Visitor;
 import org.apache.qpid.server.queue.QueueArgumentsConverter;
@@ -97,12 +97,12 @@ import org.apache.qpid.server.util.Serve
 import org.apache.qpid.server.virtualhost.ExchangeIsAlternateException;
 import org.apache.qpid.server.virtualhost.RequiredExchangeException;
 import org.apache.qpid.server.virtualhost.ReservedExchangeNameException;
+import org.apache.qpid.transport.network.Ticker;
 
 public class AMQChannel extends AbstractAMQPSession<AMQChannel, ConsumerTarget_0_8>
-        implements AMQSessionModel<AMQChannel, ConsumerTarget_0_8>,
-                   AsyncAutoCommitTransaction.FutureRecorder,
+        implements AsyncAutoCommitTransaction.FutureRecorder,
                    ServerChannelMethodProcessor,
-                   EventLoggerProvider, CreditRestorer
+                   EventLoggerProvider, CreditRestorer, org.apache.qpid.server.util.Deletable<AMQChannel>
 {
     public static final int DEFAULT_PREFETCH = 4096;
 
@@ -1413,6 +1413,7 @@ public class AMQChannel extends Abstract
         {
         }
 
+        @Override
         public void performAction(MessageInstance entry)
         {
             TransactionLogResource queue = entry.getOwningResource();

Modified: qpid/java/trunk/broker-plugins/amqp-0-8-protocol/src/main/java/org/apache/qpid/server/protocol/v0_8/AMQPConnection_0_8Impl.java
URL: http://svn.apache.org/viewvc/qpid/java/trunk/broker-plugins/amqp-0-8-protocol/src/main/java/org/apache/qpid/server/protocol/v0_8/AMQPConnection_0_8Impl.java?rev=1780139&r1=1780138&r2=1780139&view=diff
==============================================================================
--- qpid/java/trunk/broker-plugins/amqp-0-8-protocol/src/main/java/org/apache/qpid/server/protocol/v0_8/AMQPConnection_0_8Impl.java (original)
+++ qpid/java/trunk/broker-plugins/amqp-0-8-protocol/src/main/java/org/apache/qpid/server/protocol/v0_8/AMQPConnection_0_8Impl.java Wed Jan 25 07:17:47 2017
@@ -63,11 +63,11 @@ import org.apache.qpid.server.model.Name
 import org.apache.qpid.server.model.Protocol;
 import org.apache.qpid.server.model.Transport;
 import org.apache.qpid.server.model.port.AmqpPort;
-import org.apache.qpid.server.protocol.AMQSessionModel;
 import org.apache.qpid.server.protocol.ConnectionClosingTicker;
 import org.apache.qpid.server.security.SubjectCreator;
 import org.apache.qpid.server.security.auth.SubjectAuthenticationResult;
 import org.apache.qpid.server.security.auth.sasl.SaslNegotiator;
+import org.apache.qpid.server.session.AMQPSession;
 import org.apache.qpid.server.store.StoreException;
 import org.apache.qpid.server.transport.AbstractAMQPConnection;
 import org.apache.qpid.server.transport.AggregateTicker;
@@ -158,8 +158,8 @@ public class AMQPConnection_0_8Impl
     private volatile boolean _transportBlockedForWriting;
     private volatile SubjectAuthenticationResult _successfulAuthenticationResult;
 
-    private final Set<AMQSessionModel<?,?>> _sessionsWithWork =
-            Collections.newSetFromMap(new ConcurrentHashMap<AMQSessionModel<?,?>, Boolean>());
+    private final Set<AMQPSession<?,?>> _sessionsWithWork =
+            Collections.newSetFromMap(new ConcurrentHashMap<AMQPSession<?,?>, Boolean>());
 
 
     public AMQPConnection_0_8Impl(Broker<?> broker,
@@ -739,7 +739,7 @@ public class AMQPConnection_0_8Impl
         return String.valueOf(getNetwork().getRemoteAddress());
     }
 
-    public void closeSessionAsync(final AMQSessionModel<?,?> session, final CloseReason reason, final String message)
+    public void closeSessionAsync(final AMQPSession<?,?> session, final CloseReason reason, final String message)
     {
         final int cause;
         switch (reason)
@@ -1354,7 +1354,7 @@ public class AMQPConnection_0_8Impl
     }
 
     @Override
-    public void notifyWork(final AMQSessionModel<?,?> sessionModel)
+    public void notifyWork(final AMQPSession<?,?> sessionModel)
     {
         _sessionsWithWork.add(sessionModel);
         notifyWork();
@@ -1384,7 +1384,7 @@ public class AMQPConnection_0_8Impl
 
     private class ProcessPendingIterator implements Iterator<Runnable>
     {
-        private Iterator<? extends AMQSessionModel<?,?>> _sessionIterator;
+        private Iterator<? extends AMQPSession<?,?>> _sessionIterator;
 
         private ProcessPendingIterator()
         {
@@ -1436,7 +1436,7 @@ public class AMQPConnection_0_8Impl
                     {
                         _sessionIterator = _sessionsWithWork.iterator();
                     }
-                    final AMQSessionModel<?,?> session = _sessionIterator.next();
+                    final AMQPSession<?,?> session = _sessionIterator.next();
                     return new Runnable()
                     {
                         @Override

Modified: qpid/java/trunk/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/AMQPConnection_1_0Impl.java
URL: http://svn.apache.org/viewvc/qpid/java/trunk/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/AMQPConnection_1_0Impl.java?rev=1780139&r1=1780138&r2=1780139&view=diff
==============================================================================
--- qpid/java/trunk/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/AMQPConnection_1_0Impl.java (original)
+++ qpid/java/trunk/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/AMQPConnection_1_0Impl.java Wed Jan 25 07:17:47 2017
@@ -57,7 +57,6 @@ import org.apache.qpid.server.model.Name
 import org.apache.qpid.server.model.Protocol;
 import org.apache.qpid.server.model.Transport;
 import org.apache.qpid.server.model.port.AmqpPort;
-import org.apache.qpid.server.protocol.AMQSessionModel;
 import org.apache.qpid.server.protocol.ConnectionClosingTicker;
 import org.apache.qpid.server.protocol.v1_0.codec.DescribedTypeConstructorRegistry;
 import org.apache.qpid.server.protocol.v1_0.codec.FrameWriter;
@@ -103,6 +102,7 @@ import org.apache.qpid.server.security.a
 import org.apache.qpid.server.security.auth.manager.AnonymousAuthenticationManager;
 import org.apache.qpid.server.security.auth.manager.ExternalAuthenticationManagerImpl;
 import org.apache.qpid.server.security.auth.sasl.SaslNegotiator;
+import org.apache.qpid.server.session.AMQPSession;
 import org.apache.qpid.server.store.StoreException;
 import org.apache.qpid.server.transport.AbstractAMQPConnection;
 import org.apache.qpid.server.transport.AggregateTicker;
@@ -236,8 +236,8 @@ public class AMQPConnection_1_0Impl exte
 
     private boolean _closedOnOpen;
 
-    private final Set<AMQSessionModel<?,?>> _sessionsWithWork =
-            Collections.newSetFromMap(new ConcurrentHashMap<AMQSessionModel<?,?>, Boolean>());
+    private final Set<AMQPSession<?,?>> _sessionsWithWork =
+            Collections.newSetFromMap(new ConcurrentHashMap<AMQPSession<?,?>, Boolean>());
 
     AMQPConnection_1_0Impl(final Broker<?> broker,
                            final ServerNetworkConnection network,
@@ -1387,7 +1387,7 @@ public class AMQPConnection_1_0Impl exte
     }
 
     @Override
-    public void notifyWork(final AMQSessionModel<?,?> sessionModel)
+    public void notifyWork(final AMQPSession<?,?> sessionModel)
     {
         _sessionsWithWork.add(sessionModel);
         notifyWork();
@@ -1439,7 +1439,7 @@ public class AMQPConnection_1_0Impl exte
         addAsyncTask(action);
     }
 
-    public void closeSessionAsync(final AMQSessionModel<?,?> session,
+    public void closeSessionAsync(final AMQPSession<?,?> session,
                                   final CloseReason reason, final String message)
     {
         final ErrorCondition cause;
@@ -1633,7 +1633,7 @@ public class AMQPConnection_1_0Impl exte
 
     private class ProcessPendingIterator implements Iterator<Runnable>
     {
-        private Iterator<? extends AMQSessionModel<?,?>> _sessionIterator;
+        private Iterator<? extends AMQPSession<?,?>> _sessionIterator;
         private ProcessPendingIterator()
         {
             _sessionIterator = _sessionsWithWork.iterator();
@@ -1683,7 +1683,7 @@ public class AMQPConnection_1_0Impl exte
                     {
                         _sessionIterator = _sessionsWithWork.iterator();
                     }
-                    final AMQSessionModel<?,?> session = _sessionIterator.next();
+                    final AMQPSession<?,?> session = _sessionIterator.next();
                     return new Runnable()
                     {
                         @Override

Modified: qpid/java/trunk/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/Session_1_0.java
URL: http://svn.apache.org/viewvc/qpid/java/trunk/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/Session_1_0.java?rev=1780139&r1=1780138&r2=1780139&view=diff
==============================================================================
--- qpid/java/trunk/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/Session_1_0.java (original)
+++ qpid/java/trunk/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/Session_1_0.java Wed Jan 25 07:17:47 2017
@@ -70,7 +70,6 @@ import org.apache.qpid.server.model.NotF
 import org.apache.qpid.server.model.Queue;
 import org.apache.qpid.server.model.Session;
 import org.apache.qpid.server.model.State;
-import org.apache.qpid.server.protocol.AMQSessionModel;
 import org.apache.qpid.server.protocol.CapacityChecker;
 import org.apache.qpid.server.protocol.LinkRegistry;
 import org.apache.qpid.server.protocol.v1_0.codec.QpidByteBufferUtils;
@@ -120,9 +119,10 @@ import org.apache.qpid.server.txn.Server
 import org.apache.qpid.server.util.Action;
 import org.apache.qpid.server.util.ConnectionScopedRuntimeException;
 import org.apache.qpid.server.virtualhost.QueueManagingVirtualHost;
+import org.apache.qpid.transport.network.Ticker;
 
 public class Session_1_0 extends AbstractAMQPSession<Session_1_0, ConsumerTarget_1_0>
-        implements AMQSessionModel<Session_1_0, ConsumerTarget_1_0>, LogSubject
+        implements LogSubject, org.apache.qpid.server.util.Deletable<Session_1_0>
 {
     public static final Symbol DELAYED_DELIVERY = Symbol.valueOf("DELAYED_DELIVERY");
     private static final Logger _logger = LoggerFactory.getLogger(Session_1_0.class);

Modified: qpid/java/trunk/broker-plugins/management-amqp/src/main/java/org/apache/qpid/server/management/amqp/ManagementAddressSpace.java
URL: http://svn.apache.org/viewvc/qpid/java/trunk/broker-plugins/management-amqp/src/main/java/org/apache/qpid/server/management/amqp/ManagementAddressSpace.java?rev=1780139&r1=1780138&r2=1780139&view=diff
==============================================================================
--- qpid/java/trunk/broker-plugins/management-amqp/src/main/java/org/apache/qpid/server/management/amqp/ManagementAddressSpace.java (original)
+++ qpid/java/trunk/broker-plugins/management-amqp/src/main/java/org/apache/qpid/server/management/amqp/ManagementAddressSpace.java Wed Jan 25 07:17:47 2017
@@ -53,11 +53,11 @@ import org.apache.qpid.server.model.Name
 import org.apache.qpid.server.model.PublishingLink;
 import org.apache.qpid.server.model.port.AmqpPort;
 import org.apache.qpid.server.plugin.SystemAddressSpaceCreator;
-import org.apache.qpid.server.protocol.AMQSessionModel;
 import org.apache.qpid.server.protocol.LinkModel;
 import org.apache.qpid.server.protocol.LinkRegistry;
 import org.apache.qpid.server.security.SecurityToken;
 import org.apache.qpid.server.security.access.Operation;
+import org.apache.qpid.server.session.AMQPSession;
 import org.apache.qpid.server.store.MemoryMessageStore;
 import org.apache.qpid.server.store.MessageStore;
 import org.apache.qpid.server.store.StorableMessageMetaData;
@@ -253,7 +253,7 @@ public class ManagementAddressSpace impl
         if (!sessionPrincipals.isEmpty())
         {
             final ProxyMessageSource proxyMessageSource = new ProxyMessageSource(this, attributes);
-            final AMQSessionModel session = sessionPrincipals.iterator().next().getSession();
+            final AMQPSession<?,?> session = sessionPrincipals.iterator().next().getSession();
             final Object connectionReference = session.getConnectionReference();
             ConcurrentMap<String, ProxyMessageSource> connectionSpecificDestinations =
                     _connectionSpecificDestinations.get(connectionReference);

Modified: qpid/java/trunk/broker-plugins/management-amqp/src/main/java/org/apache/qpid/server/management/amqp/ManagementNode.java
URL: http://svn.apache.org/viewvc/qpid/java/trunk/broker-plugins/management-amqp/src/main/java/org/apache/qpid/server/management/amqp/ManagementNode.java?rev=1780139&r1=1780138&r2=1780139&view=diff
==============================================================================
--- qpid/java/trunk/broker-plugins/management-amqp/src/main/java/org/apache/qpid/server/management/amqp/ManagementNode.java (original)
+++ qpid/java/trunk/broker-plugins/management-amqp/src/main/java/org/apache/qpid/server/management/amqp/ManagementNode.java Wed Jan 25 07:17:47 2017
@@ -80,10 +80,10 @@ import org.apache.qpid.server.model.Name
 import org.apache.qpid.server.model.OperationParameter;
 import org.apache.qpid.server.model.PublishingLink;
 import org.apache.qpid.server.plugin.MessageConverter;
-import org.apache.qpid.server.protocol.AMQSessionModel;
 import org.apache.qpid.server.protocol.MessageConverterRegistry;
 import org.apache.qpid.server.queue.BaseQueue;
 import org.apache.qpid.server.security.SecurityToken;
+import org.apache.qpid.server.session.AMQPSession;
 import org.apache.qpid.server.store.MessageDurability;
 import org.apache.qpid.server.store.MessageEnqueueRecord;
 import org.apache.qpid.server.store.StorableMessageMetaData;
@@ -1004,7 +1004,7 @@ class ManagementNode implements MessageS
         Set<SessionPrincipal> sessionPrincipals = currentSubject.getPrincipals(SessionPrincipal.class);
         if (!sessionPrincipals.isEmpty())
         {
-            AMQSessionModel publishingSession = sessionPrincipals.iterator().next().getSession();
+            AMQPSession<?,?> publishingSession = sessionPrincipals.iterator().next().getSession();
             for (ManagementNodeConsumer candidate : _consumers)
             {
                 if (candidate.getTarget().getTargetAddress().equals(replyTo) && candidate.getSessionModel().getConnectionReference() == publishingSession.getConnectionReference())
@@ -1496,7 +1496,7 @@ class ManagementNode implements MessageS
     }
 
     @Override
-    public boolean verifySessionAccess(final AMQSessionModel<?,?> session)
+    public boolean verifySessionAccess(final AMQPSession<?,?> session)
     {
         return true;
     }

Modified: qpid/java/trunk/broker-plugins/management-amqp/src/main/java/org/apache/qpid/server/management/amqp/ManagementNodeConsumer.java
URL: http://svn.apache.org/viewvc/qpid/java/trunk/broker-plugins/management-amqp/src/main/java/org/apache/qpid/server/management/amqp/ManagementNodeConsumer.java?rev=1780139&r1=1780138&r2=1780139&view=diff
==============================================================================
--- qpid/java/trunk/broker-plugins/management-amqp/src/main/java/org/apache/qpid/server/management/amqp/ManagementNodeConsumer.java (original)
+++ qpid/java/trunk/broker-plugins/management-amqp/src/main/java/org/apache/qpid/server/management/amqp/ManagementNodeConsumer.java Wed Jan 25 07:17:47 2017
@@ -38,10 +38,10 @@ import org.apache.qpid.server.message.Se
 import org.apache.qpid.server.message.internal.InternalMessage;
 import org.apache.qpid.server.model.NamedAddressSpace;
 import org.apache.qpid.server.model.PublishingLink;
-import org.apache.qpid.server.protocol.AMQSessionModel;
 import org.apache.qpid.server.message.MessageContainer;
 import org.apache.qpid.server.queue.BaseQueue;
 import org.apache.qpid.server.security.SecurityToken;
+import org.apache.qpid.server.session.AMQPSession;
 import org.apache.qpid.server.store.MessageDurability;
 import org.apache.qpid.server.store.MessageEnqueueRecord;
 import org.apache.qpid.server.store.StorableMessageMetaData;
@@ -106,7 +106,7 @@ class ManagementNodeConsumer<T extends C
         }
     }
 
-    AMQSessionModel getSessionModel()
+    AMQPSession<?,?> getSessionModel()
     {
         return _target.getSessionModel();
     }

Modified: qpid/java/trunk/broker-plugins/management-amqp/src/main/java/org/apache/qpid/server/management/amqp/ProxyMessageSource.java
URL: http://svn.apache.org/viewvc/qpid/java/trunk/broker-plugins/management-amqp/src/main/java/org/apache/qpid/server/management/amqp/ProxyMessageSource.java?rev=1780139&r1=1780138&r2=1780139&view=diff
==============================================================================
--- qpid/java/trunk/broker-plugins/management-amqp/src/main/java/org/apache/qpid/server/management/amqp/ProxyMessageSource.java (original)
+++ qpid/java/trunk/broker-plugins/management-amqp/src/main/java/org/apache/qpid/server/management/amqp/ProxyMessageSource.java Wed Jan 25 07:17:47 2017
@@ -52,8 +52,8 @@ import org.apache.qpid.server.message.Se
 import org.apache.qpid.server.model.ConfiguredObject;
 import org.apache.qpid.server.model.NamedAddressSpace;
 import org.apache.qpid.server.model.PublishingLink;
-import org.apache.qpid.server.protocol.AMQSessionModel;
 import org.apache.qpid.server.security.SecurityToken;
+import org.apache.qpid.server.session.AMQPSession;
 import org.apache.qpid.server.store.MessageDurability;
 import org.apache.qpid.server.store.StorableMessageMetaData;
 
@@ -172,7 +172,7 @@ public class ProxyMessageSource implemen
     }
 
     @Override
-    public boolean verifySessionAccess(final AMQSessionModel<?, ?> session)
+    public boolean verifySessionAccess(final AMQPSession<?,?> session)
     {
         return session.getConnectionReference() == _connectionReference;
     }
@@ -273,7 +273,7 @@ public class ProxyMessageSource implemen
         }
 
         @Override
-        public AMQSessionModel getSessionModel()
+        public AMQPSession getSessionModel()
         {
             return _underlying.getSessionModel();
         }

Modified: qpid/java/trunk/systests/src/test/java/org/apache/qpid/server/store/VirtualHostMessageStoreTest.java
URL: http://svn.apache.org/viewvc/qpid/java/trunk/systests/src/test/java/org/apache/qpid/server/store/VirtualHostMessageStoreTest.java?rev=1780139&r1=1780138&r2=1780139&view=diff
==============================================================================
--- qpid/java/trunk/systests/src/test/java/org/apache/qpid/server/store/VirtualHostMessageStoreTest.java (original)
+++ qpid/java/trunk/systests/src/test/java/org/apache/qpid/server/store/VirtualHostMessageStoreTest.java Wed Jan 25 07:17:47 2017
@@ -61,12 +61,13 @@ import org.apache.qpid.server.model.Stat
 import org.apache.qpid.server.model.UUIDGenerator;
 import org.apache.qpid.server.model.VirtualHost;
 import org.apache.qpid.server.model.VirtualHostNode;
-import org.apache.qpid.server.protocol.AMQSessionModel;
+import org.apache.qpid.server.protocol.v0_10.Session_0_10;
 import org.apache.qpid.server.protocol.v0_8.AMQMessage;
 import org.apache.qpid.server.protocol.v0_8.MessageMetaData;
 import org.apache.qpid.server.queue.LastValueQueue;
 import org.apache.qpid.server.queue.PriorityQueue;
 import org.apache.qpid.server.queue.StandardQueue;
+import org.apache.qpid.server.session.AMQPSession;
 import org.apache.qpid.server.transport.AMQPConnection;
 import org.apache.qpid.server.txn.AutoCommitTransaction;
 import org.apache.qpid.server.txn.ServerTransaction;
@@ -683,7 +684,7 @@ public class VirtualHostMessageStoreTest
         queueArguments.put(Queue.DURABLE, durable);
         queueArguments.put(Queue.LIFETIME_POLICY, LifetimePolicy.PERMANENT);
         queueArguments.put(Queue.EXCLUSIVE, exclusive ? ExclusivityPolicy.CONTAINER : ExclusivityPolicy.NONE);
-        AMQSessionModel sessionModel = mock(AMQSessionModel.class);
+        AMQPSession sessionModel = mock(AMQPSession.class);
         AMQPConnection connectionModel = mock(AMQPConnection.class);
         when(sessionModel.getAMQPConnection()).thenReturn(connectionModel);
         when(connectionModel.getRemoteContainerName()).thenReturn(queueOwner);



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org