[GitHub] [incubator-mxnet] reminisce commented on a change in pull request #15494: [Numpy] Added operator logaddexp2; added support for zero-size tensor in BinaryBroadcastBackwardUseIn

[GitBox <gi...@apache.org>]

reminisce commented on a change in pull request #15494: [Numpy] Added operator logaddexp2; added support for zero-size tensor in BinaryBroadcastBackwardUseIn
URL: https://github.com/apache/incubator-mxnet/pull/15494#discussion_r302350415
 
 

 ##########
 File path: src/operator/numpy/np_elemwise_broadcast_op.cu
 ##########
 @@ -48,6 +48,14 @@ NNVM_REGISTER_OP(_npi_maximum)
 NNVM_REGISTER_OP(_npi_minimum)
 .set_attr<FCompute>("FCompute<gpu>", BinaryBroadcastCompute<gpu, mshadow_op::minimum>);
 
+NNVM_REGISTER_OP(_npi_logaddexp2)
+.set_attr<FCompute>("FCompute<gpu>", BinaryBroadcastCompute<gpu, mshadow_op::logaddexp2>);
+
+NNVM_REGISTER_OP(_backward_logaddexp2)
+.set_attr<FCompute>("FCompute<gpu>", BinaryBroadcastBackwardUseIn<gpu,  \
 
 Review comment:
   Coding style. BTW, line breaker `\` is not needed in C++.
   ```cpp
   .set_attr<FCompute>("FCompute<gpu>",
                       BinaryBroadcastBackwardUseIn<gpu, mshadow_op::logaddexp2_grad_left, mshadow_op::logaddexp2_grad_right>);
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services