[jira] Commented: (WICKET-2505) Button.onSubmit javadoc is misleading

["Sampo Kettunen (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WICKET-2505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12762106#action_12762106 ] 

Sampo Kettunen commented on WICKET-2505:
----------------------------------------

I stumbled upon this bug when I tried to add some behaviour to my button that I wanted to execute whether or not the validation fails. It's not a big issue but fine-tuning the javadoc might save other people a tiny bit of time.

> Button.onSubmit javadoc is misleading
> -------------------------------------
>
>                 Key: WICKET-2505
>                 URL: https://issues.apache.org/jira/browse/WICKET-2505
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.4.1
>            Reporter: Sampo Kettunen
>            Priority: Trivial
>
> The javadoc in org.apache.wicket.markup.html.form.Button.onSubmit() is misleading. It says "Override this method to provide special submit handling in a multi-button form. It is called whenever the user clicks this particular button." In reality, the method doesn't get called if the form's validation fails. Not sure if there are other cases as well when the method doesn't get called.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.