You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Jaimin Jetly <ja...@hortonworks.com> on 2015/10/03 02:43:46 UTC

Review Request 38973: Ranger smart config: User Info Tab should change visibility of configs dynamically

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38973/
-----------------------------------------------------------

Review request for Ambari, Srimanth Gunturi and Yusaku Sako.


Bugs: AMBARI-13303
    https://issues.apache.org/jira/browse/AMBARI-13303


Repository: ambari


Description
-------

User Info Tab should show only the combination of configs that makes sense depending upon the value choosen by theu user fof the primary configs


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/state/theme/Subsection.java c9f9019 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-admin-site.xml eb8dc38 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-ugsync-site.xml c73c592 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/themes/theme.json b398a3b 
  ambari-web/app/mappers/configs/themes_mapper.js c296713 
  ambari-web/app/models/configs/theme/sub_section.js ba6cc99 
  ambari-web/app/templates/common/configs/service_config_layout_tab.hbs 0afe6ac 
  ambari-web/app/views/common/configs/widgets/config_widget_view.js 30c942b 

Diff: https://reviews.apache.org/r/38973/diff/


Testing
-------

Verified that ambari-web unit tests passes with the patch:
9300 tests complete (11 seconds)
94 tests pending


Thanks,

Jaimin Jetly


Re: Review Request 38973: Ranger smart config: User Info Tab should change visibility of configs dynamically

Posted by Yusaku Sako <yu...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38973/#review101394
-----------------------------------------------------------

Ship it!


Ship It!

- Yusaku Sako


On Oct. 3, 2015, 12:43 a.m., Jaimin Jetly wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38973/
> -----------------------------------------------------------
> 
> (Updated Oct. 3, 2015, 12:43 a.m.)
> 
> 
> Review request for Ambari, Srimanth Gunturi and Yusaku Sako.
> 
> 
> Bugs: AMBARI-13303
>     https://issues.apache.org/jira/browse/AMBARI-13303
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> User Info Tab should show only the combination of configs that makes sense depending upon the value choosen by theu user fof the primary configs
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/state/theme/Subsection.java c9f9019 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-admin-site.xml eb8dc38 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-ugsync-site.xml c73c592 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/themes/theme.json b398a3b 
>   ambari-web/app/mappers/configs/themes_mapper.js c296713 
>   ambari-web/app/models/configs/theme/sub_section.js ba6cc99 
>   ambari-web/app/templates/common/configs/service_config_layout_tab.hbs 0afe6ac 
>   ambari-web/app/views/common/configs/widgets/config_widget_view.js 30c942b 
> 
> Diff: https://reviews.apache.org/r/38973/diff/
> 
> 
> Testing
> -------
> 
> Verified that ambari-web unit tests passes with the patch:
> 9300 tests complete (11 seconds)
> 94 tests pending
> 
> 
> Thanks,
> 
> Jaimin Jetly
> 
>