You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by zh...@apache.org on 2024/06/16 09:13:44 UTC

(hbase) branch branch-3 updated (0b70d6c9cf0 -> 9270519eadd)

This is an automated email from the ASF dual-hosted git repository.

zhangduo pushed a change to branch branch-3
in repository https://gitbox.apache.org/repos/asf/hbase.git


    from 0b70d6c9cf0 HBASE--28666 Dropping unclosed WALTailingReaders leads to leaked sockets (#5994)
     new a33b8c2ad1d Revert "HBASE--28666 Dropping unclosed WALTailingReaders leads to leaked sockets (#5994)"
     new 9270519eadd HBASE-28666 Dropping unclosed WALTailingReaders leads to leaked sockets (#5994)

The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:


(hbase) 01/02: Revert "HBASE--28666 Dropping unclosed WALTailingReaders leads to leaked sockets (#5994)"

Posted by zh...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

zhangduo pushed a commit to branch branch-3
in repository https://gitbox.apache.org/repos/asf/hbase.git

commit a33b8c2ad1d8c9724deb461f47b099981a345f26
Author: Duo Zhang <zh...@apache.org>
AuthorDate: Sun Jun 16 17:13:14 2024 +0800

    Revert "HBASE--28666 Dropping unclosed WALTailingReaders leads to leaked sockets (#5994)"
    
    This reverts commit 0b70d6c9cf0749f67151b862edc728e72f72d9b6.
---
 .../org/apache/hadoop/hbase/replication/regionserver/WALEntryStream.java | 1 -
 1 file changed, 1 deletion(-)

diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/WALEntryStream.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/WALEntryStream.java
index 8d74d0e0399..186d5b7c4d1 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/WALEntryStream.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/WALEntryStream.java
@@ -219,7 +219,6 @@ class WALEntryStream implements Closeable {
             // we will read from the beginning so we should always clear the compression context
             reader.resetTo(-1, true);
           }
-          return HasNext.YES;
         } catch (IOException e) {
           LOG.warn("Failed to reset reader {} to pos {}, reset compression={}", currentPath,
             currentPositionOfEntry, state.resetCompression(), e);


(hbase) 02/02: HBASE-28666 Dropping unclosed WALTailingReaders leads to leaked sockets (#5994)

Posted by zh...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

zhangduo pushed a commit to branch branch-3
in repository https://gitbox.apache.org/repos/asf/hbase.git

commit 9270519eadda8dce5dad4c6936ce27b77766dd7a
Author: Charles Connell <cc...@hubspot.com>
AuthorDate: Sat Jun 15 22:15:20 2024 -0400

    HBASE-28666 Dropping unclosed WALTailingReaders leads to leaked sockets (#5994)
    
    In WALEntryStream, always use current WALTailingReader if one exists
    
    Signed-off-by: Duo Zhang <zh...@apache.org>
    (cherry picked from commit bd8ad45a259a1b0066068e41a25ef4c9098d374a)
---
 .../org/apache/hadoop/hbase/replication/regionserver/WALEntryStream.java | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/WALEntryStream.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/WALEntryStream.java
index 186d5b7c4d1..8d74d0e0399 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/WALEntryStream.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/WALEntryStream.java
@@ -219,6 +219,7 @@ class WALEntryStream implements Closeable {
             // we will read from the beginning so we should always clear the compression context
             reader.resetTo(-1, true);
           }
+          return HasNext.YES;
         } catch (IOException e) {
           LOG.warn("Failed to reset reader {} to pos {}, reset compression={}", currentPath,
             currentPositionOfEntry, state.resetCompression(), e);