You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by microhello <gi...@git.apache.org> on 2015/12/23 04:42:33 UTC
[GitHub] spark pull request: Add more exceptions to Guava relocation
GitHub user microhello opened a pull request:
https://github.com/apache/spark/pull/10442
Add more exceptions to Guava relocation
Add `com.google.common.base.AbstractIterator` exceptions to Guava relocation , So far, all guava 14.0.1 `Optional` Class dependencies have added;
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/novadata/spark branch-1.5
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/10442.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #10442
----
commit 5a94ca9662b953a910d6f004090f81bf4c3b39d1
Author: xiaoyong <xi...@infosim.net>
Date: 2015-12-23T03:40:49Z
Add com.google.common.base.AbstractIterator exceptions to Guava relocation , So far, all guava 14.0.1 Optional Class dependencies have added;
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: Add more exceptions to Guava relocation
Posted by microhello <gi...@git.apache.org>.
Github user microhello commented on a diff in the pull request:
https://github.com/apache/spark/pull/10442#discussion_r48463834
--- Diff: pom.xml ---
@@ -99,14 +99,14 @@
<module>sql/hive</module>
<module>unsafe</module>
<module>assembly</module>
- <module>external/twitter</module>
- <module>external/flume</module>
- <module>external/flume-sink</module>
- <module>external/flume-assembly</module>
- <module>external/mqtt</module>
- <module>external/mqtt-assembly</module>
- <module>external/zeromq</module>
- <module>examples</module>
+ <!--<module>external/twitter</module>-->
--- End diff --
These changes only used by myself, don't need merge. But I hope the following changes be merged:
Add `com.google.common.base.AbstractIterator` exceptions to Guava relocation , So far, all guava 14.0.1 `Optional` Class dependencies have added;
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: Add more exceptions to Guava relocation
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/10442#discussion_r48467535
--- Diff: pom.xml ---
@@ -99,14 +99,14 @@
<module>sql/hive</module>
<module>unsafe</module>
<module>assembly</module>
- <module>external/twitter</module>
- <module>external/flume</module>
- <module>external/flume-sink</module>
- <module>external/flume-assembly</module>
- <module>external/mqtt</module>
- <module>external/mqtt-assembly</module>
- <module>external/zeromq</module>
- <module>examples</module>
+ <!--<module>external/twitter</module>-->
--- End diff --
Well, as I say, there's no way this PR can be merged like this anyway, so please close it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12548][Build] Add more exceptions to Gu...
Posted by andrewor14 <gi...@git.apache.org>.
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/10442#issuecomment-167855574
Also, I just noticed this is opened against the wrong branch. Please close this PR and re-open it against master if we do decide to continue work on this issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: Add more exceptions to Guava relocation
Posted by microhello <gi...@git.apache.org>.
Github user microhello commented on the pull request:
https://github.com/apache/spark/pull/10442#issuecomment-167493888
@srowen
When I use [facebook/swift](https://github.com/facebook/swift) with spark 1.5.2, throw following exception, so I need add `com.google.common.base.AbstractIterator` exceptions to Guava relocation .
```java
Exception in thread "main" java.lang.IllegalAccessError: class com.google.common.base.Optional$1$1 cannot access its superclass org.spark-project.guava.base.AbstractIterator
at java.lang.ClassLoader.defineClass1(Native Method)
at java.lang.ClassLoader.defineClass(ClassLoader.java:760)
at java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142)
at java.net.URLClassLoader.defineClass(URLClassLoader.java:467)
at java.net.URLClassLoader.access$100(URLClassLoader.java:73)
at java.net.URLClassLoader$1.run(URLClassLoader.java:368)
at java.net.URLClassLoader$1.run(URLClassLoader.java:362)
at java.security.AccessController.doPrivileged(Native Method)
at java.net.URLClassLoader.findClass(URLClassLoader.java:361)
at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:331)
at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
at com.google.common.base.Optional$1.iterator(Optional.java:223)
at com.google.common.collect.ImmutableSet.copyOf(ImmutableSet.java:300)
at com.facebook.swift.codec.metadata.AbstractThriftMetadataBuilder.inferThriftFieldIds(AbstractThriftMetadataBuilder.java:566)
at com.facebook.swift.codec.metadata.AbstractThriftMetadataBuilder.inferThriftFieldIds(AbstractThriftMetadataBuilder.java:542)
at com.facebook.swift.codec.metadata.AbstractThriftMetadataBuilder.normalizeThriftFields(AbstractThriftMetadataBuilder.java:483)
at com.facebook.swift.codec.metadata.ThriftStructMetadataBuilder.<init>(ThriftStructMetadataBuilder.java:48)
at com.facebook.swift.codec.metadata.ThriftCatalog.extractThriftStructMetadata(ThriftCatalog.java:542)
at com.facebook.swift.codec.metadata.ThriftCatalog.getThriftStructMetadata(ThriftCatalog.java:408)
at com.facebook.swift.codec.metadata.ThriftCatalog.getThriftTypeUncached(ThriftCatalog.java:283)
at com.facebook.swift.codec.metadata.ThriftCatalog.getThriftType(ThriftCatalog.java:215)
at com.facebook.swift.service.metadata.ThriftMethodMetadata.<init>(ThriftMethodMetadata.java:90)
at com.facebook.swift.service.metadata.ThriftServiceMetadata.<init>(ThriftServiceMetadata.java:73)
at com.facebook.swift.service.ThriftServiceProcessor.<init>(ThriftServiceProcessor.java:76)
at com.facebook.swift.service.ThriftServiceProcessor.<init>(ThriftServiceProcessor.java:65)
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: Add more exceptions to Guava relocation
Posted by microhello <gi...@git.apache.org>.
Github user microhello commented on the pull request:
https://github.com/apache/spark/pull/10442#issuecomment-167738304
@andrewor14 I have created a issue: https://issues.apache.org/jira/browse/SPARK-12548
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: Add more exceptions to Guava relocation
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10442#issuecomment-166796984
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12548][Build] Add more exceptions to Gu...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/10442
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: Add more exceptions to Guava relocation
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/10442#issuecomment-166853471
Why does this need to be added?
The Guava exceptions are going away in 2.x anyway.
This also doesn't follow https://cwiki.apache.org/confluence/display/SPARK/Contributing+to+Spark
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: Add more exceptions to Guava relocation
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/10442#discussion_r48333932
--- Diff: pom.xml ---
@@ -99,14 +99,14 @@
<module>sql/hive</module>
<module>unsafe</module>
<module>assembly</module>
- <module>external/twitter</module>
- <module>external/flume</module>
- <module>external/flume-sink</module>
- <module>external/flume-assembly</module>
- <module>external/mqtt</module>
- <module>external/mqtt-assembly</module>
- <module>external/zeromq</module>
- <module>examples</module>
+ <!--<module>external/twitter</module>-->
--- End diff --
Most of these changes you've made can't be merged. Do you mind closing this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: Add more exceptions to Guava relocation
Posted by andrewor14 <gi...@git.apache.org>.
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/10442#issuecomment-167700718
@microhello please file a JIRA and add it to the title of this PR. See how other patches are opened.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: Add more exceptions to Guava relocation
Posted by microhello <gi...@git.apache.org>.
Github user microhello commented on a diff in the pull request:
https://github.com/apache/spark/pull/10442#discussion_r48467911
--- Diff: pom.xml ---
@@ -99,14 +99,14 @@
<module>sql/hive</module>
<module>unsafe</module>
<module>assembly</module>
- <module>external/twitter</module>
- <module>external/flume</module>
- <module>external/flume-sink</module>
- <module>external/flume-assembly</module>
- <module>external/mqtt</module>
- <module>external/mqtt-assembly</module>
- <module>external/zeromq</module>
- <module>examples</module>
+ <!--<module>external/twitter</module>-->
--- End diff --
OK
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12548][Build] Add more exceptions to Gu...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/10442#issuecomment-167747012
Yeah the issue here is that this is already a "duplicate" of the issue to remove the Guava exceptions anyway
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org