You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Ryan McKinley (JIRA)" <ji...@apache.org> on 2011/03/25 15:47:05 UTC
[jira] [Created] (SOLR-2443) Solr DocValues should have
objectVal(int doc)
Solr DocValues should have objectVal(int doc)
---------------------------------------------
Key: SOLR-2443
URL: https://issues.apache.org/jira/browse/SOLR-2443
Project: Solr
Issue Type: Improvement
Reporter: Ryan McKinley
DocValues has all versions of intVal, floatVal, strVal, but there is no general way to know what the raw type is.
We should add a general objetVal( int doc )
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-2443) Solr DocValues should have
objectVal(int doc)
Posted by "Ryan McKinley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13017075#comment-13017075 ]
Ryan McKinley commented on SOLR-2443:
-------------------------------------
I like FloatDocValues -- helpes get rid of the TON of duplication
> Solr DocValues should have objectVal(int doc)
> ---------------------------------------------
>
> Key: SOLR-2443
> URL: https://issues.apache.org/jira/browse/SOLR-2443
> Project: Solr
> Issue Type: Improvement
> Reporter: Ryan McKinley
> Assignee: Yonik Seeley
> Attachments: SOLR-2443-object-values.patch, SOLR-2443.patch
>
>
> DocValues has all versions of intVal, floatVal, strVal, but there is no general way to know what the raw type is.
> We should add a general objetVal( int doc )
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (SOLR-2443) Solr DocValues should have
objectVal(int doc)
Posted by "Yonik Seeley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Yonik Seeley updated SOLR-2443:
-------------------------------
Attachment: SOLR-2443.patch
Here's a patch that adds objectVal(), exists(), bytesVal(), fixes some parsing/type errors, fixes a potential slowness in QueryValueSource, and refactors some repeated stuff to base classes like FloatDocValues.
> Solr DocValues should have objectVal(int doc)
> ---------------------------------------------
>
> Key: SOLR-2443
> URL: https://issues.apache.org/jira/browse/SOLR-2443
> Project: Solr
> Issue Type: Improvement
> Reporter: Ryan McKinley
> Assignee: Yonik Seeley
> Attachments: SOLR-2443-object-values.patch, SOLR-2443.patch
>
>
> DocValues has all versions of intVal, floatVal, strVal, but there is no general way to know what the raw type is.
> We should add a general objetVal( int doc )
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Assigned] (SOLR-2443) Solr DocValues should have
objectVal(int doc)
Posted by "Yonik Seeley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Yonik Seeley reassigned SOLR-2443:
----------------------------------
Assignee: Yonik Seeley
> Solr DocValues should have objectVal(int doc)
> ---------------------------------------------
>
> Key: SOLR-2443
> URL: https://issues.apache.org/jira/browse/SOLR-2443
> Project: Solr
> Issue Type: Improvement
> Reporter: Ryan McKinley
> Assignee: Yonik Seeley
> Attachments: SOLR-2443-object-values.patch
>
>
> DocValues has all versions of intVal, floatVal, strVal, but there is no general way to know what the raw type is.
> We should add a general objetVal( int doc )
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-2443) Solr DocValues should have
objectVal(int doc)
Posted by "Ryan McKinley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13046135#comment-13046135 ]
Ryan McKinley commented on SOLR-2443:
-------------------------------------
I think this has been committed, but the JIRA issue did not get updated?
> Solr DocValues should have objectVal(int doc)
> ---------------------------------------------
>
> Key: SOLR-2443
> URL: https://issues.apache.org/jira/browse/SOLR-2443
> Project: Solr
> Issue Type: Improvement
> Reporter: Ryan McKinley
> Assignee: Yonik Seeley
> Attachments: SOLR-2443-object-values.patch, SOLR-2443.patch
>
>
> DocValues has all versions of intVal, floatVal, strVal, but there is no general way to know what the raw type is.
> We should add a general objetVal( int doc )
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Resolved] (SOLR-2443) Solr DocValues should have
objectVal(int doc)
Posted by "Yonik Seeley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Yonik Seeley resolved SOLR-2443.
--------------------------------
Resolution: Fixed
Fix Version/s: 4.0
Yep, has been committed for a while... my bad.
> Solr DocValues should have objectVal(int doc)
> ---------------------------------------------
>
> Key: SOLR-2443
> URL: https://issues.apache.org/jira/browse/SOLR-2443
> Project: Solr
> Issue Type: Improvement
> Reporter: Ryan McKinley
> Assignee: Yonik Seeley
> Fix For: 4.0
>
> Attachments: SOLR-2443-object-values.patch, SOLR-2443.patch
>
>
> DocValues has all versions of intVal, floatVal, strVal, but there is no general way to know what the raw type is.
> We should add a general objetVal( int doc )
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (SOLR-2443) Solr DocValues should have
objectVal(int doc)
Posted by "Ryan McKinley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ryan McKinley updated SOLR-2443:
--------------------------------
Attachment: SOLR-2443-object-values.patch
Adding default implementatio that uses strVal()
{code:java}
public Object objectVal(int doc) { return strVal( doc ); }
{code}
Then different DocValues override things like:
{code:java}
@Override
public Object objectVal(int doc) {
return arr[doc];
}
{code}
> Solr DocValues should have objectVal(int doc)
> ---------------------------------------------
>
> Key: SOLR-2443
> URL: https://issues.apache.org/jira/browse/SOLR-2443
> Project: Solr
> Issue Type: Improvement
> Reporter: Ryan McKinley
> Attachments: SOLR-2443-object-values.patch
>
>
> DocValues has all versions of intVal, floatVal, strVal, but there is no general way to know what the raw type is.
> We should add a general objetVal( int doc )
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org