[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #475: [SUREFIRE-2025] Updated abstractions which helps associating systemProperties() with a test

[GitBox <gi...@apache.org>]

Tibor17 commented on a change in pull request #475:
URL: https://github.com/apache/maven-surefire/pull/475#discussion_r814068564



##########
File path: surefire-api/src/main/java/org/apache/maven/surefire/api/booter/ForkingRunListener.java
##########
@@ -68,7 +68,7 @@ public void testSetStarting( TestSetReportEntry report )
     @Override
     public void testSetCompleted( TestSetReportEntry report )
     {
-        target.systemProperties( report.getSystemProperties() );
+        target.systemProperties( report.getSystemProperties(), null, null );

Review comment:
       I did split the entire work of [SUREFIRE-1860](https://issues.apache.org/jira/browse/SUREFIRE-1860) into 5 pieces.
   The line you are asking for is in my IDEA:
   `target.systemProperties( report.getSystemProperties(), report.getRunMode(), report.getTestRunId() );`
   Both getters will come in the next PR right after - [SUREFIRE-2015](https://issues.apache.org/jira/browse/SUREFIRE-2015)
   
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org