You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "michael-o (via GitHub)" <gi...@apache.org> on 2024/06/07 21:54:38 UTC
[PR] Lock down classifier [maven-dependency-plugin]
michael-o opened a new pull request, #409:
URL: https://github.com/apache/maven-dependency-plugin/pull/409
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MDEP) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[MDEP-XXX] - Fixes bug in ApproximateQuantiles`,
where you replace `MDEP-XXX` with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the
commit message.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
- [ ] You have run the integration tests successfully (`mvn -Prun-its clean verify`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MDEP-939] Lock down classifier in dependency:sources goal [maven-dependency-plugin]
Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on PR #409:
URL: https://github.com/apache/maven-dependency-plugin/pull/409#issuecomment-2155942471
> > > Looks ok - even more `classifier` parameter disappears from plugin documentation
> >
> >
> > This is a nice bonus or a bug in the Plugin Tools.
>
> works as expected - documentation was taken from the final class - as we have read-only property is hidden
Perfect, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MDEP-939] Lock down classifier in dependency:sources goal [maven-dependency-plugin]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on code in PR #409:
URL: https://github.com/apache/maven-dependency-plugin/pull/409#discussion_r1632038544
##########
src/it/projects/sources/test.properties:
##########
@@ -16,3 +16,4 @@
# under the License.
outputFile = target/resolved.txt
+classifier = foo
Review Comment:
and there are no assertions in this test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MDEP-939] Lock down classifier in dependency:sources goal [maven-dependency-plugin]
Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on code in PR #409:
URL: https://github.com/apache/maven-dependency-plugin/pull/409#discussion_r1631743763
##########
src/it/projects/sources/test.properties:
##########
@@ -16,3 +16,4 @@
# under the License.
outputFile = target/resolved.txt
+classifier = foo
Review Comment:
This may require a comment that it has no influence anymore...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MDEP-939] Lock down classifier in dependency:sources goal [maven-dependency-plugin]
Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on PR #409:
URL: https://github.com/apache/maven-dependency-plugin/pull/409#issuecomment-2155914096
> Looks ok - even more `classifier` parameter disappears from plugin documentation
This is a nice bonus or a bug in the Plugin Tools.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MDEP-939] Lock down classifier in dependency:sources goal [maven-dependency-plugin]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on code in PR #409:
URL: https://github.com/apache/maven-dependency-plugin/pull/409#discussion_r1632038356
##########
src/it/projects/sources/test.properties:
##########
@@ -16,3 +16,4 @@
# under the License.
outputFile = target/resolved.txt
+classifier = foo
Review Comment:
this test can be useful ... even we have a read only property user still can override it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MDEP-939] Lock down classifier in dependency:sources goal [maven-dependency-plugin]
Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on code in PR #409:
URL: https://github.com/apache/maven-dependency-plugin/pull/409#discussion_r1632016770
##########
src/it/projects/sources/test.properties:
##########
@@ -16,3 +16,4 @@
# under the License.
outputFile = target/resolved.txt
+classifier = foo
Review Comment:
Will do
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MDEP-939] Lock down classifier in dependency:sources goal [maven-dependency-plugin]
Posted by "asfgit (via GitHub)" <gi...@apache.org>.
asfgit closed pull request #409: [MDEP-939] Lock down classifier in dependency:sources goal
URL: https://github.com/apache/maven-dependency-plugin/pull/409
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MDEP-939] Lock down classifier in dependency:sources goal [maven-dependency-plugin]
Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on PR #409:
URL: https://github.com/apache/maven-dependency-plugin/pull/409#issuecomment-2156149098
FTR: All resolve ITs missing verifiers, this needs to be addressed as a whole.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MDEP-939] Lock down classifier in dependency:sources goal [maven-dependency-plugin]
Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on code in PR #409:
URL: https://github.com/apache/maven-dependency-plugin/pull/409#discussion_r1632046244
##########
src/it/projects/sources/test.properties:
##########
@@ -16,3 +16,4 @@
# under the License.
outputFile = target/resolved.txt
+classifier = foo
Review Comment:
I guess at least the build should not fail, but need to try...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MDEP-939] Lock down classifier in dependency:sources goal [maven-dependency-plugin]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on PR #409:
URL: https://github.com/apache/maven-dependency-plugin/pull/409#issuecomment-2155881459
Looks ok - even more `classifier` parameter disappears from plugin documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MDEP-939] Lock down classifier in dependency:sources goal [maven-dependency-plugin]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on PR #409:
URL: https://github.com/apache/maven-dependency-plugin/pull/409#issuecomment-2155921545
> > Looks ok - even more `classifier` parameter disappears from plugin documentation
>
> This is a nice bonus or a bug in the Plugin Tools.
works as expected - documentation was taken from the final class - as we have read-only property is hidden
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org