You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by HyukjinKwon <gi...@git.apache.org> on 2018/02/04 09:43:18 UTC

[GitHub] spark pull request #18555: [SPARK-21353][CORE]add checkValue in spark.intern...

Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18555#discussion_r165838720
  
    --- Diff: core/src/main/scala/org/apache/spark/internal/config/package.scala ---
    @@ -231,6 +315,9 @@ package object config {
       private[spark] val BLOCK_MANAGER_PORT = ConfigBuilder("spark.blockManager.port")
         .doc("Port to use for the block manager when a more specific setting is not provided.")
         .intConf
    +    .checkValue(v => v == 0 || (1024 <= v && v < 65536),
    --- End diff --
    
    +1 on ^


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org