You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "ouyangnengda (via GitHub)" <gi...@apache.org> on 2023/02/08 15:28:06 UTC
[GitHub] [kafka] ouyangnengda opened a new pull request, #13220: Kafka 14253
ouyangnengda opened a new pull request, #13220:
URL: https://github.com/apache/kafka/pull/13220
Add the number of members in the log to improve readability.
Example logs -
`StreamsPartitionAssignor.java`
```xml
Before - [2023-02-08 23:22:21,419] INFO stream-thread [] Assigned tasks [0_0, 0_1, 0_2, 0_3] including stateful [] to clients as:
00000000-0000-0000-0000-000000000001=[activeTasks: ([0_0, 0_2, 0_3]) standbyTasks: ([])]
00000000-0000-0000-0000-000000000002=[activeTasks: ([0_1]) standbyTasks: ([])].
After - [2023-02-07 23:05:29,723] INFO stream-thread [] Assigned 4 tasks [0_0, 0_1, 0_2, 0_3] including 0 stateful [] to 2 clients as:
00000000-0000-0000-0000-000000000001=[3 activeTasks: ([0_0, 0_2, 0_3]) 0 standbyTasks: ([])]
00000000-0000-0000-0000-000000000002=[1 activeTasks: ([0_1]) 0 standbyTasks: ([])].
```
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] divijvaidya commented on pull request #13220: Kafka 14253
Posted by "divijvaidya (via GitHub)" <gi...@apache.org>.
divijvaidya commented on PR #13220:
URL: https://github.com/apache/kafka/pull/13220#issuecomment-1425505624
Hey @ouyangnengda
I see that this is your first contribution to Kafka. Thank you for your interest in the project!
Since you are new to the community, let me fill you in with some best practices around submitting PRs:
1. First, [assign the JIRA to yourself](https://issues.apache.org/jira/browse/KAFKA-14253). This helps ensure that multiple people aren't working on same JIRA and hence, don't end up spending duplicate effort.
2.The name of the PR begins with the JIRA follower by `:` e.g. "KAFKA-14253: Add the number of members in the assignment log to improve readability". A workflow in the background will automatically add the PR to JIRA if you follow this format.
3. You will notice that the build is failing here. Although it doesn't seem related to your changes, but it would be nice if you could add a "testing" section in the description of the PR and mention that you ran unitTests and intergTests locally and it works for you. I usually do it by running `./gradlew unitTest` and `./gradlew integrationTest`.
Other than the above, the code change itself looks good to me. I will add an acceptance (and we will have to ping a committer to merge this) once you have made the changes I request above.
Cheers!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ouyangnengda commented on pull request #13220: Kafka 14253
Posted by "ouyangnengda (via GitHub)" <gi...@apache.org>.
ouyangnengda commented on PR #13220:
URL: https://github.com/apache/kafka/pull/13220#issuecomment-1425139081
Hi @divijvaidya , could you please review this PR.
Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] github-actions[bot] commented on pull request #13220: Kafka 14253
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #13220:
URL: https://github.com/apache/kafka/pull/13220#issuecomment-1585813219
This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge conflicts, please update it with the latest from trunk (or appropriate release branch)
If this PR is no longer valid or desired, please feel free to close it. If no activity occurrs in the next 30 days, it will be automatically closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org