[GitHub] graceguo-supercat edited a comment on issue #6478: [bugfix] show results in query history

[GitBox <gi...@apache.org>]

graceguo-supercat edited a comment on issue #6478: [bugfix] show results in query history
URL: https://github.com/apache/incubator-superset/pull/6478#issuecomment-443873770
 
 
   @youngyjd Thanks for the fix.
   
   - see this line:
   https://github.com/apache/incubator-superset/blob/69e8df404d46e35bf686cc92992d6e0415172d90/superset/assets/src/SqlLab/components/QueryAutoRefresh.jsx#L29
   
   This line was added in #5848. Auto-refresh should run periodically as along as we have queries not finished in backend. For query in rendering state, it should be finished in backend and also fetched into browser already. Not sure we should still check status of these queries in the backend?
   
   - see this line:
   https://github.com/apache/incubator-superset/blob/fc3b68e23433522b3a6d7327cc95199bf01dcf96/superset/assets/src/SqlLab/constants.js#L12
   
   This is all available status for the lifecycle of a query. If you add a state, can you also update this set? So that this new state will be taken care by other new or existed features.
   
   - This is the lifecycle of a query (in my mind):
   pending -> running -> success (or failed, stopped) ->fetching -> rendering
   some state may too short to display.
    `success` is for a state that query is successfully finished in backend. 
    `fetching` is for a state that downloading data to browser.
   I assume `rendering` means rendering data table. Can you make sure failed/stopped state also connected to rendering state? otherwise in error/stopped case, user will not see any updates.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org