You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@logging.apache.org by GitBox <gi...@apache.org> on 2020/09/17 08:08:02 UTC

[GitHub] [logging-log4net] NicholasNoise edited a comment on pull request #67: Add FxCop.

NicholasNoise edited a comment on pull request #67:
URL: https://github.com/apache/logging-log4net/pull/67#issuecomment-694069775


   @fluffynuts Every warning you see may be (or should be) turned off by ruleset: some warning are essential and should be attended to, others are not and just ignore them with no regret.
   FxCop grants build validation, so no one will be able to push "bad" code. Standalone tools like SonarQube are good, but runs manually, periodically or by event-based triggers and generated results should be analyzed by someone. Once I saw generated report - like looking into spam or notification category in my mail box.
   
   Anyway you are right that pushing a warning-free project into the dirt is no good.
   I think to split this PR into 2 parts:
   - Fix CA2000, CA2237, CA3075 - this pr
   - Add FxCop - new pull request with ruleset and csproj configuration changes.
   Are you ok with it?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org