[GitHub] [beam] echauchot edited a comment on pull request #15381: [BEAM-10990] Elasticsearch response filtering

[GitBox <gi...@apache.org>]

echauchot edited a comment on pull request #15381:
URL: https://github.com/apache/beam/pull/15381#issuecomment-930949400


   > Thanks for the feedback @echauchot! I wasn't sure if re-windowing within an IO was acceptable but it sounds like that's the path to go. It's way less complex, and I definitely like that. I'll make those changes
   
   @egalpin my pleasure ! 
   
   I mean: you should not change the windows of the elements. In fact, you should not deal with the windows at all. Your problem is to join the input elements with the status (json and error) of the write. You could do:
   - join by doc id but that whould not be possible in case the id is not provided in the input doc (autogeneration)
   - you maintain the same order between input docs and WriteSummary objects so you could simple join index 1 with index 1, index 2 with index 2 etc...
   I don't get why you bothered with windows in the first place but maybe there is something I missed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org