[jira] [Commented] (ZOOKEEPER-1113) QuorumMaj counts the number of ACKs but does not check who sent the ACK

["Flavio Junqueira (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13243194#comment-13243194 ] 

Flavio Junqueira commented on ZOOKEEPER-1113:
---------------------------------------------

The patch attached looks mostly good to me. It needs a couple of small fixes, though. It does not apply cleaning to trunk and the spacing is not right in QuorumMajorityTest:

{noformat}
+    	//setup servers 1-3 to be followers and 4 and 5 to be observers
+    	setUp(true);
+        ackSet.clear();
+        
+        // 1 follower out of 3 is not a majority 
{noformat}
                
> QuorumMaj counts the number of ACKs but does not check who sent the ACK
> -----------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1113
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1113
>             Project: ZooKeeper
>          Issue Type: Sub-task
>          Components: quorum
>            Reporter: Alexander Shraer
>            Priority: Minor
>             Fix For: 3.5.0
>
>         Attachments: ZOOKEEPER-1113.patch
>
>
> If a server connects to the leader as follower, it will be allowed to vote (with QuorumMaj) even if it is not a follower in the current configuration,
> as the leader does not care who sends the ACK - it only counts the number of ACKs.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira