You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/01/20 06:16:06 UTC
[GitHub] [arrow] jorgecarleitao opened a new pull request #12198: [Minor] Fixed integration test for nested
jorgecarleitao opened a new pull request #12198:
URL: https://github.com/apache/arrow/pull/12198
The test was not taking an important case - nested without nulls - into account because the go implementation does not support it. When an implementation fails, we skip implementations from the test, not deactivate the particular case for all implementations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] removed a comment on pull request #12198: ARROW-15386: Unskip integration test cases
Posted by GitBox <gi...@apache.org>.
github-actions[bot] removed a comment on pull request #12198:
URL: https://github.com/apache/arrow/pull/12198#issuecomment-1017154115
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW
Opening JIRAs ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename pull request title in the following format?
ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12198: ARROW-15386: Unskip integration test cases
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12198:
URL: https://github.com/apache/arrow/pull/12198#issuecomment-1017157116
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorgecarleitao commented on a change in pull request #12198: ARROW-15386: [Integration] Unskip test cases
Posted by GitBox <gi...@apache.org>.
jorgecarleitao commented on a change in pull request #12198:
URL: https://github.com/apache/arrow/pull/12198#discussion_r805137252
##########
File path: dev/archery/archery/integration/datagen.py
##########
@@ -1401,9 +1401,8 @@ def generate_nested_case():
get_field('item', 'int32'), 4),
StructField('struct_nullable', [get_field('f1', 'int32'),
get_field('f2', 'utf8')]),
- # Fails on Go (ARROW-8452)
- # ListField('list_nonnullable', get_field('item', 'int32'),
- # nullable=False),
+ ListField('list_nonnullable', get_field('item', 'int32'),
+ nullable=False),
Review comment:
Thanks a lot for your review, @pitrou !
all our integration test files are generated with a nullable and non-nullable version, which I assumed so far to make it a requirement to support nullable of a given type.
Maybe the "nested" is too broad, and we need to split it in different types.
I am parking this PR and will prioritize #12407 and #12409 as I am struggling to:
* run integration tests locally - it takes too much time.
* have a mechanism to add, remove and change tests
This is because the test file names are currently coupled to the names in the tests in the golden files. I am decoupling them in as part of #12409 to allow more flexibility in renaming, spliting, etc. test cases in this section.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on a change in pull request #12198: ARROW-15386: [Integration] Unskip test cases
Posted by GitBox <gi...@apache.org>.
pitrou commented on a change in pull request #12198:
URL: https://github.com/apache/arrow/pull/12198#discussion_r793738446
##########
File path: dev/archery/archery/integration/datagen.py
##########
@@ -1618,10 +1614,13 @@ def _temp_path():
.skip_category('Go')
.skip_category('JS'),
- # TODO(ARROW-3039, ARROW-5267): Dictionaries in GO
generate_dictionary_case()
.skip_category('C#')
- .skip_category('Go'),
+ # TODO(ARROW-3039, ARROW-5267): Dictionaries in GO
+ .skip_category('Go')
+ # TODO: JavaScript does not support uint64 dictionary indices, so disabled
+ # for now
+ .skip_category("JS"),
Review comment:
Isn't it `generate_dictionary_unsigned_case` that should be skipped instead?
##########
File path: dev/archery/archery/integration/datagen.py
##########
@@ -1401,9 +1401,8 @@ def generate_nested_case():
get_field('item', 'int32'), 4),
StructField('struct_nullable', [get_field('f1', 'int32'),
get_field('f2', 'utf8')]),
- # Fails on Go (ARROW-8452)
- # ListField('list_nonnullable', get_field('item', 'int32'),
- # nullable=False),
+ ListField('list_nonnullable', get_field('item', 'int32'),
+ nullable=False),
Review comment:
Perhaps make a separate `generate_non_nullable_list_case` so that other nested cases can still be checked on Go?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12198: [Minor] Fixed integration test for nested
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12198:
URL: https://github.com/apache/arrow/pull/12198#issuecomment-1017154115
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW
Opening JIRAs ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename pull request title in the following format?
ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org