You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by ov...@apache.org on 2019/03/07 12:10:13 UTC
[incubator-echarts] 02/02: docs: update contributing
This is an automated email from the ASF dual-hosted git repository.
ovilia pushed a commit to branch docs-contributing
in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git
commit a7e40f721575a8d0d7aa1bb1b8578b6d1638d2de
Author: Ovilia <zw...@gmail.com>
AuthorDate: Thu Mar 7 20:06:50 2019 +0800
docs: update contributing
---
.github/CONTRIBUTING.md | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.github/CONTRIBUTING.md b/.github/CONTRIBUTING.md
index 148aa69..4d75f0c 100644
--- a/.github/CONTRIBUTING.md
+++ b/.github/CONTRIBUTING.md
@@ -81,6 +81,6 @@ Then, open the test cases under `~/workspace/echarts/test` in Web browser. You c
Fork ECharts project into your own project. Checkout a branch from master branch named `fix-xxxx`, where xxxx is the issue id related. If there's no related issue, you need to create one in most cases to describe what's wrong or what new feature is required.
-If you are a committer of apache/incubator-echarts project, which means you have the write access to the project, you still need to push to a new branch and use pull request to push your code. You cannot push code directly to `master` branch, otherwise it will be rejected by GitHub.
+If you are a committer of apache/incubator-echarts project, which means you have the write access to the project, you still need to push to a new branch (by `git push origin HEAD:refs/heads/fix-xxxx`) and use pull request to push your code. You cannot push code directly to `master` branch, otherwise it will be rejected by GitHub.
Once your PR is merged, you will be asked to assign a PDF file called [Apache ICLA](https://www.apache.org/licenses/icla.pdf). This is required for all non-trival commits of apache/incubator-echarts project, which means you don't have to sign it if you only changed some spelling in `README.md`.
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org