You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2020/05/11 10:08:21 UTC

[GitHub] [maven-scm] michael-o commented on a change in pull request #101: [SCM-937] replace deprecated methods

michael-o commented on a change in pull request #101:
URL: https://github.com/apache/maven-scm/pull/101#discussion_r422930910



##########
File path: maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/src/test/java/org/apache/maven/scm/provider/git/gitexe/command/status/GitStatusConsumerTest.java
##########
@@ -52,9 +52,7 @@
     {
         GitStatusConsumer consumer = new GitStatusConsumer( new DefaultLog(), null, relativeRepoPath );
 
-        BufferedReader r = new BufferedReader( new FileReader( gitlog ) );
-
-        try
+        try ( BufferedReader r = new BufferedReader( new FileReader( gitlog ) ) )

Review comment:
       We should create another issue here because it is subject to character conversion.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org