You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by "pan3793 (via GitHub)" <gi...@apache.org> on 2024/04/07 03:10:29 UTC

Re: [PR] [KYUUBI #6252] Upgrade hive-service-rpc 4.0.0 [kyuubi]

pan3793 commented on code in PR #6262:
URL: https://github.com/apache/kyuubi/pull/6262#discussion_r1554805661


##########
kyuubi-common/src/main/scala/org/apache/kyuubi/service/TFrontendService.scala:
##########
@@ -594,6 +594,45 @@ abstract class TFrontendService(name: String)
     resp
   }
 
+  override def UploadData(req: TUploadDataReq): TUploadDataResp = {
+    val resp = new TUploadDataResp()

Review Comment:
   the Kyuubi's implementation is not fully same as Hive, let's throw UnsupportedOperationException here directly, then we don't need to modify other classes



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org