[GitHub] [incubator-superset] john-bodley commented on pull request #9882: fix: old unique constraint remnance

[GitBox <gi...@apache.org>]

john-bodley commented on pull request #9882:
URL: https://github.com/apache/incubator-superset/pull/9882#issuecomment-633654273


   @villebro regarding the the naming conventions I agree we should explicitly define constraints (per the naming conventions) when we define the models to ensure consistency. Note there are a number of migrations ([example](https://github.com/apache/incubator-superset/pull/5449)) which leverage this logic. Note we also have utility functions (`generic_find_fk_constraint_name`, `generic_find_uq_constraint_name`, etc.) to obtain the constraints.  


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org