[GitHub] [orc] guiyanakuang commented on a change in pull request #914: ORC-1006: Build and test in github workflow using the maven version specified in pom

[GitBox <gi...@apache.org>]

guiyanakuang commented on a change in pull request #914:
URL: https://github.com/apache/orc/pull/914#discussion_r711971572



##########
File path: .github/workflows/build_and_test.yml
##########
@@ -40,6 +40,12 @@ jobs:
       uses: actions/setup-java@v1
       with:
         java-version: ${{ matrix.java }}
+    - name: Set maven version to env
+      run: echo "maven_version=$(grep "<maven.version>" "./java/pom.xml" | head -n1 | awk -F '[<>]' '{print $3}')" >> $GITHUB_ENV
+    - name: Set up Maven ${{ env.maven_version }}
+      uses: stCarolas/setup-maven@v4

Review comment:
       Oh, I hadn't noticed that, just a moment while I make sure.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org