You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/25 10:22:24 UTC
[GitHub] [arrow-datafusion] alamb opened a new pull request, #2333: Improve sql_integ test organization
alamb opened a new pull request, #2333:
URL: https://github.com/apache/arrow-datafusion/pull/2333
# Which issue does this PR close?
re https://github.com/apache/arrow-datafusion/issues/2328
Minor follow on to https://github.com/apache/arrow-datafusion/pull/2329
# Rationale for this change
@WinkerDu moved most of the tests out of context ❤️ into sql_integ test which is a much better place. However I think some of the tests could be in slightly different modules.
# What changes are included in this PR?
Move some code around, no functional changes intended
# Are there any user-facing changes?
No, test only change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] yjshen merged pull request #2333: Improve sql integration test organization
Posted by GitBox <gi...@apache.org>.
yjshen merged PR #2333:
URL: https://github.com/apache/arrow-datafusion/pull/2333
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #2333: Improve sql_integ test organization
Posted by GitBox <gi...@apache.org>.
alamb commented on code in PR #2333:
URL: https://github.com/apache/arrow-datafusion/pull/2333#discussion_r857477477
##########
datafusion/core/tests/sql/group_by.rs:
##########
@@ -496,53 +496,49 @@ async fn group_by_date_trunc() -> Result<()> {
#[tokio::test]
async fn group_by_largeutf8() {
- {
- let ctx = SessionContext::new();
+ let ctx = SessionContext::new();
Review Comment:
This change just removes an extra level of (unecessary) indent
It is easier to see the change with https://github.com/apache/arrow-datafusion/pull/2333/files?w=1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org