You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/05/12 03:11:33 UTC
[GitHub] [apisix] bzp2010 opened a new pull request, #7032: feat: support kafka pubsub
bzp2010 opened a new pull request, #7032:
URL: https://github.com/apache/apisix/pull/7032
### Description
<!-- Please include a summary of the change and which issue is fixed. -->
<!-- Please also include relevant motivation and context. -->
Provide kafka implementation on pubsub framework.
Split from #6995
### Checklist
- [x] I have explained the need for this PR and the problem it solves
- [x] I have explained the changes or the new features added to this PR
- [x] I have added tests corresponding to this change
- [x] I have updated the documentation to reflect this change
- [x] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first)
<!--
Note
1. Mark the PR as draft until it's ready to be reviewed.
2. Always add/update tests for any changes unless you have a good reason.
3. Always update the documentation to reflect the changes made in the PR.
4. Make a new commit to resolve conversations instead of `push -f`.
5. To resolve merge conflicts, merge master instead of rebasing.
6. Use "request review" to notify the reviewer after making changes.
7. Only a reviewer can mark a conversation as resolved.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a diff in pull request #7032: feat(pubsub): support kafka
Posted by GitBox <gi...@apache.org>.
spacewander commented on code in PR #7032:
URL: https://github.com/apache/apisix/pull/7032#discussion_r873169258
##########
docs/en/latest/pubsub/kafka.md:
##########
@@ -0,0 +1,91 @@
+---
+title: Apache Kafka
+keywords:
+ - APISIX
+ - Pub-Sub
+ - Kafka
+description: This document contains information about the Apache APISIX kafka pub-sub scenario.
+---
+
+<!--
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+-->
+
+## Connect to Apache Kafka
+
+Connecting to Apache Kafka in Apache APISIX is very simple.
+
+Currently we provide a simpler way to integrate by combining two APIs, ListOffsets and Fetch, to quickly implement the ability to pull Kafka messages, but do not support Apache Kafka's consumer group feature for now, and cannot be managed by Kafka for offsets.
+
+### Limitations
+
+- Offsets need to be managed manually
Review Comment:
After rendering, these two lines are merged together...
##########
t/pubsub/kafka.t:
##########
@@ -0,0 +1,229 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+use t::APISIX 'no_plan';
+
+repeat_each(1);
+no_long_string();
+no_root_location();
+
+add_block_preprocessor(sub {
+ my ($block) = @_;
+
+ if ((!defined $block->error_log) && (!defined $block->no_error_log)) {
+ $block->set_value("no_error_log", "[error]");
+ }
+
+ if (!defined $block->request) {
+ $block->set_value("request", "GET /t");
+ }
+});
+
+run_tests();
+
+__DATA__
+
+=== TEST 1: setup all-in-one test
+--- config
+ location /t {
+ content_by_lua_block {
+ local data = {
+ {
+ url = "/apisix/admin/routes/kafka",
+ data = [[{
+ "upstream": {
+ "nodes": {
+ "127.0.0.1:9092": 1
+ },
+ "type": "none",
+ "scheme": "kafka"
+ },
+ "uri": "/kafka"
+ }]],
+ },
+ {
+ url = "/apisix/admin/routes/kafka-invalid",
+ data = [[{
+ "upstream": {
+ "nodes": {
+ "127.0.0.1:59092": 1
+ },
+ "type": "none",
+ "scheme": "kafka"
+ },
+ "uri": "/kafka-invalid"
+ }]],
+ },
+ }
+
+ local t = require("lib.test_admin").test
+
+ for _, data in ipairs(data) do
+ local code, body = t(data.url, ngx.HTTP_PUT, data.data)
+ ngx.say(body)
+ end
+ }
+ }
+--- response_body eval
+"passed\n"x2
+
+
+
+=== TEST 2: hit route (with HTTP request)
+--- request
+GET /kafka
+--- error_code: 400
+--- error_log
+failed to initialize pubsub module, err: bad "upgrade" request header: nil
+
+
+
+=== TEST 3: hit route (Kafka)
+--- config
+ # The messages used in this test are produced in the linux-ci-init-service.sh
+ # script that prepares the CI environment
+ location /t {
+ content_by_lua_block {
+ local lib_pubsub = require("lib.pubsub")
+ local test_pubsub = lib_pubsub.new_ws("ws://127.0.0.1:1984/kafka")
+ local data = {
+ {
+ sequence = 0,
+ cmd_kafka_list_offset = {
+ topic = "not-exist",
+ partition = 0,
+ timestamp = -1,
+ },
+ },
+ {
+ sequence = 1,
+ cmd_kafka_fetch = {
+ topic = "not-exist",
+ partition = 0,
+ offset = 0,
+ },
+ },
+ {
+ -- Query first message offset
+ sequence = 2,
+ cmd_kafka_list_offset = {
+ topic = "test-consumer",
+ partition = 0,
+ timestamp = -2,
+ },
+ },
+ {
+ -- Query last message offset
+ sequence = 3,
+ cmd_kafka_list_offset = {
+ topic = "test-consumer",
+ partition = 0,
+ timestamp = -1,
+ },
+ },
+ {
+ -- Query by timestamp, 9999999999999 later than the
+ -- production time of any message
+ sequence = 4,
+ cmd_kafka_list_offset = {
+ topic = "test-consumer",
+ partition = 0,
+ timestamp = "9999999999999",
+ },
+ },
+ {
+ -- Query by timestamp, 1500000000000 ms earlier than the
+ -- production time of any message
+ sequence = 5,
+ cmd_kafka_list_offset = {
+ topic = "test-consumer",
+ partition = 0,
+ timestamp = "1500000000000",
+ },
+ },
+ {
+ sequence = 6,
+ cmd_kafka_fetch = {
+ topic = "test-consumer",
+ partition = 0,
+ offset = 14,
+ },
+ },
+ {
+ sequence = 7,
+ cmd_kafka_fetch = {
+ topic = "test-consumer",
+ partition = 0,
+ offset = 999,
+ },
+ },
+ }
+
+ for i = 1, #data do
+ local data = test_pubsub:send_recv_ws_binary(data[i])
+ if data.error_resp then
+ ngx.say(data.sequence..data.error_resp.message)
+ end
+ if data.kafka_list_offset_resp then
+ ngx.say(data.sequence.."offset: "..data.kafka_list_offset_resp.offset)
+ end
+ if data.kafka_fetch_resp then
+ ngx.say(data.sequence.."offset: "..data.kafka_fetch_resp.messages[1].offset..
+ " msg: "..data.kafka_fetch_resp.messages[1].value)
+ end
+ end
+ test_pubsub:close_ws()
+ }
+ }
+--- response_body
+0failed to list offset, topic: not-exist, partition: 0, err: not found topic
+1failed to fetch message, topic: not-exist, partition: 0, err: not found topic
+2offset: 0
+3offset: 30
Review Comment:
Better to doc where the data and offset are coming from
##########
docs/en/latest/pubsub/kafka.md:
##########
@@ -0,0 +1,91 @@
+---
+title: Apache Kafka
+keywords:
+ - APISIX
+ - Pub-Sub
Review Comment:
Could we use PubSub like pubsub in other places?
##########
docs/en/latest/pubsub/kafka.md:
##########
@@ -0,0 +1,91 @@
+---
+title: Apache Kafka
+keywords:
+ - APISIX
+ - Pub-Sub
+ - Kafka
+description: This document contains information about the Apache APISIX kafka pub-sub scenario.
+---
+
+<!--
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+-->
+
+## Connect to Apache Kafka
+
+Connecting to Apache Kafka in Apache APISIX is very simple.
+
+Currently we provide a simpler way to integrate by combining two APIs, ListOffsets and Fetch, to quickly implement the ability to pull Kafka messages, but do not support Apache Kafka's consumer group feature for now, and cannot be managed by Kafka for offsets.
+
+### Limitations
+
+- Offsets need to be managed manually
+They can be stored by a custom backend service or obtained via the list_offset command before starting to fetch the message, which can use timestamp to get the starting offset, or to get the initial and end offsets.
+- Unsupported batch data acquisition
+A single instruction can only obtain the data of a Topic Partition, does not support batch data acquisition through a single instruction
+
+### Prepare
+
+First, it is necessary to compile the [communication protocol](../../../../apisix/pubsub.proto) as a language-specific SDK using the `protoc`, which provides the command and response definitions to connect to Kafka via APISIX using the WebSocket.
Review Comment:
Let's update the path of definition. We should use absolute path as it's not in website
##########
apisix/pubsub/kafka.lua:
##########
@@ -0,0 +1,133 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributor license agreements. See the NOTICE file distributed with
+-- this work for additional information regarding copyright ownership.
+-- The ASF licenses this file to You under the Apache License, Version 2.0
+-- (the "License"); you may not use this file except in compliance with
+-- the License. You may obtain a copy of the License at
+--
+-- http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing, software
+-- distributed under the License is distributed on an "AS IS" BASIS,
+-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-- See the License for the specific language governing permissions and
+-- limitations under the License.
+--
+
+local core = require("apisix.core")
+local bconsumer = require("resty.kafka.basic-consumer")
+local ffi = require("ffi")
+local C = ffi.C
+local tostring = tostring
+local type = type
+local ipairs = ipairs
+local str_sub = string.sub
+
+ffi.cdef[[
+ int64_t atoll(const char *num);
+]]
+
+
+local _M = {}
+
+
+-- Handles the conversion of 64-bit integers in the lua-protobuf.
+--
+-- Because of the limitations of luajit, we cannot use native 64-bit
+-- numbers, so pb decode converts int64 to a string in #xxx format
+-- to avoid loss of precision, by this function, we convert this
+-- string to int64 cdata numbers.
+local function pb_convert_to_int64(src)
+ if type(src) == "string" then
+ return C.atoll(ffi.cast("char *", src) + 1)
Review Comment:
Let's check src length to avoid out of bound
##########
apisix/include/apisix/model/pubsub.proto:
##########
@@ -55,16 +73,18 @@ message CmdEmpty {}
message PubSubReq {
int64 sequence = 1;
oneof req {
- CmdEmpty cmd_empty = 31;
- CmdPing cmd_ping = 32;
+ CmdEmpty cmd_empty = 31;
Review Comment:
We can remove cmd_empty which is test-only? Using `cmd_kafka_fetch` in pubsub.t is enough.
##########
docs/en/latest/pubsub.md:
##########
@@ -42,6 +42,10 @@ In Apache APISIX, the most common scenario is handling north-south traffic from
Currently, Apache APISIX supports WebSocket communication with the client, which can be any application that supports WebSocket, with Protocol Buffer as the serialization mechanism, see the [protocol definition](../../../apisix/pubsub.proto).
Review Comment:
Let's update the path of definition. We should use absolute path as it's not in website
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] bzp2010 commented on a diff in pull request #7032: feat(pubsub): support kafka
Posted by GitBox <gi...@apache.org>.
bzp2010 commented on code in PR #7032:
URL: https://github.com/apache/apisix/pull/7032#discussion_r873173242
##########
docs/en/latest/pubsub/kafka.md:
##########
@@ -0,0 +1,91 @@
+---
+title: Apache Kafka
+keywords:
+ - APISIX
+ - Pub-Sub
+ - Kafka
+description: This document contains information about the Apache APISIX kafka pub-sub scenario.
+---
+
+<!--
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+-->
+
+## Connect to Apache Kafka
+
+Connecting to Apache Kafka in Apache APISIX is very simple.
+
+Currently we provide a simpler way to integrate by combining two APIs, ListOffsets and Fetch, to quickly implement the ability to pull Kafka messages, but do not support Apache Kafka's consumer group feature for now, and cannot be managed by Kafka for offsets.
+
+### Limitations
+
+- Offsets need to be managed manually
+They can be stored by a custom backend service or obtained via the list_offset command before starting to fetch the message, which can use timestamp to get the starting offset, or to get the initial and end offsets.
+- Unsupported batch data acquisition
+A single instruction can only obtain the data of a Topic Partition, does not support batch data acquisition through a single instruction
+
+### Prepare
+
+First, it is necessary to compile the [communication protocol](../../../../apisix/pubsub.proto) as a language-specific SDK using the `protoc`, which provides the command and response definitions to connect to Kafka via APISIX using the WebSocket.
Review Comment:
changed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] bzp2010 commented on a diff in pull request #7032: feat(pubsub): support kafka
Posted by GitBox <gi...@apache.org>.
bzp2010 commented on code in PR #7032:
URL: https://github.com/apache/apisix/pull/7032#discussion_r873389021
##########
apisix/pubsub/kafka.lua:
##########
@@ -0,0 +1,137 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributor license agreements. See the NOTICE file distributed with
+-- this work for additional information regarding copyright ownership.
+-- The ASF licenses this file to You under the Apache License, Version 2.0
+-- (the "License"); you may not use this file except in compliance with
+-- the License. You may obtain a copy of the License at
+--
+-- http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing, software
+-- distributed under the License is distributed on an "AS IS" BASIS,
+-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-- See the License for the specific language governing permissions and
+-- limitations under the License.
+--
+
+local core = require("apisix.core")
+local bconsumer = require("resty.kafka.basic-consumer")
+local ffi = require("ffi")
+local C = ffi.C
+local tostring = tostring
+local type = type
+local ipairs = ipairs
+local str_sub = string.sub
+
+ffi.cdef[[
+ int64_t atoll(const char *num);
+]]
+
+
+local _M = {}
+
+
+-- Handles the conversion of 64-bit integers in the lua-protobuf.
+--
+-- Because of the limitations of luajit, we cannot use native 64-bit
+-- numbers, so pb decode converts int64 to a string in #xxx format
+-- to avoid loss of precision, by this function, we convert this
+-- string to int64 cdata numbers.
+local function pb_convert_to_int64(src)
+ if type(src) == "string" then
+ -- the format is #1234, so there is a small minimum length of 2
+ if #src < 2 then
+ return 0
+ end
+ return C.atoll(ffi.cast("char *", src) + 1)
+ else
+ return src
+ end
+end
+
+
+-- Takes over requests of type kafka upstream in the http_access phase.
+function _M.access(api_ctx)
+ local pubsub, err = core.pubsub.new()
+ if not pubsub then
+ core.log.error("failed to initialize pubsub module, err: ", err)
+ core.response.exit(400)
+ return
+ end
+
+ local up_nodes = api_ctx.matched_upstream.nodes
+
+ -- kafka client broker-related configuration
+ local broker_list = {}
+ for i, node in ipairs(up_nodes) do
+ broker_list[i] = {
+ host = node.host,
+ port = node.port,
+ }
+ end
+
+ local client_config = {refresh_interval = 30 * 60 * 1000}
+
+ -- load and create the consumer instance when it is determined
+ -- that the websocket connection was created successfully
+ local consumer = bconsumer:new(broker_list, client_config)
Review Comment:
No, it doesn't return a error, referer
https://github.com/doujiang24/lua-resty-kafka/blob/master/lib/resty/kafka/basic-consumer.lua#L10-L27
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] bzp2010 commented on a diff in pull request #7032: feat(pubsub): support kafka
Posted by GitBox <gi...@apache.org>.
bzp2010 commented on code in PR #7032:
URL: https://github.com/apache/apisix/pull/7032#discussion_r873172643
##########
t/pubsub/kafka.t:
##########
@@ -0,0 +1,229 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+use t::APISIX 'no_plan';
+
+repeat_each(1);
+no_long_string();
+no_root_location();
+
+add_block_preprocessor(sub {
+ my ($block) = @_;
+
+ if ((!defined $block->error_log) && (!defined $block->no_error_log)) {
+ $block->set_value("no_error_log", "[error]");
+ }
+
+ if (!defined $block->request) {
+ $block->set_value("request", "GET /t");
+ }
+});
+
+run_tests();
+
+__DATA__
+
+=== TEST 1: setup all-in-one test
+--- config
+ location /t {
+ content_by_lua_block {
+ local data = {
+ {
+ url = "/apisix/admin/routes/kafka",
+ data = [[{
+ "upstream": {
+ "nodes": {
+ "127.0.0.1:9092": 1
+ },
+ "type": "none",
+ "scheme": "kafka"
+ },
+ "uri": "/kafka"
+ }]],
+ },
+ {
+ url = "/apisix/admin/routes/kafka-invalid",
+ data = [[{
+ "upstream": {
+ "nodes": {
+ "127.0.0.1:59092": 1
+ },
+ "type": "none",
+ "scheme": "kafka"
+ },
+ "uri": "/kafka-invalid"
+ }]],
+ },
+ }
+
+ local t = require("lib.test_admin").test
+
+ for _, data in ipairs(data) do
+ local code, body = t(data.url, ngx.HTTP_PUT, data.data)
+ ngx.say(body)
+ end
+ }
+ }
+--- response_body eval
+"passed\n"x2
+
+
+
+=== TEST 2: hit route (with HTTP request)
+--- request
+GET /kafka
+--- error_code: 400
+--- error_log
+failed to initialize pubsub module, err: bad "upgrade" request header: nil
+
+
+
+=== TEST 3: hit route (Kafka)
+--- config
+ # The messages used in this test are produced in the linux-ci-init-service.sh
+ # script that prepares the CI environment
+ location /t {
+ content_by_lua_block {
+ local lib_pubsub = require("lib.pubsub")
+ local test_pubsub = lib_pubsub.new_ws("ws://127.0.0.1:1984/kafka")
+ local data = {
+ {
+ sequence = 0,
+ cmd_kafka_list_offset = {
+ topic = "not-exist",
+ partition = 0,
+ timestamp = -1,
+ },
+ },
+ {
+ sequence = 1,
+ cmd_kafka_fetch = {
+ topic = "not-exist",
+ partition = 0,
+ offset = 0,
+ },
+ },
+ {
+ -- Query first message offset
+ sequence = 2,
+ cmd_kafka_list_offset = {
+ topic = "test-consumer",
+ partition = 0,
+ timestamp = -2,
+ },
+ },
+ {
+ -- Query last message offset
+ sequence = 3,
+ cmd_kafka_list_offset = {
+ topic = "test-consumer",
+ partition = 0,
+ timestamp = -1,
+ },
+ },
+ {
+ -- Query by timestamp, 9999999999999 later than the
+ -- production time of any message
+ sequence = 4,
+ cmd_kafka_list_offset = {
+ topic = "test-consumer",
+ partition = 0,
+ timestamp = "9999999999999",
+ },
+ },
+ {
+ -- Query by timestamp, 1500000000000 ms earlier than the
+ -- production time of any message
+ sequence = 5,
+ cmd_kafka_list_offset = {
+ topic = "test-consumer",
+ partition = 0,
+ timestamp = "1500000000000",
+ },
+ },
+ {
+ sequence = 6,
+ cmd_kafka_fetch = {
+ topic = "test-consumer",
+ partition = 0,
+ offset = 14,
+ },
+ },
+ {
+ sequence = 7,
+ cmd_kafka_fetch = {
+ topic = "test-consumer",
+ partition = 0,
+ offset = 999,
+ },
+ },
+ }
+
+ for i = 1, #data do
+ local data = test_pubsub:send_recv_ws_binary(data[i])
+ if data.error_resp then
+ ngx.say(data.sequence..data.error_resp.message)
+ end
+ if data.kafka_list_offset_resp then
+ ngx.say(data.sequence.."offset: "..data.kafka_list_offset_resp.offset)
+ end
+ if data.kafka_fetch_resp then
+ ngx.say(data.sequence.."offset: "..data.kafka_fetch_resp.messages[1].offset..
+ " msg: "..data.kafka_fetch_resp.messages[1].value)
+ end
+ end
+ test_pubsub:close_ws()
+ }
+ }
+--- response_body
+0failed to list offset, topic: not-exist, partition: 0, err: not found topic
+1failed to fetch message, topic: not-exist, partition: 0, err: not found topic
+2offset: 0
+3offset: 30
Review Comment:
It's exist now, it's at L96-L97 https://github.com/apache/apisix/blob/8ed6673664b3f59aef8b6f17d7c10fe3019328bb/t/pubsub/kafka.t#L94-L99
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tzssangglass commented on a diff in pull request #7032: feat(pubsub): support kafka
Posted by GitBox <gi...@apache.org>.
tzssangglass commented on code in PR #7032:
URL: https://github.com/apache/apisix/pull/7032#discussion_r873425679
##########
apisix/pubsub/kafka.lua:
##########
@@ -0,0 +1,137 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributor license agreements. See the NOTICE file distributed with
+-- this work for additional information regarding copyright ownership.
+-- The ASF licenses this file to You under the Apache License, Version 2.0
+-- (the "License"); you may not use this file except in compliance with
+-- the License. You may obtain a copy of the License at
+--
+-- http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing, software
+-- distributed under the License is distributed on an "AS IS" BASIS,
+-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-- See the License for the specific language governing permissions and
+-- limitations under the License.
+--
+
+local core = require("apisix.core")
+local bconsumer = require("resty.kafka.basic-consumer")
+local ffi = require("ffi")
+local C = ffi.C
+local tostring = tostring
+local type = type
+local ipairs = ipairs
+local str_sub = string.sub
+
+ffi.cdef[[
+ int64_t atoll(const char *num);
+]]
+
+
+local _M = {}
+
+
+-- Handles the conversion of 64-bit integers in the lua-protobuf.
+--
+-- Because of the limitations of luajit, we cannot use native 64-bit
+-- numbers, so pb decode converts int64 to a string in #xxx format
+-- to avoid loss of precision, by this function, we convert this
+-- string to int64 cdata numbers.
+local function pb_convert_to_int64(src)
+ if type(src) == "string" then
+ -- the format is #1234, so there is a small minimum length of 2
+ if #src < 2 then
+ return 0
+ end
+ return C.atoll(ffi.cast("char *", src) + 1)
+ else
+ return src
+ end
+end
+
+
+-- Takes over requests of type kafka upstream in the http_access phase.
+function _M.access(api_ctx)
+ local pubsub, err = core.pubsub.new()
+ if not pubsub then
+ core.log.error("failed to initialize pubsub module, err: ", err)
+ core.response.exit(400)
+ return
+ end
+
+ local up_nodes = api_ctx.matched_upstream.nodes
+
+ -- kafka client broker-related configuration
+ local broker_list = {}
+ for i, node in ipairs(up_nodes) do
+ broker_list[i] = {
+ host = node.host,
+ port = node.port,
+ }
+ end
+
+ local client_config = {refresh_interval = 30 * 60 * 1000}
Review Comment:
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] bzp2010 commented on a diff in pull request #7032: feat(pubsub): support kafka
Posted by GitBox <gi...@apache.org>.
bzp2010 commented on code in PR #7032:
URL: https://github.com/apache/apisix/pull/7032#discussion_r873164988
##########
t/admin/upstream5.t:
##########
@@ -0,0 +1,61 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+use t::APISIX 'no_plan';
Review Comment:
@membphis This is just because the previous `upstreamX` test contains too many lines, and it does not point to the upstream scheme test of "Kafka", future upstream-related tests can also be added to this file (this test was moved here from t/node), which only tests whether the kafka upstream in the Admin API can be created properly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a diff in pull request #7032: feat(pubsub): support kafka
Posted by GitBox <gi...@apache.org>.
spacewander commented on code in PR #7032:
URL: https://github.com/apache/apisix/pull/7032#discussion_r873170726
##########
docs/en/latest/pubsub/kafka.md:
##########
@@ -0,0 +1,91 @@
+---
+title: Apache Kafka
+keywords:
+ - APISIX
+ - Pub-Sub
+ - Kafka
+description: This document contains information about the Apache APISIX kafka pub-sub scenario.
+---
+
+<!--
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+-->
+
+## Connect to Apache Kafka
+
+Connecting to Apache Kafka in Apache APISIX is very simple.
+
+Currently we provide a simpler way to integrate by combining two APIs, ListOffsets and Fetch, to quickly implement the ability to pull Kafka messages, but do not support Apache Kafka's consumer group feature for now, and cannot be managed by Kafka for offsets.
+
+### Limitations
+
+- Offsets need to be managed manually
Review Comment:
<img width="913" alt="微信截图_20220515213346" src="https://user-images.githubusercontent.com/4161644/168475620-65e1e881-b38a-4c0c-9aaf-784a1d67e814.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] bzp2010 commented on a diff in pull request #7032: feat(pubsub): support kafka
Posted by GitBox <gi...@apache.org>.
bzp2010 commented on code in PR #7032:
URL: https://github.com/apache/apisix/pull/7032#discussion_r873393964
##########
apisix/pubsub/kafka.lua:
##########
@@ -0,0 +1,137 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributor license agreements. See the NOTICE file distributed with
+-- this work for additional information regarding copyright ownership.
+-- The ASF licenses this file to You under the Apache License, Version 2.0
+-- (the "License"); you may not use this file except in compliance with
+-- the License. You may obtain a copy of the License at
+--
+-- http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing, software
+-- distributed under the License is distributed on an "AS IS" BASIS,
+-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-- See the License for the specific language governing permissions and
+-- limitations under the License.
+--
+
+local core = require("apisix.core")
+local bconsumer = require("resty.kafka.basic-consumer")
+local ffi = require("ffi")
+local C = ffi.C
+local tostring = tostring
+local type = type
+local ipairs = ipairs
+local str_sub = string.sub
+
+ffi.cdef[[
+ int64_t atoll(const char *num);
+]]
+
+
+local _M = {}
+
+
+-- Handles the conversion of 64-bit integers in the lua-protobuf.
+--
+-- Because of the limitations of luajit, we cannot use native 64-bit
+-- numbers, so pb decode converts int64 to a string in #xxx format
+-- to avoid loss of precision, by this function, we convert this
+-- string to int64 cdata numbers.
+local function pb_convert_to_int64(src)
+ if type(src) == "string" then
+ -- the format is #1234, so there is a small minimum length of 2
+ if #src < 2 then
+ return 0
+ end
+ return C.atoll(ffi.cast("char *", src) + 1)
+ else
+ return src
+ end
+end
+
+
+-- Takes over requests of type kafka upstream in the http_access phase.
+function _M.access(api_ctx)
+ local pubsub, err = core.pubsub.new()
+ if not pubsub then
+ core.log.error("failed to initialize pubsub module, err: ", err)
+ core.response.exit(400)
Review Comment:
No, the most common problem with initialization errors here is that the websocket fails to connect correctly, usually because the client does not send information such as the Upgrade header correctly, 400 code is fit. (Another error is that the protocol fails to load, but it basically does not appear
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] bzp2010 commented on a diff in pull request #7032: feat(pubsub): support kafka
Posted by GitBox <gi...@apache.org>.
bzp2010 commented on code in PR #7032:
URL: https://github.com/apache/apisix/pull/7032#discussion_r873164988
##########
t/admin/upstream5.t:
##########
@@ -0,0 +1,61 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+use t::APISIX 'no_plan';
Review Comment:
@membphis This is just because the previous `upstreamX` test contains too many lines, and it does not point to the upstream type test of "Kafka".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tzssangglass commented on a diff in pull request #7032: feat(pubsub): support kafka
Posted by GitBox <gi...@apache.org>.
tzssangglass commented on code in PR #7032:
URL: https://github.com/apache/apisix/pull/7032#discussion_r873291901
##########
docs/en/latest/pubsub/kafka.md:
##########
@@ -0,0 +1,94 @@
+---
+title: Apache Kafka
+keywords:
+ - APISIX
+ - PubSub
+ - Kafka
+description: This document contains information about the Apache APISIX kafka pubsub scenario.
+---
+
+<!--
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+-->
+
+## Connect to Apache Kafka
+
+Connecting to Apache Kafka in Apache APISIX is very simple.
+
+Currently we provide a simpler way to integrate by combining two APIs, ListOffsets and Fetch, to quickly implement the ability to pull Kafka messages, but do not support Apache Kafka's consumer group feature for now, and cannot be managed by Kafka for offsets.
Review Comment:
```suggestion
Currently, we provide a simpler way to integrate by combining two APIs, ListOffsets and Fetch, to quickly implement the ability to pull Kafka messages. Still, they do not support Apache Kafka's consumer group feature for now and cannot be managed for offsets by Apache Kafka.
```
##########
apisix/pubsub/kafka.lua:
##########
@@ -0,0 +1,137 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributor license agreements. See the NOTICE file distributed with
+-- this work for additional information regarding copyright ownership.
+-- The ASF licenses this file to You under the Apache License, Version 2.0
+-- (the "License"); you may not use this file except in compliance with
+-- the License. You may obtain a copy of the License at
+--
+-- http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing, software
+-- distributed under the License is distributed on an "AS IS" BASIS,
+-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-- See the License for the specific language governing permissions and
+-- limitations under the License.
+--
+
+local core = require("apisix.core")
+local bconsumer = require("resty.kafka.basic-consumer")
+local ffi = require("ffi")
+local C = ffi.C
+local tostring = tostring
+local type = type
+local ipairs = ipairs
+local str_sub = string.sub
+
+ffi.cdef[[
+ int64_t atoll(const char *num);
+]]
+
+
+local _M = {}
+
+
+-- Handles the conversion of 64-bit integers in the lua-protobuf.
+--
+-- Because of the limitations of luajit, we cannot use native 64-bit
+-- numbers, so pb decode converts int64 to a string in #xxx format
+-- to avoid loss of precision, by this function, we convert this
+-- string to int64 cdata numbers.
+local function pb_convert_to_int64(src)
+ if type(src) == "string" then
+ -- the format is #1234, so there is a small minimum length of 2
+ if #src < 2 then
+ return 0
+ end
+ return C.atoll(ffi.cast("char *", src) + 1)
+ else
+ return src
+ end
+end
+
+
+-- Takes over requests of type kafka upstream in the http_access phase.
+function _M.access(api_ctx)
+ local pubsub, err = core.pubsub.new()
+ if not pubsub then
+ core.log.error("failed to initialize pubsub module, err: ", err)
+ core.response.exit(400)
Review Comment:
502 is better? Here it looks more like an error related to upstream.
##########
apisix/pubsub/kafka.lua:
##########
@@ -0,0 +1,137 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributor license agreements. See the NOTICE file distributed with
+-- this work for additional information regarding copyright ownership.
+-- The ASF licenses this file to You under the Apache License, Version 2.0
+-- (the "License"); you may not use this file except in compliance with
+-- the License. You may obtain a copy of the License at
+--
+-- http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing, software
+-- distributed under the License is distributed on an "AS IS" BASIS,
+-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-- See the License for the specific language governing permissions and
+-- limitations under the License.
+--
+
+local core = require("apisix.core")
+local bconsumer = require("resty.kafka.basic-consumer")
+local ffi = require("ffi")
+local C = ffi.C
+local tostring = tostring
+local type = type
+local ipairs = ipairs
+local str_sub = string.sub
+
+ffi.cdef[[
+ int64_t atoll(const char *num);
+]]
+
+
+local _M = {}
+
+
+-- Handles the conversion of 64-bit integers in the lua-protobuf.
+--
+-- Because of the limitations of luajit, we cannot use native 64-bit
+-- numbers, so pb decode converts int64 to a string in #xxx format
+-- to avoid loss of precision, by this function, we convert this
+-- string to int64 cdata numbers.
+local function pb_convert_to_int64(src)
+ if type(src) == "string" then
+ -- the format is #1234, so there is a small minimum length of 2
+ if #src < 2 then
+ return 0
+ end
+ return C.atoll(ffi.cast("char *", src) + 1)
+ else
+ return src
+ end
+end
+
+
+-- Takes over requests of type kafka upstream in the http_access phase.
+function _M.access(api_ctx)
+ local pubsub, err = core.pubsub.new()
+ if not pubsub then
+ core.log.error("failed to initialize pubsub module, err: ", err)
+ core.response.exit(400)
+ return
+ end
+
+ local up_nodes = api_ctx.matched_upstream.nodes
+
+ -- kafka client broker-related configuration
+ local broker_list = {}
+ for i, node in ipairs(up_nodes) do
+ broker_list[i] = {
+ host = node.host,
+ port = node.port,
+ }
+ end
+
+ local client_config = {refresh_interval = 30 * 60 * 1000}
+
+ -- load and create the consumer instance when it is determined
+ -- that the websocket connection was created successfully
+ local consumer = bconsumer:new(broker_list, client_config)
Review Comment:
should we check if `consumer` created success?
##########
apisix/pubsub/kafka.lua:
##########
@@ -0,0 +1,137 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributor license agreements. See the NOTICE file distributed with
+-- this work for additional information regarding copyright ownership.
+-- The ASF licenses this file to You under the Apache License, Version 2.0
+-- (the "License"); you may not use this file except in compliance with
+-- the License. You may obtain a copy of the License at
+--
+-- http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing, software
+-- distributed under the License is distributed on an "AS IS" BASIS,
+-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-- See the License for the specific language governing permissions and
+-- limitations under the License.
+--
+
+local core = require("apisix.core")
+local bconsumer = require("resty.kafka.basic-consumer")
+local ffi = require("ffi")
+local C = ffi.C
+local tostring = tostring
+local type = type
+local ipairs = ipairs
+local str_sub = string.sub
+
+ffi.cdef[[
+ int64_t atoll(const char *num);
+]]
+
+
+local _M = {}
+
+
+-- Handles the conversion of 64-bit integers in the lua-protobuf.
+--
+-- Because of the limitations of luajit, we cannot use native 64-bit
+-- numbers, so pb decode converts int64 to a string in #xxx format
+-- to avoid loss of precision, by this function, we convert this
+-- string to int64 cdata numbers.
+local function pb_convert_to_int64(src)
+ if type(src) == "string" then
+ -- the format is #1234, so there is a small minimum length of 2
+ if #src < 2 then
+ return 0
+ end
+ return C.atoll(ffi.cast("char *", src) + 1)
+ else
+ return src
+ end
+end
+
+
+-- Takes over requests of type kafka upstream in the http_access phase.
+function _M.access(api_ctx)
+ local pubsub, err = core.pubsub.new()
+ if not pubsub then
+ core.log.error("failed to initialize pubsub module, err: ", err)
+ core.response.exit(400)
+ return
+ end
+
+ local up_nodes = api_ctx.matched_upstream.nodes
+
+ -- kafka client broker-related configuration
+ local broker_list = {}
+ for i, node in ipairs(up_nodes) do
+ broker_list[i] = {
+ host = node.host,
+ port = node.port,
+ }
+ end
+
+ local client_config = {refresh_interval = 30 * 60 * 1000}
Review Comment:
If this is a fixed configuration, can it be placed at module level, otherwise a table will be created every time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] bzp2010 commented on a diff in pull request #7032: feat(pubsub): support kafka
Posted by GitBox <gi...@apache.org>.
bzp2010 commented on code in PR #7032:
URL: https://github.com/apache/apisix/pull/7032#discussion_r873173490
##########
docs/en/latest/pubsub/kafka.md:
##########
@@ -0,0 +1,91 @@
+---
+title: Apache Kafka
+keywords:
+ - APISIX
+ - Pub-Sub
Review Comment:
All `Pub-Sub` replaced to `PubSub`
##########
docs/en/latest/pubsub.md:
##########
@@ -42,6 +42,10 @@ In Apache APISIX, the most common scenario is handling north-south traffic from
Currently, Apache APISIX supports WebSocket communication with the client, which can be any application that supports WebSocket, with Protocol Buffer as the serialization mechanism, see the [protocol definition](../../../apisix/pubsub.proto).
Review Comment:
changed
##########
apisix/pubsub/kafka.lua:
##########
@@ -0,0 +1,133 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributor license agreements. See the NOTICE file distributed with
+-- this work for additional information regarding copyright ownership.
+-- The ASF licenses this file to You under the Apache License, Version 2.0
+-- (the "License"); you may not use this file except in compliance with
+-- the License. You may obtain a copy of the License at
+--
+-- http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing, software
+-- distributed under the License is distributed on an "AS IS" BASIS,
+-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-- See the License for the specific language governing permissions and
+-- limitations under the License.
+--
+
+local core = require("apisix.core")
+local bconsumer = require("resty.kafka.basic-consumer")
+local ffi = require("ffi")
+local C = ffi.C
+local tostring = tostring
+local type = type
+local ipairs = ipairs
+local str_sub = string.sub
+
+ffi.cdef[[
+ int64_t atoll(const char *num);
+]]
+
+
+local _M = {}
+
+
+-- Handles the conversion of 64-bit integers in the lua-protobuf.
+--
+-- Because of the limitations of luajit, we cannot use native 64-bit
+-- numbers, so pb decode converts int64 to a string in #xxx format
+-- to avoid loss of precision, by this function, we convert this
+-- string to int64 cdata numbers.
+local function pb_convert_to_int64(src)
+ if type(src) == "string" then
+ return C.atoll(ffi.cast("char *", src) + 1)
Review Comment:
added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] bzp2010 commented on a diff in pull request #7032: feat(pubsub): support kafka
Posted by GitBox <gi...@apache.org>.
bzp2010 commented on code in PR #7032:
URL: https://github.com/apache/apisix/pull/7032#discussion_r873389021
##########
apisix/pubsub/kafka.lua:
##########
@@ -0,0 +1,137 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributor license agreements. See the NOTICE file distributed with
+-- this work for additional information regarding copyright ownership.
+-- The ASF licenses this file to You under the Apache License, Version 2.0
+-- (the "License"); you may not use this file except in compliance with
+-- the License. You may obtain a copy of the License at
+--
+-- http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing, software
+-- distributed under the License is distributed on an "AS IS" BASIS,
+-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-- See the License for the specific language governing permissions and
+-- limitations under the License.
+--
+
+local core = require("apisix.core")
+local bconsumer = require("resty.kafka.basic-consumer")
+local ffi = require("ffi")
+local C = ffi.C
+local tostring = tostring
+local type = type
+local ipairs = ipairs
+local str_sub = string.sub
+
+ffi.cdef[[
+ int64_t atoll(const char *num);
+]]
+
+
+local _M = {}
+
+
+-- Handles the conversion of 64-bit integers in the lua-protobuf.
+--
+-- Because of the limitations of luajit, we cannot use native 64-bit
+-- numbers, so pb decode converts int64 to a string in #xxx format
+-- to avoid loss of precision, by this function, we convert this
+-- string to int64 cdata numbers.
+local function pb_convert_to_int64(src)
+ if type(src) == "string" then
+ -- the format is #1234, so there is a small minimum length of 2
+ if #src < 2 then
+ return 0
+ end
+ return C.atoll(ffi.cast("char *", src) + 1)
+ else
+ return src
+ end
+end
+
+
+-- Takes over requests of type kafka upstream in the http_access phase.
+function _M.access(api_ctx)
+ local pubsub, err = core.pubsub.new()
+ if not pubsub then
+ core.log.error("failed to initialize pubsub module, err: ", err)
+ core.response.exit(400)
+ return
+ end
+
+ local up_nodes = api_ctx.matched_upstream.nodes
+
+ -- kafka client broker-related configuration
+ local broker_list = {}
+ for i, node in ipairs(up_nodes) do
+ broker_list[i] = {
+ host = node.host,
+ port = node.port,
+ }
+ end
+
+ local client_config = {refresh_interval = 30 * 60 * 1000}
+
+ -- load and create the consumer instance when it is determined
+ -- that the websocket connection was created successfully
+ local consumer = bconsumer:new(broker_list, client_config)
Review Comment:
No, it doesn't return a error, we don't need to do this, referer
https://github.com/doujiang24/lua-resty-kafka/blob/master/lib/resty/kafka/basic-consumer.lua#L10-L27
##########
docs/en/latest/pubsub/kafka.md:
##########
@@ -0,0 +1,94 @@
+---
+title: Apache Kafka
+keywords:
+ - APISIX
+ - PubSub
+ - Kafka
+description: This document contains information about the Apache APISIX kafka pubsub scenario.
+---
+
+<!--
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+-->
+
+## Connect to Apache Kafka
+
+Connecting to Apache Kafka in Apache APISIX is very simple.
+
+Currently we provide a simpler way to integrate by combining two APIs, ListOffsets and Fetch, to quickly implement the ability to pull Kafka messages, but do not support Apache Kafka's consumer group feature for now, and cannot be managed by Kafka for offsets.
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] bzp2010 commented on a diff in pull request #7032: feat(pubsub): support kafka
Posted by GitBox <gi...@apache.org>.
bzp2010 commented on code in PR #7032:
URL: https://github.com/apache/apisix/pull/7032#discussion_r873390195
##########
apisix/pubsub/kafka.lua:
##########
@@ -0,0 +1,137 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributor license agreements. See the NOTICE file distributed with
+-- this work for additional information regarding copyright ownership.
+-- The ASF licenses this file to You under the Apache License, Version 2.0
+-- (the "License"); you may not use this file except in compliance with
+-- the License. You may obtain a copy of the License at
+--
+-- http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing, software
+-- distributed under the License is distributed on an "AS IS" BASIS,
+-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-- See the License for the specific language governing permissions and
+-- limitations under the License.
+--
+
+local core = require("apisix.core")
+local bconsumer = require("resty.kafka.basic-consumer")
+local ffi = require("ffi")
+local C = ffi.C
+local tostring = tostring
+local type = type
+local ipairs = ipairs
+local str_sub = string.sub
+
+ffi.cdef[[
+ int64_t atoll(const char *num);
+]]
+
+
+local _M = {}
+
+
+-- Handles the conversion of 64-bit integers in the lua-protobuf.
+--
+-- Because of the limitations of luajit, we cannot use native 64-bit
+-- numbers, so pb decode converts int64 to a string in #xxx format
+-- to avoid loss of precision, by this function, we convert this
+-- string to int64 cdata numbers.
+local function pb_convert_to_int64(src)
+ if type(src) == "string" then
+ -- the format is #1234, so there is a small minimum length of 2
+ if #src < 2 then
+ return 0
+ end
+ return C.atoll(ffi.cast("char *", src) + 1)
+ else
+ return src
+ end
+end
+
+
+-- Takes over requests of type kafka upstream in the http_access phase.
+function _M.access(api_ctx)
+ local pubsub, err = core.pubsub.new()
+ if not pubsub then
+ core.log.error("failed to initialize pubsub module, err: ", err)
+ core.response.exit(400)
+ return
+ end
+
+ local up_nodes = api_ctx.matched_upstream.nodes
+
+ -- kafka client broker-related configuration
+ local broker_list = {}
+ for i, node in ipairs(up_nodes) do
+ broker_list[i] = {
+ host = node.host,
+ port = node.port,
+ }
+ end
+
+ local client_config = {refresh_interval = 30 * 60 * 1000}
Review Comment:
Later PR, it will accommodate individual upstream TLS configurations, each of them different, so a separate `client_config` is used here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] membphis commented on a diff in pull request #7032: feat(pubsub): support kafka
Posted by GitBox <gi...@apache.org>.
membphis commented on code in PR #7032:
URL: https://github.com/apache/apisix/pull/7032#discussion_r873164228
##########
t/admin/upstream5.t:
##########
@@ -0,0 +1,61 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+use t::APISIX 'no_plan';
Review Comment:
`t/admin/upstream5.t` we need a meaningful name
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] bzp2010 commented on a diff in pull request #7032: feat(pubsub): support kafka
Posted by GitBox <gi...@apache.org>.
bzp2010 commented on code in PR #7032:
URL: https://github.com/apache/apisix/pull/7032#discussion_r873172643
##########
t/pubsub/kafka.t:
##########
@@ -0,0 +1,229 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+use t::APISIX 'no_plan';
+
+repeat_each(1);
+no_long_string();
+no_root_location();
+
+add_block_preprocessor(sub {
+ my ($block) = @_;
+
+ if ((!defined $block->error_log) && (!defined $block->no_error_log)) {
+ $block->set_value("no_error_log", "[error]");
+ }
+
+ if (!defined $block->request) {
+ $block->set_value("request", "GET /t");
+ }
+});
+
+run_tests();
+
+__DATA__
+
+=== TEST 1: setup all-in-one test
+--- config
+ location /t {
+ content_by_lua_block {
+ local data = {
+ {
+ url = "/apisix/admin/routes/kafka",
+ data = [[{
+ "upstream": {
+ "nodes": {
+ "127.0.0.1:9092": 1
+ },
+ "type": "none",
+ "scheme": "kafka"
+ },
+ "uri": "/kafka"
+ }]],
+ },
+ {
+ url = "/apisix/admin/routes/kafka-invalid",
+ data = [[{
+ "upstream": {
+ "nodes": {
+ "127.0.0.1:59092": 1
+ },
+ "type": "none",
+ "scheme": "kafka"
+ },
+ "uri": "/kafka-invalid"
+ }]],
+ },
+ }
+
+ local t = require("lib.test_admin").test
+
+ for _, data in ipairs(data) do
+ local code, body = t(data.url, ngx.HTTP_PUT, data.data)
+ ngx.say(body)
+ end
+ }
+ }
+--- response_body eval
+"passed\n"x2
+
+
+
+=== TEST 2: hit route (with HTTP request)
+--- request
+GET /kafka
+--- error_code: 400
+--- error_log
+failed to initialize pubsub module, err: bad "upgrade" request header: nil
+
+
+
+=== TEST 3: hit route (Kafka)
+--- config
+ # The messages used in this test are produced in the linux-ci-init-service.sh
+ # script that prepares the CI environment
+ location /t {
+ content_by_lua_block {
+ local lib_pubsub = require("lib.pubsub")
+ local test_pubsub = lib_pubsub.new_ws("ws://127.0.0.1:1984/kafka")
+ local data = {
+ {
+ sequence = 0,
+ cmd_kafka_list_offset = {
+ topic = "not-exist",
+ partition = 0,
+ timestamp = -1,
+ },
+ },
+ {
+ sequence = 1,
+ cmd_kafka_fetch = {
+ topic = "not-exist",
+ partition = 0,
+ offset = 0,
+ },
+ },
+ {
+ -- Query first message offset
+ sequence = 2,
+ cmd_kafka_list_offset = {
+ topic = "test-consumer",
+ partition = 0,
+ timestamp = -2,
+ },
+ },
+ {
+ -- Query last message offset
+ sequence = 3,
+ cmd_kafka_list_offset = {
+ topic = "test-consumer",
+ partition = 0,
+ timestamp = -1,
+ },
+ },
+ {
+ -- Query by timestamp, 9999999999999 later than the
+ -- production time of any message
+ sequence = 4,
+ cmd_kafka_list_offset = {
+ topic = "test-consumer",
+ partition = 0,
+ timestamp = "9999999999999",
+ },
+ },
+ {
+ -- Query by timestamp, 1500000000000 ms earlier than the
+ -- production time of any message
+ sequence = 5,
+ cmd_kafka_list_offset = {
+ topic = "test-consumer",
+ partition = 0,
+ timestamp = "1500000000000",
+ },
+ },
+ {
+ sequence = 6,
+ cmd_kafka_fetch = {
+ topic = "test-consumer",
+ partition = 0,
+ offset = 14,
+ },
+ },
+ {
+ sequence = 7,
+ cmd_kafka_fetch = {
+ topic = "test-consumer",
+ partition = 0,
+ offset = 999,
+ },
+ },
+ }
+
+ for i = 1, #data do
+ local data = test_pubsub:send_recv_ws_binary(data[i])
+ if data.error_resp then
+ ngx.say(data.sequence..data.error_resp.message)
+ end
+ if data.kafka_list_offset_resp then
+ ngx.say(data.sequence.."offset: "..data.kafka_list_offset_resp.offset)
+ end
+ if data.kafka_fetch_resp then
+ ngx.say(data.sequence.."offset: "..data.kafka_fetch_resp.messages[1].offset..
+ " msg: "..data.kafka_fetch_resp.messages[1].value)
+ end
+ end
+ test_pubsub:close_ws()
+ }
+ }
+--- response_body
+0failed to list offset, topic: not-exist, partition: 0, err: not found topic
+1failed to fetch message, topic: not-exist, partition: 0, err: not found topic
+2offset: 0
+3offset: 30
Review Comment:
It's exist now, it's at https://github.com/apache/apisix/blob/8ed6673664b3f59aef8b6f17d7c10fe3019328bb/t/pubsub/kafka.t#L94-L99
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] bzp2010 commented on a diff in pull request #7032: feat(pubsub): support kafka
Posted by GitBox <gi...@apache.org>.
bzp2010 commented on code in PR #7032:
URL: https://github.com/apache/apisix/pull/7032#discussion_r873164988
##########
t/admin/upstream5.t:
##########
@@ -0,0 +1,61 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+use t::APISIX 'no_plan';
Review Comment:
@membphis This is just because the previous `upstreamX` test contains too many lines, and it does not point to the upstream scheme test of "Kafka", future upstream-related tests can also be added to this file (this test was moved here from t/node), which only tests whether the upstream in the Admin API can be created properly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] bzp2010 commented on pull request #7032: feat: support kafka pubsub
Posted by GitBox <gi...@apache.org>.
bzp2010 commented on PR #7032:
URL: https://github.com/apache/apisix/pull/7032#issuecomment-1125388669
### Update
There are still some test cases that have not been debug passed yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tzssangglass commented on a diff in pull request #7032: feat(pubsub): support kafka
Posted by GitBox <gi...@apache.org>.
tzssangglass commented on code in PR #7032:
URL: https://github.com/apache/apisix/pull/7032#discussion_r873425063
##########
apisix/pubsub/kafka.lua:
##########
@@ -0,0 +1,137 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributor license agreements. See the NOTICE file distributed with
+-- this work for additional information regarding copyright ownership.
+-- The ASF licenses this file to You under the Apache License, Version 2.0
+-- (the "License"); you may not use this file except in compliance with
+-- the License. You may obtain a copy of the License at
+--
+-- http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing, software
+-- distributed under the License is distributed on an "AS IS" BASIS,
+-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-- See the License for the specific language governing permissions and
+-- limitations under the License.
+--
+
+local core = require("apisix.core")
+local bconsumer = require("resty.kafka.basic-consumer")
+local ffi = require("ffi")
+local C = ffi.C
+local tostring = tostring
+local type = type
+local ipairs = ipairs
+local str_sub = string.sub
+
+ffi.cdef[[
+ int64_t atoll(const char *num);
+]]
+
+
+local _M = {}
+
+
+-- Handles the conversion of 64-bit integers in the lua-protobuf.
+--
+-- Because of the limitations of luajit, we cannot use native 64-bit
+-- numbers, so pb decode converts int64 to a string in #xxx format
+-- to avoid loss of precision, by this function, we convert this
+-- string to int64 cdata numbers.
+local function pb_convert_to_int64(src)
+ if type(src) == "string" then
+ -- the format is #1234, so there is a small minimum length of 2
+ if #src < 2 then
+ return 0
+ end
+ return C.atoll(ffi.cast("char *", src) + 1)
+ else
+ return src
+ end
+end
+
+
+-- Takes over requests of type kafka upstream in the http_access phase.
+function _M.access(api_ctx)
+ local pubsub, err = core.pubsub.new()
+ if not pubsub then
+ core.log.error("failed to initialize pubsub module, err: ", err)
+ core.response.exit(400)
Review Comment:
ok, I got.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] bzp2010 commented on a diff in pull request #7032: feat(pubsub): support kafka
Posted by GitBox <gi...@apache.org>.
bzp2010 commented on code in PR #7032:
URL: https://github.com/apache/apisix/pull/7032#discussion_r873173675
##########
apisix/include/apisix/model/pubsub.proto:
##########
@@ -55,16 +73,18 @@ message CmdEmpty {}
message PubSubReq {
int64 sequence = 1;
oneof req {
- CmdEmpty cmd_empty = 31;
- CmdPing cmd_ping = 32;
+ CmdEmpty cmd_empty = 31;
Review Comment:
@spacewander This would make the `pubsub` module test the relevant code that relies on `kafka`, and I'm not sure if I should do that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] bzp2010 commented on a diff in pull request #7032: feat(pubsub): support kafka
Posted by GitBox <gi...@apache.org>.
bzp2010 commented on code in PR #7032:
URL: https://github.com/apache/apisix/pull/7032#discussion_r873390824
##########
apisix/pubsub/kafka.lua:
##########
@@ -0,0 +1,137 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributor license agreements. See the NOTICE file distributed with
+-- this work for additional information regarding copyright ownership.
+-- The ASF licenses this file to You under the Apache License, Version 2.0
+-- (the "License"); you may not use this file except in compliance with
+-- the License. You may obtain a copy of the License at
+--
+-- http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing, software
+-- distributed under the License is distributed on an "AS IS" BASIS,
+-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-- See the License for the specific language governing permissions and
+-- limitations under the License.
+--
+
+local core = require("apisix.core")
+local bconsumer = require("resty.kafka.basic-consumer")
+local ffi = require("ffi")
+local C = ffi.C
+local tostring = tostring
+local type = type
+local ipairs = ipairs
+local str_sub = string.sub
+
+ffi.cdef[[
+ int64_t atoll(const char *num);
+]]
+
+
+local _M = {}
+
+
+-- Handles the conversion of 64-bit integers in the lua-protobuf.
+--
+-- Because of the limitations of luajit, we cannot use native 64-bit
+-- numbers, so pb decode converts int64 to a string in #xxx format
+-- to avoid loss of precision, by this function, we convert this
+-- string to int64 cdata numbers.
+local function pb_convert_to_int64(src)
+ if type(src) == "string" then
+ -- the format is #1234, so there is a small minimum length of 2
+ if #src < 2 then
+ return 0
+ end
+ return C.atoll(ffi.cast("char *", src) + 1)
+ else
+ return src
+ end
+end
+
+
+-- Takes over requests of type kafka upstream in the http_access phase.
+function _M.access(api_ctx)
+ local pubsub, err = core.pubsub.new()
+ if not pubsub then
+ core.log.error("failed to initialize pubsub module, err: ", err)
+ core.response.exit(400)
+ return
+ end
+
+ local up_nodes = api_ctx.matched_upstream.nodes
+
+ -- kafka client broker-related configuration
+ local broker_list = {}
+ for i, node in ipairs(up_nodes) do
+ broker_list[i] = {
+ host = node.host,
+ port = node.port,
+ }
+ end
+
+ local client_config = {refresh_interval = 30 * 60 * 1000}
Review Comment:
https://github.com/apache/apisix/pull/7046/files#diff-c3fcd56e3899a92ed8364bca0a5af4e2985cba352c4530a11c03738fb7162d02R83-R85
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a diff in pull request #7032: feat(pubsub): support kafka
Posted by GitBox <gi...@apache.org>.
spacewander commented on code in PR #7032:
URL: https://github.com/apache/apisix/pull/7032#discussion_r873320109
##########
apisix/include/apisix/model/pubsub.proto:
##########
@@ -55,16 +73,18 @@ message CmdEmpty {}
message PubSubReq {
int64 sequence = 1;
oneof req {
- CmdEmpty cmd_empty = 31;
- CmdPing cmd_ping = 32;
+ CmdEmpty cmd_empty = 31;
Review Comment:
What about adding a comment to show that this cmd is test-only?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] bzp2010 commented on a diff in pull request #7032: feat(pubsub): support kafka
Posted by GitBox <gi...@apache.org>.
bzp2010 commented on code in PR #7032:
URL: https://github.com/apache/apisix/pull/7032#discussion_r873437548
##########
apisix/include/apisix/model/pubsub.proto:
##########
@@ -55,16 +73,18 @@ message CmdEmpty {}
message PubSubReq {
int64 sequence = 1;
oneof req {
- CmdEmpty cmd_empty = 31;
- CmdPing cmd_ping = 32;
+ CmdEmpty cmd_empty = 31;
Review Comment:
After rechecking, I found that CmdEmpty has added a test-only flag.
https://github.com/apache/apisix/blob/d95500948d0af71bb6a378b9634d57b984c6e78c/apisix/include/apisix/model/pubsub.proto#L35-L39
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #7032: feat(pubsub): support kafka
Posted by GitBox <gi...@apache.org>.
spacewander merged PR #7032:
URL: https://github.com/apache/apisix/pull/7032
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] bzp2010 commented on a diff in pull request #7032: feat(pubsub): support kafka
Posted by GitBox <gi...@apache.org>.
bzp2010 commented on code in PR #7032:
URL: https://github.com/apache/apisix/pull/7032#discussion_r873173439
##########
docs/en/latest/pubsub/kafka.md:
##########
@@ -0,0 +1,91 @@
+---
+title: Apache Kafka
+keywords:
+ - APISIX
+ - Pub-Sub
+ - Kafka
+description: This document contains information about the Apache APISIX kafka pub-sub scenario.
+---
+
+<!--
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+-->
+
+## Connect to Apache Kafka
+
+Connecting to Apache Kafka in Apache APISIX is very simple.
+
+Currently we provide a simpler way to integrate by combining two APIs, ListOffsets and Fetch, to quickly implement the ability to pull Kafka messages, but do not support Apache Kafka's consumer group feature for now, and cannot be managed by Kafka for offsets.
+
+### Limitations
+
+- Offsets need to be managed manually
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org