[GitHub] [johnzon] rmannibucau commented on a change in pull request #78: JOHNZON-359 Fix lost OSGi metadata

[GitBox <gi...@apache.org>]

rmannibucau commented on a change in pull request #78:
URL: https://github.com/apache/johnzon/pull/78#discussion_r810590335



##########
File path: johnzon-maven-plugin/pom.xml
##########
@@ -119,4 +119,86 @@
       </plugin>
     </plugins>
   </build>
+
+  <profiles>
+    <profile>
+      <id>jdk9+</id>
+      <activation>
+        <jdk>[9,)</jdk>
+      </activation>
+      <build>
+        <plugins>
+          <plugin>
+            <groupId>org.apache.maven.plugins</groupId>

Review comment:
       let's keep this PR about OSGi maybe
   
   side note: if we compile the generated classes, I'd be to do it in the test doing the generation with ToolProvider or a plain System.getProperty(java.home) + javac lookup and not a maven plugin to keep it consistent and localized. For record java.version can be tested but releases will be done with java 8 (or 11) so not sure it will help to prevent much in the future at community level.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@johnzon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org