You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@magpie.apache.org by "justinmclean (via GitHub)" <gi...@apache.org> on 2026/07/12 05:20:04 UTC
[PR] docs(education): fix Pattern 8 eval layout to match real fixtures str ucture [magpie]
justinmclean opened a new pull request, #837:
URL: https://github.com/apache/magpie/pull/837
## Summary
Pattern 8 in pattern-catalogue.md showed a fictional layout using eval.yaml and a flat cases/*.md directory. Neither exists anywhere in the repo. The real harness uses evals/<skill>/<step-slug>/fixtures/ with step-config.json, output-spec.md, and per-case case-*/expected.json dirs, matching eval-driven-development.md and tutorials.md.
Rewrite the pattern's code block and prose to document the real layout, keeping the four-case minimum-suite guidance (normal, injection, empty queue, confirm gate) mapped to the actual case-*/ directory structure.
Generated-by: Claude (claude-sonnet-4-6)
## Type of change
- [ ] Skill change (`.claude/skills/<name>/`) — eval fixtures updated below
- [ ] Tool / bridge contract (`tools/<system>/*.md`)
- [ ] Python package (`tools/*/` with `pyproject.toml`)
- [ ] Groovy reference impl
- [ ] Cross-cutting (RFC, AGENTS.md, sandbox, privacy-LLM)
- [X] Documentation (`docs/`, `README.md`, `CONTRIBUTING.md`)
- [ ] Project template (`projects/_template/`)
- [ ] CI / dev loop (`prek`, workflows, validators)
- [ ] Other:
## Test plan
- [X] `prek run --all-files` passes
- [ ] For Python packages touched: `uv run pytest` / `ruff check` / `mypy` passes
- [ ] For Groovy bridges touched: command-line invocation tested end-to-end
- [ ] For skill changes: eval suite passes for the affected skill
(`PYTHONPATH=tools/skill-evals/src python3 -m skill_evals.runner tools/skill-evals/evals/<skill>/`)
- [ ] For skill *behaviour* changes: a new or updated eval fixture is included in this PR
(a regression test for the bug fixed / the behaviour added — see CONTRIBUTING.md)
- [ ] Other:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@magpie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs(education): fix Pattern 8 eval layout to match real fixtures structure [magpie]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #837:
URL: https://github.com/apache/magpie/pull/837
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@magpie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org