[GitHub] xtinec commented on issue #6815: Make the target path of the superset logo configuable

[GitBox <gi...@apache.org>]

xtinec commented on issue #6815: Make the target path of the superset logo configuable
URL: https://github.com/apache/incubator-superset/pull/6815#issuecomment-461151243
 
 
   `set logo_target_path = appbuilder.app.config.get('LOGO_TARGET_PATH', '/profile/{}/'.format(current_user.username))` does the same thing as the `or` suggested above, right?
   
   Also, do we need the `LOGO_TARGET_PATH = None` in `config.py` as the fallback will always kick in when `LOGO_TARGET_PATH` is not defined?
   
   Good call on the doc. I'll update the readme.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org