[jira] [Commented] (ARIES-1109) Duplicate subsystem ids after restart of subsystem.core

["John Ross (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ARIES-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13754679#comment-13754679 ] 

John Ross commented on ARIES-1109:
----------------------------------

This should have been fixed by http://svn.apache.org/viewvc?view=revision&revision=1444202.

It's included in the 1.0.0 release where lines 150-153 in the source jar are as follows.

SubsystemIdentifier.setLastId(
	Long.parseLong(
		root.getDeploymentManifest().getHeaders().get(
			DeploymentManifest.ARIESSUBSYSTEM_LASTID).getValue()));

Do you see that in your source? Make sure you're using the 1.0.0 release version and not a 1.0.0-SNAPSHOT version.

                
> Duplicate subsystem ids after restart of subsystem.core
> -------------------------------------------------------
>
>                 Key: ARIES-1109
>                 URL: https://issues.apache.org/jira/browse/ARIES-1109
>             Project: Aries
>          Issue Type: Bug
>          Components: Subsystem
>            Reporter: Stephan Siano
>
> aries subsystems will generate duplicate subsystem ids if the subsystem core bundle (or the container) is restarted.
> Reproduction is quite easy:
> 1. install a subsystem -> this will get subsystem id 1
> 2. stop the org.apache.aries.subsystem.core bundle (or the OSGi container)
> 3. start the org.apache.aries.subsystem.core bundle (or the OSGi container)
> -> the subsystem installed in step 1 is still there and has id 1
> 4. Install another subsystem (different from the first)
> -> This will also get Id 1
> I think the error is in line 150 of the org.apache.subsystems.core.internal.Subsystems class. There the static lastId counter of the SubsystemIdentifier class is set to 0 before actually populating the root subsystem.
> Maybe this should be set to the maximum id of the installed subsystems during or after the population of the root subsystem

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira