You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/09 05:48:12 UTC

[GitHub] [flink] WeiZhong94 commented on a change in pull request #12048: [FLINK-17586][python] get the real Configuration object from DummyStreamExecutionEnvironment when translating the Python UDF physical nodes to operators.

WeiZhong94 commented on a change in pull request #12048:
URL: https://github.com/apache/flink/pull/12048#discussion_r422456225



##########
File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/plan/nodes/CommonPythonBase.scala
##########
@@ -136,6 +140,16 @@ trait CommonPythonBase {
     config.addAll(tableConfig.getConfiguration)
     config
   }
+
+  private def getRealEnvironment(env: StreamExecutionEnvironment): StreamExecutionEnvironment = {

Review comment:
       Currently it is unnecessary as the `DummyExecutionEnvironment` would not be passed to the `translateToPlan` methods.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org