You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@qpid.apache.org by ro...@apache.org on 2009/07/14 17:07:45 UTC
svn commit: r793925 - in
/qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views:
./ connection/ exchange/ logging/ queue/ type/ users/ vhost/
Author: robbie
Date: Tue Jul 14 15:07:44 2009
New Revision: 793925
URL: http://svn.apache.org/viewvc?rev=793925&view=rev
Log:
QPID-1947: leave the components visible during update to prevent focus-switching issues during automated refresh
Modified:
qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/AttributesTabControl.java
qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/connection/ConnectionOperationsTabControl.java
qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/exchange/ExchangeOperationsTabControl.java
qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/exchange/HeadersExchangeOperationsTabControl.java
qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/logging/ConfigurationFileTabControl.java
qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/logging/RuntimeTabControl.java
qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/queue/QueueOperationsTabControl.java
qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/type/MBeanTypeTabControl.java
qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/users/UserManagementTabControl.java
qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/vhost/VHostTabControl.java
Modified: qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/AttributesTabControl.java
URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/AttributesTabControl.java?rev=793925&r1=793924&r2=793925&view=diff
==============================================================================
--- qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/AttributesTabControl.java (original)
+++ qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/AttributesTabControl.java Tue Jul 14 15:07:44 2009
@@ -557,7 +557,7 @@
AttributeData data = (AttributeData)button.getParent().getData();
MBeanUtility.updateAttribute(_mbean, data, text.getText());
button.getShell().close();
- refresh();
+ refresh(_mbean);
}
catch (Exception ex)
{
@@ -569,14 +569,6 @@
return updateButton;
}
- // Refresh from the server registry
- public void refresh()
- {
- JMXServerRegistry serverRegistry = (JMXServerRegistry)ApplicationRegistry.getServerRegistry(_mbean);
- ManagedAttributeModel attributesList = serverRegistry.getAttributeModel(_mbean);
- _tableViewer.setInput(attributesList);
- }
-
/**
* Refreshes the attribute tab by querying the mbean server for latest values
*/
Modified: qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/connection/ConnectionOperationsTabControl.java
URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/connection/ConnectionOperationsTabControl.java?rev=793925&r1=793924&r2=793925&view=diff
==============================================================================
--- qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/connection/ConnectionOperationsTabControl.java (original)
+++ qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/connection/ConnectionOperationsTabControl.java Tue Jul 14 15:07:44 2009
@@ -117,13 +117,6 @@
@Override
public void refresh(ManagedBean mbean)
{
- _mbean = mbean;
- if (_mbean == null)
- {
- _tableViewer.setInput(null);
- return;
- }
-
_channels = null;
try
{
@@ -135,9 +128,8 @@
MBeanUtility.handleException(mbean,e);
}
- _form.setVisible(false);
_tableViewer.setInput(_channels);
- _form.setVisible(true);
+
layout();
}
Modified: qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/exchange/ExchangeOperationsTabControl.java
URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/exchange/ExchangeOperationsTabControl.java?rev=793925&r1=793924&r2=793925&view=diff
==============================================================================
--- qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/exchange/ExchangeOperationsTabControl.java (original)
+++ qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/exchange/ExchangeOperationsTabControl.java Tue Jul 14 15:07:44 2009
@@ -122,13 +122,6 @@
@Override
public void refresh(ManagedBean mbean)
{
- _mbean = mbean;
- if (_mbean == null)
- {
- _keysTableViewer.setInput(null);
- return;
- }
-
_bindings = null;
try
{
@@ -140,9 +133,8 @@
MBeanUtility.handleException(mbean,e);
}
- _form.setVisible(false);
_keysTableViewer.setInput(_bindings);
- _form.setVisible(true);
+
layout();
}
Modified: qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/exchange/HeadersExchangeOperationsTabControl.java
URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/exchange/HeadersExchangeOperationsTabControl.java?rev=793925&r1=793924&r2=793925&view=diff
==============================================================================
--- qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/exchange/HeadersExchangeOperationsTabControl.java (original)
+++ qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/exchange/HeadersExchangeOperationsTabControl.java Tue Jul 14 15:07:44 2009
@@ -123,13 +123,7 @@
@Override
public void refresh(ManagedBean mbean)
{
- _mbean = mbean;
- if (_mbean == null)
- {
- _bindingNumberTableViewer.setInput(null);
- return;
- }
-
+
_bindings = null;
try
{
@@ -141,9 +135,8 @@
MBeanUtility.handleException(mbean,e);
}
- _form.setVisible(false);
_bindingNumberTableViewer.setInput(_bindings);
- _form.setVisible(true);
+
layout();
}
Modified: qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/logging/ConfigurationFileTabControl.java
URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/logging/ConfigurationFileTabControl.java?rev=793925&r1=793924&r2=793925&view=diff
==============================================================================
--- qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/logging/ConfigurationFileTabControl.java (original)
+++ qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/logging/ConfigurationFileTabControl.java Tue Jul 14 15:07:44 2009
@@ -125,13 +125,6 @@
@Override
public void refresh(ManagedBean mbean)
{
- _mbean = mbean;
- if (_mbean == null)
- {
- _tableViewer.setInput(null);
- return;
- }
-
String configFileRootLoggerLevel = "-";
try
{
@@ -162,7 +155,6 @@
MBeanUtility.handleException(_mbean, e3);
}
- _form.setVisible(false);
_configFileRootLoggerLevelLabel.setText(String.valueOf(configFileRootLoggerLevel));
if (log4jLogWatchInterval == 0)
{
@@ -173,7 +165,7 @@
_logWatchIntervalLabel.setText(String.valueOf(log4jLogWatchInterval) + " seconds");
}
_tableViewer.setInput(_configFileLoggerLevels);
- _form.setVisible(true);
+
layout();
}
Modified: qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/logging/RuntimeTabControl.java
URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/logging/RuntimeTabControl.java?rev=793925&r1=793924&r2=793925&view=diff
==============================================================================
--- qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/logging/RuntimeTabControl.java (original)
+++ qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/logging/RuntimeTabControl.java Tue Jul 14 15:07:44 2009
@@ -124,13 +124,6 @@
@Override
public void refresh(ManagedBean mbean)
{
- _mbean = mbean;
- if (_mbean == null)
- {
- _tableViewer.setInput(null);
- return;
- }
-
String runtimeRootLoggerLevel = "-";
try
{
@@ -151,10 +144,9 @@
MBeanUtility.handleException(_mbean, e2);
}
- _form.setVisible(false);
_runtimeRootLoggerLevelLabel.setText(String.valueOf(runtimeRootLoggerLevel));
_tableViewer.setInput(_runtimeLoggerLevels);
- _form.setVisible(true);
+
layout();
}
Modified: qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/queue/QueueOperationsTabControl.java
URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/queue/QueueOperationsTabControl.java?rev=793925&r1=793924&r2=793925&view=diff
==============================================================================
--- qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/queue/QueueOperationsTabControl.java (original)
+++ qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/queue/QueueOperationsTabControl.java Tue Jul 14 15:07:44 2009
@@ -131,13 +131,6 @@
@Override
public void refresh(ManagedBean mbean)
{
- _mbean = mbean;
- if (_mbean == null)
- {
- _tableViewer.setInput(null);
- return;
- }
-
_messages = null;
try
{
@@ -154,9 +147,8 @@
MBeanUtility.handleException(mbean,e);
}
- _form.setVisible(false);
_tableViewer.setInput(_messages);
- _form.setVisible(true);
+
layout();
}
Modified: qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/type/MBeanTypeTabControl.java
URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/type/MBeanTypeTabControl.java?rev=793925&r1=793924&r2=793925&view=diff
==============================================================================
--- qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/type/MBeanTypeTabControl.java (original)
+++ qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/type/MBeanTypeTabControl.java Tue Jul 14 15:07:44 2009
@@ -104,9 +104,9 @@
public void refresh(ManagedBean mbean)
{
_mbeans = getMbeans();
- _form.setVisible(false);
+
_tableViewer.setInput(_mbeans);
- _form.setVisible(true);
+
layout();
}
Modified: qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/users/UserManagementTabControl.java
URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/users/UserManagementTabControl.java?rev=793925&r1=793924&r2=793925&view=diff
==============================================================================
--- qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/users/UserManagementTabControl.java (original)
+++ qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/users/UserManagementTabControl.java Tue Jul 14 15:07:44 2009
@@ -113,13 +113,7 @@
@Override
public void refresh(ManagedBean mbean)
{
- _mbean = mbean;
- if (_mbean == null)
- {
- _tableViewer.setInput(null);
- return;
- }
-
+ _userDetails = null;
try
{
_userDetails = (TabularDataSupport) _ummb.viewUsers();
@@ -127,12 +121,11 @@
catch(Exception e)
{
MBeanUtility.handleException(_mbean, e);
- _userDetails = null;
+
}
- _form.setVisible(false);
_tableViewer.setInput(_userDetails);
- _form.setVisible(true);
+
layout();
}
Modified: qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/vhost/VHostTabControl.java
URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/vhost/VHostTabControl.java?rev=793925&r1=793924&r2=793925&view=diff
==============================================================================
--- qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/vhost/VHostTabControl.java (original)
+++ qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/vhost/VHostTabControl.java Tue Jul 14 15:07:44 2009
@@ -125,10 +125,9 @@
queues = serverRegistry.getQueues(MBeanView.getVirtualHost());
exchanges = serverRegistry.getExchanges(MBeanView.getVirtualHost());
- _form.setVisible(false);
_queueTableViewer.setInput(queues);
_exchangeTableViewer.setInput(exchanges);
- _form.setVisible(true);
+
layout();
}
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:commits-subscribe@qpid.apache.org