You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@avro.apache.org by "Kriskras99 (via GitHub)" <gi...@apache.org> on 2025/07/01 10:48:26 UTC
[I] Should `Writer::flush` also write the header? [avro-rs]
Kriskras99 opened a new issue, #220:
URL: https://github.com/apache/avro-rs/issues/220
Currently `Writer::flush` only flushes the buffers but both `Writer::drop` and `Writer::into_inner` also write the header.
Does it make sense to also call `maybe_write_header` in `Writer::flush`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Should `Writer::flush` also write the header? [avro-rs]
Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g commented on issue #220:
URL: https://github.com/apache/avro-rs/issues/220#issuecomment-3023395299
I wondered whether this would break use cases like https://github.com/apache/avro-rs/pull/193 but I think it won't.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Should `Writer::flush` also write the header? [avro-rs]
Posted by "Kriskras99 (via GitHub)" <gi...@apache.org>.
Kriskras99 commented on issue #220:
URL: https://github.com/apache/avro-rs/issues/220#issuecomment-3024190139
I don't think it should cause any problems, as that would use `write_avro_datum_ref` directly. If they do use `Writer` they should already be building it with the builder and `has_header(false)`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Should `Writer::flush` also write the header? [avro-rs]
Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g closed issue #220: Should `Writer::flush` also write the header?
URL: https://github.com/apache/avro-rs/issues/220
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org