You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by StefanRRichter <gi...@git.apache.org> on 2016/07/04 12:38:07 UTC

[GitHub] flink pull request #2196: [FLINK-4134] empty session windows fire for late e...

GitHub user StefanRRichter opened a pull request:

    https://github.com/apache/flink/pull/2196

    [FLINK-4134] empty session windows fire for late events

    Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
    If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
    In addition to going through the list, please provide a meaningful description of your changes.
    
    - [ x] General
      - The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
      - The pull request addresses only one issue
      - Each commit in the PR has a meaningful commit message (including the JIRA id)
    
    - [ x] Documentation
      - Documentation has been added for new functionality
      - Old documentation affected by the pull request has been updated
      - JavaDoc for public methods has been added
    
    - [ x] Tests & Build
      - Functionality added by the pull request is covered by tests
      - `mvn clean verify` has been executed successfully locally or a Travis build has passed
    
    \u2026e session accidentally created a triggering empty window

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/StefanRRichter/flink 4134-EmptySessionWindowsFire

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2196.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2196
    
----
commit 0e7bf5d9244ba4ea529c9037e680c9bfdf2069f9
Author: Stefan Richter <s....@data-artisans.com>
Date:   2016-07-04T12:32:42Z

    [FLINK-4134] [Runtime] Bugfix: multiple late elements that fall in one session accidentally created a triggering empty window

commit e82c5a623854d76be958176027d44e948810e609
Author: Stefan Richter <s....@data-artisans.com>
Date:   2016-07-04T12:36:43Z

    FLINK-4134] [Runtime] Bugfix: multiple late elements that fall in one session accidentally created a triggering empty window

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #2196: [FLINK-4134] empty session windows fire for late e...

Posted by StefanRRichter <gi...@git.apache.org>.
Github user StefanRRichter closed the pull request at:

    https://github.com/apache/flink/pull/2196


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #2196: [FLINK-4134] empty session windows fire for late events

Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the issue:

    https://github.com/apache/flink/pull/2196
  
    Thanks for the fix. I'll rename the commit to something like `[FLINK-4134] Retire Late Windows/Elements in WindowOperator` because it is a) shorter and b) clearly describes what the change does.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #2196: [FLINK-4134] empty session windows fire for late events

Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the issue:

    https://github.com/apache/flink/pull/2196
  
    Could you please close this PR if it is not automatically closed. Thanks again for the fix. \U0001f603 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---