You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/12/09 08:34:41 UTC
[GitHub] [airflow] bhavaniravi opened a new pull request #20156: #20139 - Move Dms operators and Sensors
bhavaniravi opened a new pull request #20156:
URL: https://github.com/apache/airflow/pull/20156
**#20139 - Move Dms operators and Sensors**
Fixes #20139
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on a change in pull request #20156: #20139 - Move Dms operators and Sensors
Posted by GitBox <gi...@apache.org>.
eladkal commented on a change in pull request #20156:
URL: https://github.com/apache/airflow/pull/20156#discussion_r765989136
##########
File path: tests/deprecated_classes.py
##########
@@ -975,6 +975,26 @@
"airflow.providers.amazon.aws.operators.batch.AwsBatchOperator",
"airflow.contrib.operators.awsbatch_operator.AWSBatchOperator",
),
+ (
+ "airflow.providers.amazon.aws.operators.dms.DmsCreateTaskOperator",
+ "airflow.providers.amazon.aws.operators.dms_create_task.DmsCreateTaskOperator",
+ ),
+ (
+ "airflow.providers.amazon.aws.operators.dms.DmsDeleteTaskOperator",
+ "airflow.providers.amazon.aws.operators.dms_delete_task.DmsDeleteTaskOperator",
+ ),
+ (
+ "airflow.providers.amazon.aws.operators.dms.DmsDescribeTasksOperator",
+ "airflow.providers.amazon.aws.operators.dms_describe_task.DmsDescribeTasksOperator",
Review comment:
```suggestion
"airflow.providers.amazon.aws.operators.dms_describe_tasks.DmsDescribeTasksOperator",
```
You have a wrong file name which causes the test to fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #20156: #20139 - Move Dms operators and Sensors
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #20156:
URL: https://github.com/apache/airflow/pull/20156#issuecomment-993505116
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on pull request #20156: #20139 - Move Dms operators and Sensors
Posted by GitBox <gi...@apache.org>.
eladkal commented on pull request #20156:
URL: https://github.com/apache/airflow/pull/20156#issuecomment-992601191
@bhavaniravi You are missing edits for dms test files:
https://github.com/apache/airflow/tree/main/tests/providers/amazon/aws/operators
https://github.com/apache/airflow/tree/main/tests/providers/amazon/aws/sensors
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal merged pull request #20156: #20139 - Move Dms operators and Sensors
Posted by GitBox <gi...@apache.org>.
eladkal merged pull request #20156:
URL: https://github.com/apache/airflow/pull/20156
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org