You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/06/24 07:24:48 UTC

[GitHub] [airflow] uranusjr commented on pull request #24626: Add --platform to breeze shell and start-airflow

uranusjr commented on PR #24626:
URL: https://github.com/apache/airflow/pull/24626#issuecomment-1165284348

   Hmm, I was under the impression `breeze tests` also needs this, but apparently it does not and “correctly” picks up the AMD-based image. This leads me to think maybe we are doing something wrong with the overall structure. Currently:
   
   1. `shell` and `start-airflow` only pick up an image if it matches the platform. In other words, if we only have an AMD64 base image available, they would attempt to rebuild the base image against ARM from scratch.
   2. `tests` automatically picks up the image for AMD64 and run tests against it.
   
   So either `shell` and `start-airflow` should also automatically detect the base image is against AMD64 and build against it instead, _or_ `tests` should not blindly pick up the AMD64 image, and instead build against ARM from scratch by default.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org