You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by xiaojian zhou <zh...@gmail.com> on 2015/12/14 02:06:58 UTC
Review Request 41332: Add CacheObserver for ShutdownAll and also let
WAN to return CancelException
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41332/
-----------------------------------------------------------
Review request for geode and Dan Smith.
Repository: geode
Description
-------
We need a cacheobserver for ShutdownAll.
GatewayReceiverCommand will find the region of events will be null when shutdownall is on-going. In this case, it will throw CacheDestroyedException (i.e. subclass of CancelException) instead of RegionDestroyedException.
Diffs
-----
gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/CacheObserver.java 9cd6c28
gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/CacheObserverAdapter.java 82c4507
gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/GemFireCacheImpl.java 27bb813
gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/command/GatewayReceiverCommand.java 6d252e4
Diff: https://reviews.apache.org/r/41332/diff/
Testing
-------
Thanks,
xiaojian zhou
Re: Review Request 41332: Add CacheObserver for ShutdownAll and also
let WAN to return CancelException
Posted by Ashvin A <aa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41332/#review110277
-----------------------------------------------------------
gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/command/GatewayReceiverCommand.java (line 74)
<https://reviews.apache.org/r/41332/#comment170092>
This check captures shutdownAll scenario. What if only this cache is closing?
- Ashvin A
On Dec. 14, 2015, 1:06 a.m., xiaojian zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41332/
> -----------------------------------------------------------
>
> (Updated Dec. 14, 2015, 1:06 a.m.)
>
>
> Review request for geode and Dan Smith.
>
>
> Repository: geode
>
>
> Description
> -------
>
> We need a cacheobserver for ShutdownAll.
>
> GatewayReceiverCommand will find the region of events will be null when shutdownall is on-going. In this case, it will throw CacheDestroyedException (i.e. subclass of CancelException) instead of RegionDestroyedException.
>
>
> Diffs
> -----
>
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/CacheObserver.java 9cd6c28
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/CacheObserverAdapter.java 82c4507
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/GemFireCacheImpl.java 27bb813
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/command/GatewayReceiverCommand.java 6d252e4
>
> Diff: https://reviews.apache.org/r/41332/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> xiaojian zhou
>
>
Re: Review Request 41332: Add CacheObserver for ShutdownAll and also
let WAN to return CancelException
Posted by Xiaojian Zhou <gz...@pivotal.io>.
There's another review request for close part code changes.
https://reviewboard.gemstone.com/r/3761/
GEODE-669 is just created.
On Mon, Dec 14, 2015 at 10:33 AM, Dan Smith <ds...@pivotal.io> wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41332/#review110274
> -----------------------------------------------------------
>
>
> Can you file a JIRA for this?
>
> Also, would it make sense to add this sort of logic to Cache.getRegion? It
> seems like there might be other code that is expecting to find a region
> that previously existed, and the only reason that it is gone is because of
> a shut down all.
>
> - Dan Smith
>
>
> On Dec. 14, 2015, 1:06 a.m., xiaojian zhou wrote:
> >
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/41332/
> > -----------------------------------------------------------
> >
> > (Updated Dec. 14, 2015, 1:06 a.m.)
> >
> >
> > Review request for geode and Dan Smith.
> >
> >
> > Repository: geode
> >
> >
> > Description
> > -------
> >
> > We need a cacheobserver for ShutdownAll.
> >
> > GatewayReceiverCommand will find the region of events will be null when
> shutdownall is on-going. In this case, it will throw
> CacheDestroyedException (i.e. subclass of CancelException) instead of
> RegionDestroyedException.
> >
> >
> > Diffs
> > -----
> >
> >
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/CacheObserver.java
> 9cd6c28
> >
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/CacheObserverAdapter.java
> 82c4507
> >
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/GemFireCacheImpl.java
> 27bb813
> >
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/command/GatewayReceiverCommand.java
> 6d252e4
> >
> > Diff: https://reviews.apache.org/r/41332/diff/
> >
> >
> > Testing
> > -------
> >
> >
> > Thanks,
> >
> > xiaojian zhou
> >
> >
>
>
Re: Review Request 41332: Add CacheObserver for ShutdownAll and also
let WAN to return CancelException
Posted by Dan Smith <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41332/#review110274
-----------------------------------------------------------
Can you file a JIRA for this?
Also, would it make sense to add this sort of logic to Cache.getRegion? It seems like there might be other code that is expecting to find a region that previously existed, and the only reason that it is gone is because of a shut down all.
- Dan Smith
On Dec. 14, 2015, 1:06 a.m., xiaojian zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41332/
> -----------------------------------------------------------
>
> (Updated Dec. 14, 2015, 1:06 a.m.)
>
>
> Review request for geode and Dan Smith.
>
>
> Repository: geode
>
>
> Description
> -------
>
> We need a cacheobserver for ShutdownAll.
>
> GatewayReceiverCommand will find the region of events will be null when shutdownall is on-going. In this case, it will throw CacheDestroyedException (i.e. subclass of CancelException) instead of RegionDestroyedException.
>
>
> Diffs
> -----
>
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/CacheObserver.java 9cd6c28
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/CacheObserverAdapter.java 82c4507
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/GemFireCacheImpl.java 27bb813
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/command/GatewayReceiverCommand.java 6d252e4
>
> Diff: https://reviews.apache.org/r/41332/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> xiaojian zhou
>
>
Re: Review Request 41332: Add CacheObserver for ShutdownAll and also
let WAN to return CancelException
Posted by Ashvin A <aa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41332/#review110276
-----------------------------------------------------------
Ship it!
Ship It!
- Ashvin A
On Dec. 14, 2015, 1:06 a.m., xiaojian zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41332/
> -----------------------------------------------------------
>
> (Updated Dec. 14, 2015, 1:06 a.m.)
>
>
> Review request for geode and Dan Smith.
>
>
> Repository: geode
>
>
> Description
> -------
>
> We need a cacheobserver for ShutdownAll.
>
> GatewayReceiverCommand will find the region of events will be null when shutdownall is on-going. In this case, it will throw CacheDestroyedException (i.e. subclass of CancelException) instead of RegionDestroyedException.
>
>
> Diffs
> -----
>
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/CacheObserver.java 9cd6c28
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/CacheObserverAdapter.java 82c4507
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/GemFireCacheImpl.java 27bb813
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/command/GatewayReceiverCommand.java 6d252e4
>
> Diff: https://reviews.apache.org/r/41332/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> xiaojian zhou
>
>