You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2017/12/05 02:38:21 UTC

[GitHub] anirudh2290 opened a new pull request #8944: Usability improvement bi lstm sort

anirudh2290 opened a new pull request #8944: Usability improvement bi lstm sort
URL: https://github.com/apache/incubator-mxnet/pull/8944
 
 
   ## Description ##
   Added support for users to pass input ranges to lstm_sort.
   Added asserts to check validity of the inputs to infer_sort.
   Merged train and gen_data into one script.
   Removed sys.path.inserts from the example scripts.
   
   ## Checklist ##
   ### Essentials ###
   - [x] Passed code style checking (`make lint`)
   - [x] Changes are complete (i.e. I finished coding on this PR)
   - [x] All changes have test coverage
   - [x] For user-facing API changes, API doc string has been updated. For new C++ functions in header files, their functionalities and arguments are well-documented. 
   - [x] To my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
   
   ### Changes ###
   - [x] Feature1, tests, (and when applicable, API doc)
   - [x] Feature2, tests, (and when applicable, API doc)
   - [x] Feature3, tests,  (and when applicable, API doc)
   
   
   ## Comments ##
   - If this change is a backward incompatible change, why must this change be made.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services