[GitHub] [incubator-ratis] szetszwo commented on a change in pull request #234: RATIS-1108. Add SupportedDataStreamType.DISABLED to indicate that datastream server is not enabled

[GitBox <gi...@apache.org>]

szetszwo commented on a change in pull request #234:
URL: https://github.com/apache/incubator-ratis/pull/234#discussion_r513202703



##########
File path: ratis-server/src/main/java/org/apache/ratis/server/impl/DataStreamServerImpl.java
##########
@@ -35,31 +37,38 @@
 public class DataStreamServerImpl implements DataStreamServer {
   public static final Logger LOG = LoggerFactory.getLogger(DataStreamServerImpl.class);
 
-  private final DataStreamServerRpc serverRpc;
+  private Optional<DataStreamServerRpc> serverRpc;

Review comment:
       We do not need to change DataStreamServerImpl at all.  The idea is to implement a new RPC type for DISABLED, i.e. we should implement a DisabledDataStreamFactory.
   ```
   public class DisabledDataStreamFactory implements DataStreamServerFactory, DataStreamClientFactory {
     public DisabledDataStreamFactory(Parameters parameters){}
   
     @Override
     public SupportedDataStreamType getDataStreamType() {
       return SupportedDataStreamType.DISABLED;
     }
   
     @Override
     public DataStreamClientRpc newDataStreamClientRpc(RaftPeer server, RaftProperties properties) {
       return new DataStreamClientRpc() {
         @Override
         public void startClient() {}
   
         @Override
         public void closeClient() {}
       };
     }
   
     @Override
     public DataStreamServerRpc newDataStreamServerRpc(RaftPeer server, StateMachine stateMachine,
         RaftProperties properties) {
       return new DataStreamServerRpc() {
         @Override
         public void start() {}
   
         @Override
         public void close() {}
   
         @Override
         public void addRaftPeers(Collection<RaftPeer> peers) {}
       };
     }
   
     @Override
     public DataStreamServerRpc newDataStreamServerRpc(RaftServer server, StateMachine stateMachine,
         RaftProperties properties) {
       return new DataStreamServerRpc() {
         @Override
         public void start() {}
   
         @Override
         public void close() {}
   
         @Override
         public void addRaftPeers(Collection<RaftPeer> peers) {}
       };
     }
   }
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org