You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/12/07 06:56:49 UTC

[GitHub] [doris] englefly opened a new pull request, #14876: [feature](planner) for original planner: a=1 or a=2 or a=3 or ... => a in ( 1,2,3, ...)

englefly opened a new pull request, #14876:
URL: https://github.com/apache/doris/pull/14876

   # Proposed changes
   for original planner
   a=1 or a=2 or a=3 or ... => a in ( 1,2,3, ...)
   
   Issue Number: close #xxx
   
   ## Problem summary
   
   Describe your changes.
   
   ## Checklist(Required)
   
   1. Does it affect the original behavior: 
       - [ ] Yes
       - [ ] No
       - [ ] I don't know
   2. Has unit tests been added:
       - [ ] Yes
       - [ ] No
       - [ ] No Need
   3. Has document been added or modified:
       - [ ] Yes
       - [ ] No
       - [ ] No Need
   4. Does it need to update dependencies:
       - [ ] Yes
       - [ ] No
   5. Are there any changes that cannot be rolled back:
       - [ ] Yes (If Yes, please explain WHY)
       - [ ] No
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] englefly commented on a diff in pull request #14876: [feature](planner) compact multi-euqals to in-predicate

Posted by GitBox <gi...@apache.org>.
englefly commented on code in PR #14876:
URL: https://github.com/apache/doris/pull/14876#discussion_r1047053763


##########
fe/fe-core/src/test/java/org/apache/doris/analysis/PartitionPruneTestBase.java:
##########
@@ -29,8 +29,6 @@ public abstract class PartitionPruneTestBase extends TestWithFeService {
 
     protected void doTest() throws Exception {
         for (RangePartitionPruneTest.TestCase testCase : cases) {
-            connectContext.getSessionVariable().partitionPruneAlgorithmVersion = 1;

Review Comment:
   partition prune V1 is to be deleted, and there are some bug. So remove it from test cases



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] hello-stephen commented on pull request #14876: [feature](planner) for original planner: a=1 or a=2 or a=3 or ... => a in ( 1,2,3, ...)

Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #14876:
URL: https://github.com/apache/doris/pull/14876#issuecomment-1340990765

   TeamCity pipeline, clickbench performance test result:
    the sum of best hot time: 35.68 seconds
    load time: 448 seconds
    storage size: 17123356285 Bytes
    https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221207134532_clickbench_pr_59460.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] englefly closed pull request #14876: [feature](planner) for original planner: a=1 or a=2 or a=3 or ... => a in ( 1,2,3, ...)

Posted by GitBox <gi...@apache.org>.
englefly closed pull request #14876: [feature](planner) for original planner: a=1 or a=2 or a=3 or ... => a in ( 1,2,3, ...)
URL: https://github.com/apache/doris/pull/14876


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] github-actions[bot] commented on pull request #14876: [feature](planner) compact multi-euqals to in-predicate

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14876:
URL: https://github.com/apache/doris/pull/14876#issuecomment-1357938811

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] yiguolei merged pull request #14876: [feature](planner) compact multi-euqals to in-predicate

Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #14876:
URL: https://github.com/apache/doris/pull/14876


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] github-actions[bot] commented on pull request #14876: [feature](planner) compact multi-euqals to in-predicate

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14876:
URL: https://github.com/apache/doris/pull/14876#issuecomment-1357938848

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org