[GitHub] [pulsar] Jason918 commented on a change in pull request #13298: [11646][Pulsar Java client] Fix ConfigurationDataUtils loadConf strategy

[GitBox <gi...@apache.org>]

Jason918 commented on a change in pull request #13298:
URL: https://github.com/apache/pulsar/pull/13298#discussion_r805112391



##########
File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/conf/ConsumerConfigurationData.java
##########
@@ -149,12 +147,13 @@ public int getMaxPendingChuckedMessage() {
 
     private boolean resetIncludeHead = false;
 
+    @JsonIgnore

Review comment:
       Can you add some details about why we add `@JsonIgnore ` here? 

##########
File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/conf/ConfigurationDataUtils.java
##########
@@ -51,20 +51,17 @@ public static ObjectMapper getThreadLocal() {
         return mapper.get();
     }
 
-    private ConfigurationDataUtils() {}
+    private ConfigurationDataUtils() {
+    }
 
     public static <T> T loadData(Map<String, Object> config,
-                                 T existingData,
-                                 Class<T> dataCls) {
+                                 T existingData) {

Review comment:
       +1. We can keep the old method and just mark deprecated.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org